From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=QU/o=5V=gmail.com=richard.guenther@sourceware.org>
Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133])
	by sourceware.org (Postfix) with ESMTPS id 874763858C2D
	for <gcc-patches@gcc.gnu.org>; Tue, 24 Jan 2023 08:53:13 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 874763858C2D
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-lf1-x133.google.com with SMTP id w11so18596576lfu.11
        for <gcc-patches@gcc.gnu.org>; Tue, 24 Jan 2023 00:53:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=2UTpeh4L5E0+kIklen5/aYwM7NSfk9MPP4Sa8CMP4lw=;
        b=PKbW7UhDkLZzip8VOUKAbFQo4XB8F1gQSk4kTsC6PQ1gur+M0kW4JBEry1DMe20kkG
         mHXOEaVnY9qW7TVnrkzovWDGcv90fAnZZyumFd3Vo0vh0AeZEK2A3jzuDGrf71g2Y456
         2CEfLE5q2l8hdfYEPg9uCapFwJ30tkIPdEMljlqgYovbW0/LlEMtODXdeQHCcE8SFo/h
         1uapK491+f3Let9pAOO/NlIW1kVWTjvZFQ0mo8tyVYv0Sq+M5ZlGa2fFf0koX1n5ssIo
         auXYYGTTGKuqr7eagicgphzMnvI5uREom9GDb6nN/R46NTa4VXRalaffrFaArxG5aAUz
         tYnA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=2UTpeh4L5E0+kIklen5/aYwM7NSfk9MPP4Sa8CMP4lw=;
        b=WDAI9lW6FG4+jrukdPUUYPUDek7wBdaulZwnn955WCqVAAyUf/HO4ywZAPjU3LXznK
         tQiwBNabCFY0w9+ZLzfOt4XSzhhBSOI1a5hFlgYQ2ASeblLrO+8QwK8ZMY+b4Ae3+EWU
         xBx+oFs6ZqbGvAmzIW/L7v1zbfFQx7lggACgnQ1n5etN8W2YuRE6skHwuoi3AiDar5Mn
         L21Ye6008vEnKsUz2IR3cvRPMf4WchNop9h9LdS+JOWRHzl87BfTFSepJgEk+v7tV0pa
         zI8o+fmdLvk/0QYlm9DIlDpT7w2xmuAqw2hArjmu9NYCXMUYP77K0pRt0O2uvuV6FkTO
         xdDw==
X-Gm-Message-State: AFqh2kqgW/GsEZ6OICG0FU7jvU6oQ9UoXPkBiNc7u3ezMC8CPjDF2qtS
	hVa8NbamCBdo0E2Ppd5RDHurHXhw46epumGLp24=
X-Google-Smtp-Source: AMrXdXtsix1/cN7LvLWuXbiaJ2Tj+t+sOxn4v4CJKCpsigOEHaw6VJwXKK/mncEHGkO34KA1DYZkdTSeXGP1ZpT4Tng=
X-Received: by 2002:a19:675e:0:b0:4b6:f37c:c123 with SMTP id
 e30-20020a19675e000000b004b6f37cc123mr1947381lfj.539.1674550391422; Tue, 24
 Jan 2023 00:53:11 -0800 (PST)
MIME-Version: 1.0
References: <2b7a5b75-aa71-b399-ff07-1f62dfac6cdc@redhat.com>
In-Reply-To: <2b7a5b75-aa71-b399-ff07-1f62dfac6cdc@redhat.com>
From: Richard Biener <richard.guenther@gmail.com>
Date: Tue, 24 Jan 2023 09:52:59 +0100
Message-ID: <CAFiYyc1bYkx4h=1vJAY+mW+LTa+AAPQJeZ1MP0H4qK-4ggTF+w@mail.gmail.com>
Subject: Re: [PATCH 1/2] Use value_relation class instead of direct calls to intersect/union.
To: Andrew MacLeod <amacleod@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, "hernandez, aldy" <aldyh@redhat.com>, 
	Jakub Jelinek <jakub@redhat.com>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Mon, Jan 23, 2023 at 6:44 PM Andrew MacLeod <amacleod@redhat.com> wrote:
>
> In order to fix 108447, this patch changes the calls to relation_union
> and relation_intersection to instead utilize the value_relation class,
> and make the calls through that instead.
>
> value_relation manages the operands of a relation, and thus understands
> whether this is a floating point relation and can make any adjustments
> required to get the proper results.  THis patch doesn't do anything
> additional, just that isolation so we can track if it introduces
> anything speerate from the next change which adds another relation.
>
> Bootstraps on x86_64-pc-linux-gnu with no regressions.  OK?

LGTM

> Andrew