From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by sourceware.org (Postfix) with ESMTPS id E82873856DDE for ; Tue, 18 Jul 2023 14:56:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E82873856DDE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2b8390003e2so72795241fa.0 for ; Tue, 18 Jul 2023 07:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689692173; x=1692284173; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=p1n7QMWowD9f3k/wM2WPNDm1nPN+JugOYHTrL1BZ5HY=; b=XqDoEYdn9fFFCjk2WuflLVPLVIwMpuLjLrdFV9MVEUF8bZHYgMyokE2uyN3dpOC08t nuMAxP+LCoxWD3wUU2un1hnf8X+0JVcGzLleRu6ZEo9+OxtjMENxLzB2FWfEW0HmsAQn utaJix8N7DEMrIYzFn6sK1R+H05pdyZUMVuiOTjv7//keDLhDZpsp6TKuYNquIuD1Gon FkRx1bu4ckFJ04NIP2ME3ZvdBADtz/4cMTgjkAVxLKacPKTQtK47mfM1Chw4sM0+FE68 Jvo3G3dDJRLYrzDVhtuK5UMQJkx9KOmk4j81fsrQt0n2iXc9Rwz4LRsx9rNxlTvD71yD ScHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689692173; x=1692284173; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p1n7QMWowD9f3k/wM2WPNDm1nPN+JugOYHTrL1BZ5HY=; b=S7Bcd6TmEVmzmskj/4q+emjsQjoXGMza9YYd2a0ZNbMmGre/zgJd5DbvCxu9Pe1C+s HwHW+V+/LDyy9AKjeSCb4Tg7BGVFtlTjNm6Ow7JxEMVaXqo3T2KxMqzm1kFcN5ieJ72M Fc0Q47R8H6lejsufHcJEAwAas5s9/LY+JVi2VLImaTrL9M/bILc09wi8Tdkym/9BHxJj fsrBwKIGWel2RewIGsOjXmXBMOTrM+Jm9nFePJ+idfh1BnNDmUE754zVL8c6qmjz6uCl yJnL58P3evwPYri5/WmHCJgAAD2v2yVXu/1P/W4gWU1WYIw1HCsMuedaNR+kj0vdZySh JP9Q== X-Gm-Message-State: ABy/qLaDZOAvkabT0k/QqEskd9u3kRvgBuTUfj77Jw6mbaQVIpOZXqbV E+w9LEXb9t8Rpgt2xD7bkDGQ9m81KZzjZVtidHI= X-Google-Smtp-Source: APBJJlGkNDRpzOk/ktZu/2OKLohCjvMKLlwmRjVnZhPlFuPljcghT2bb6LoOQiVi8wGhAkrVIBUCjLWS9Xn0XRvMo/s= X-Received: by 2002:a2e:6a13:0:b0:2b6:e0d3:45b7 with SMTP id f19-20020a2e6a13000000b002b6e0d345b7mr2158790ljc.14.1689692172830; Tue, 18 Jul 2023 07:56:12 -0700 (PDT) MIME-Version: 1.0 References: <7302f8a2fa2f95252b32de2dc826591e75230662.1689689650.git.fweimer@redhat.com> In-Reply-To: <7302f8a2fa2f95252b32de2dc826591e75230662.1689689650.git.fweimer@redhat.com> From: Richard Biener Date: Tue, 18 Jul 2023 16:56:00 +0200 Message-ID: Subject: Re: [PATCH releases/gcc-13 1/2] libgcc: Fix eh_frame fast path in find_fde_tail To: Florian Weimer Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jul 18, 2023 at 4:19=E2=80=AFPM Florian Weimer via Gcc-patches wrote: > > The eh_frame value is only used by linear_search_fdes, not the binary > search directly in find_fde_tail, so the bug is not immediately > apparent with most programs. > > Fixes commit e724b0480bfa5ec04f39be8c7290330b495c59de ("libgcc: > Special-case BFD ld unwind table encodings in find_fde_tail"). Both are OK to backport. > libgcc/ > > PR libgcc/109712 > * unwind-dw2-fde-dip.c (find_fde_tail): Correct fast path for > parsing eh_frame. > > (cherry picked from commit 49310a993308492348119f4033e4db0bda4fe46a) > --- > libgcc/unwind-dw2-fde-dip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libgcc/unwind-dw2-fde-dip.c b/libgcc/unwind-dw2-fde-dip.c > index 6223f5f18a2..4e0b880513f 100644 > --- a/libgcc/unwind-dw2-fde-dip.c > +++ b/libgcc/unwind-dw2-fde-dip.c > @@ -403,8 +403,8 @@ find_fde_tail (_Unwind_Ptr pc, > BFD ld generates. */ > signed value __attribute__ ((mode (SI))); > memcpy (&value, p, sizeof (value)); > + eh_frame =3D p + value; > p +=3D sizeof (value); > - dbase =3D value; /* No adjustment because pcrel has base= 0. */ > } > else > p =3D read_encoded_value_with_base (hdr->eh_frame_ptr_enc, > > base-commit: a1322d76ca1c3c914fb818d9ba3edc291ccfa25e > -- > 2.41.0 > >