* [PATCH] Makefile.tpl: Add check-g++
@ 2020-09-08 9:34 Hu Jiangping
2020-09-09 7:33 ` Richard Biener
0 siblings, 1 reply; 4+ messages in thread
From: Hu Jiangping @ 2020-09-08 9:34 UTC (permalink / raw)
To: gcc-patches
This patch add a new check-g++ target to the Makefile under toplevel,
as synonym of the check-c++ target.
It is to be consistent with the check-g++ target under the gcc
subdirectory. And because check-gcc can be performed under toplevel,
it is very possible that check-g++ may be performed under toplevel,
but now it gives 'No rule to make target.' error.
ChangeLog:
2020-09-08 Hu Jiangping <hujiangping@cn.fujitsu.com>
Makefile.tpl (check-g++): New target. As synonym of check-c++.
Makefile.in: Regenerated.
Bootstraped on aarch64. Ok for master?
Regards!
Hujp
---
Makefile.in | 3 +++
Makefile.tpl | 3 +++
2 files changed, 6 insertions(+)
diff --git a/Makefile.in b/Makefile.in
index 36e369df6e7..35b57d5af21 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -55554,6 +55554,9 @@ check-gcc-d:
check-d: check-gcc-d check-target-libphobos
+.PHONY: check-g++
+check-g++: check-c++
+
# The gcc part of install-no-fixedincludes, which relies on an intimate
# knowledge of how a number of gcc internal targets (inter)operate. Delegate.
.PHONY: gcc-install-no-fixedincludes
diff --git a/Makefile.tpl b/Makefile.tpl
index efed1511750..6dfe3c9caca 100644
--- a/Makefile.tpl
+++ b/Makefile.tpl
@@ -1542,6 +1542,9 @@ check-gcc-[+language+]:
check-[+language+]: check-gcc-[+language+][+ FOR lib-check-target +] [+ lib-check-target +][+ ENDFOR lib-check-target +]
[+ ENDFOR languages +]
+.PHONY: check-g++
+check-g++: check-c++
+
# The gcc part of install-no-fixedincludes, which relies on an intimate
# knowledge of how a number of gcc internal targets (inter)operate. Delegate.
.PHONY: gcc-install-no-fixedincludes
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Makefile.tpl: Add check-g++
2020-09-08 9:34 [PATCH] Makefile.tpl: Add check-g++ Hu Jiangping
@ 2020-09-09 7:33 ` Richard Biener
2020-09-09 8:40 ` Hu, Jiangping
0 siblings, 1 reply; 4+ messages in thread
From: Richard Biener @ 2020-09-09 7:33 UTC (permalink / raw)
To: Hu Jiangping; +Cc: GCC Patches
On Tue, Sep 8, 2020 at 11:35 AM Hu Jiangping <hujiangping@cn.fujitsu.com> wrote:
>
> This patch add a new check-g++ target to the Makefile under toplevel,
> as synonym of the check-c++ target.
>
> It is to be consistent with the check-g++ target under the gcc
> subdirectory. And because check-gcc can be performed under toplevel,
> it is very possible that check-g++ may be performed under toplevel,
> but now it gives 'No rule to make target.' error.
I don't think this is correct. The toplevel check-gcc is not a simple
alias for gcc/ check-gcc, instead it is for the whole gcc/ subdirectory
checks.
Richard.
>
> ChangeLog:
> 2020-09-08 Hu Jiangping <hujiangping@cn.fujitsu.com>
>
> Makefile.tpl (check-g++): New target. As synonym of check-c++.
> Makefile.in: Regenerated.
>
> Bootstraped on aarch64. Ok for master?
>
> Regards!
> Hujp
>
> ---
> Makefile.in | 3 +++
> Makefile.tpl | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/Makefile.in b/Makefile.in
> index 36e369df6e7..35b57d5af21 100644
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -55554,6 +55554,9 @@ check-gcc-d:
> check-d: check-gcc-d check-target-libphobos
>
>
> +.PHONY: check-g++
> +check-g++: check-c++
> +
> # The gcc part of install-no-fixedincludes, which relies on an intimate
> # knowledge of how a number of gcc internal targets (inter)operate. Delegate.
> .PHONY: gcc-install-no-fixedincludes
> diff --git a/Makefile.tpl b/Makefile.tpl
> index efed1511750..6dfe3c9caca 100644
> --- a/Makefile.tpl
> +++ b/Makefile.tpl
> @@ -1542,6 +1542,9 @@ check-gcc-[+language+]:
> check-[+language+]: check-gcc-[+language+][+ FOR lib-check-target +] [+ lib-check-target +][+ ENDFOR lib-check-target +]
> [+ ENDFOR languages +]
>
> +.PHONY: check-g++
> +check-g++: check-c++
> +
> # The gcc part of install-no-fixedincludes, which relies on an intimate
> # knowledge of how a number of gcc internal targets (inter)operate. Delegate.
> .PHONY: gcc-install-no-fixedincludes
> --
> 2.17.1
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] Makefile.tpl: Add check-g++
2020-09-09 7:33 ` Richard Biener
@ 2020-09-09 8:40 ` Hu, Jiangping
2020-09-09 8:48 ` Richard Biener
0 siblings, 1 reply; 4+ messages in thread
From: Hu, Jiangping @ 2020-09-09 8:40 UTC (permalink / raw)
To: Richard Biener; +Cc: GCC Patches
Hi, Richard
> On Tue, Sep 8, 2020 at 11:35 AM Hu Jiangping <hujiangping@cn.fujitsu.com>
> wrote:
> >
> > This patch add a new check-g++ target to the Makefile under toplevel,
> > as synonym of the check-c++ target.
> >
> > It is to be consistent with the check-g++ target under the gcc
> > subdirectory. And because check-gcc can be performed under toplevel,
> > it is very possible that check-g++ may be performed under toplevel,
> > but now it gives 'No rule to make target.' error.
>
> I don't think this is correct. The toplevel check-gcc is not a simple
> alias for gcc/ check-gcc, instead it is for the whole gcc/ subdirectory
> checks.
Thanks for reply.
Yes, I know what toplevel check-gcc do, and the difference with gcc / check-gcc.
IIUC you mean if we add toplevel check-g++, it will make the toplevel check-gcc
and check-g++ a little strange, because toplevel check-gcc is not only for c,
while toplevel check-g++ is only for c++.
I agree with you on this point. And I thought about that before.
I just thought that toplevel check-g++ is easy to be executed incorrectly,
so can we make it do some right things as misunderstood. As for whether the
meanings of check-gcc and check-g++ are inconsistent, it may not be that
important, or we could modify the document https://gcc.gnu.org/install/test.html
to describe what they actually do.
Thanks again. I agree with you more now.
Regards!
Hujp
>
> Richard.
>
> >
> > ChangeLog:
> > 2020-09-08 Hu Jiangping <hujiangping@cn.fujitsu.com>
> >
> > Makefile.tpl (check-g++): New target. As synonym of check-c++.
> > Makefile.in: Regenerated.
> >
> > Bootstraped on aarch64. Ok for master?
> >
> > Regards!
> > Hujp
> >
> > ---
> > Makefile.in | 3 +++
> > Makefile.tpl | 3 +++
> > 2 files changed, 6 insertions(+)
> >
> > diff --git a/Makefile.in b/Makefile.in
> > index 36e369df6e7..35b57d5af21 100644
> > --- a/Makefile.in
> > +++ b/Makefile.in
> > @@ -55554,6 +55554,9 @@ check-gcc-d:
> > check-d: check-gcc-d check-target-libphobos
> >
> >
> > +.PHONY: check-g++
> > +check-g++: check-c++
> > +
> > # The gcc part of install-no-fixedincludes, which relies on an intimate
> > # knowledge of how a number of gcc internal targets (inter)operate.
> Delegate.
> > .PHONY: gcc-install-no-fixedincludes
> > diff --git a/Makefile.tpl b/Makefile.tpl
> > index efed1511750..6dfe3c9caca 100644
> > --- a/Makefile.tpl
> > +++ b/Makefile.tpl
> > @@ -1542,6 +1542,9 @@ check-gcc-[+language+]:
> > check-[+language+]: check-gcc-[+language+][+ FOR lib-check-target +] [+
> lib-check-target +][+ ENDFOR lib-check-target +]
> > [+ ENDFOR languages +]
> >
> > +.PHONY: check-g++
> > +check-g++: check-c++
> > +
> > # The gcc part of install-no-fixedincludes, which relies on an intimate
> > # knowledge of how a number of gcc internal targets (inter)operate.
> Delegate.
> > .PHONY: gcc-install-no-fixedincludes
> > --
> > 2.17.1
> >
> >
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Makefile.tpl: Add check-g++
2020-09-09 8:40 ` Hu, Jiangping
@ 2020-09-09 8:48 ` Richard Biener
0 siblings, 0 replies; 4+ messages in thread
From: Richard Biener @ 2020-09-09 8:48 UTC (permalink / raw)
To: Hu, Jiangping; +Cc: GCC Patches
On Wed, Sep 9, 2020 at 10:43 AM Hu, Jiangping
<hujiangping@cn.fujitsu.com> wrote:
>
> Hi, Richard
>
> > On Tue, Sep 8, 2020 at 11:35 AM Hu Jiangping <hujiangping@cn.fujitsu.com>
> > wrote:
> > >
> > > This patch add a new check-g++ target to the Makefile under toplevel,
> > > as synonym of the check-c++ target.
> > >
> > > It is to be consistent with the check-g++ target under the gcc
> > > subdirectory. And because check-gcc can be performed under toplevel,
> > > it is very possible that check-g++ may be performed under toplevel,
> > > but now it gives 'No rule to make target.' error.
> >
> > I don't think this is correct. The toplevel check-gcc is not a simple
> > alias for gcc/ check-gcc, instead it is for the whole gcc/ subdirectory
> > checks.
> Thanks for reply.
>
> Yes, I know what toplevel check-gcc do, and the difference with gcc / check-gcc.
> IIUC you mean if we add toplevel check-g++, it will make the toplevel check-gcc
> and check-g++ a little strange, because toplevel check-gcc is not only for c,
> while toplevel check-g++ is only for c++.
>
> I agree with you on this point. And I thought about that before.
> I just thought that toplevel check-g++ is easy to be executed incorrectly,
> so can we make it do some right things as misunderstood. As for whether the
> meanings of check-gcc and check-g++ are inconsistent, it may not be that
> important, or we could modify the document https://gcc.gnu.org/install/test.html
> to describe what they actually do.
To word it differently:
The toplevel make check-gcc is to test the gcc module, since there is no c++
module a toplevel check-c++ does not make sense.
Richard.
> Thanks again. I agree with you more now.
>
> Regards!
> Hujp
>
> >
> > Richard.
> >
> > >
> > > ChangeLog:
> > > 2020-09-08 Hu Jiangping <hujiangping@cn.fujitsu.com>
> > >
> > > Makefile.tpl (check-g++): New target. As synonym of check-c++.
> > > Makefile.in: Regenerated.
> > >
> > > Bootstraped on aarch64. Ok for master?
> > >
> > > Regards!
> > > Hujp
> > >
> > > ---
> > > Makefile.in | 3 +++
> > > Makefile.tpl | 3 +++
> > > 2 files changed, 6 insertions(+)
> > >
> > > diff --git a/Makefile.in b/Makefile.in
> > > index 36e369df6e7..35b57d5af21 100644
> > > --- a/Makefile.in
> > > +++ b/Makefile.in
> > > @@ -55554,6 +55554,9 @@ check-gcc-d:
> > > check-d: check-gcc-d check-target-libphobos
> > >
> > >
> > > +.PHONY: check-g++
> > > +check-g++: check-c++
> > > +
> > > # The gcc part of install-no-fixedincludes, which relies on an intimate
> > > # knowledge of how a number of gcc internal targets (inter)operate.
> > Delegate.
> > > .PHONY: gcc-install-no-fixedincludes
> > > diff --git a/Makefile.tpl b/Makefile.tpl
> > > index efed1511750..6dfe3c9caca 100644
> > > --- a/Makefile.tpl
> > > +++ b/Makefile.tpl
> > > @@ -1542,6 +1542,9 @@ check-gcc-[+language+]:
> > > check-[+language+]: check-gcc-[+language+][+ FOR lib-check-target +] [+
> > lib-check-target +][+ ENDFOR lib-check-target +]
> > > [+ ENDFOR languages +]
> > >
> > > +.PHONY: check-g++
> > > +check-g++: check-c++
> > > +
> > > # The gcc part of install-no-fixedincludes, which relies on an intimate
> > > # knowledge of how a number of gcc internal targets (inter)operate.
> > Delegate.
> > > .PHONY: gcc-install-no-fixedincludes
> > > --
> > > 2.17.1
> > >
> > >
> > >
> >
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-09 8:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-08 9:34 [PATCH] Makefile.tpl: Add check-g++ Hu Jiangping
2020-09-09 7:33 ` Richard Biener
2020-09-09 8:40 ` Hu, Jiangping
2020-09-09 8:48 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).