From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by sourceware.org (Postfix) with ESMTPS id 715A33858D28 for ; Mon, 27 May 2024 06:32:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 715A33858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 715A33858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::134 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716791555; cv=none; b=KQUv2Szt/E06jRxR9VpC14VG43LJ6Ahj4HnBueaR6yxtJrLMNp5l8jP5b76UQVVAyIe3Fvdcdokl4Qygh5uZIKJpZ5gKeEyqBAqMe5Ts7au7u2cxeIAoGVFPIksn9jgq1t3ih3jGc2foRLUcPdbNQHJGcnwxx5K+/jivmS0fWxo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716791555; c=relaxed/simple; bh=LjJC/IJKHZn9YOSsQxyllV8rL3GkujwUUMCVPr1cPXo=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=UAdWe6UJqnnIeJSTvOUk9cgu52r2eIbgJrE7i62VxCvSl6sORty9NO3yhMIfA67B5CYpwMdxFTKpRtg6lxhXKfBpChckq9HtLJPRAMdF8waXVUh6kTYu1Tn86gr3WwmdmeW91eVpz/5No6lPLFspbq+0TU2CteFM0PXgc4hhEog= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-5296935252dso2680700e87.3 for ; Sun, 26 May 2024 23:32:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716791552; x=1717396352; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=m9+Qeyy5IUJdA/c/FuiQ/tMeHrUFQprDNjaDrfgRo6w=; b=WLJMuJedPSiP8yN1G2StbFeFfc0HsIyE8YU3C0IiQuRKZsbT7aZ8ILNNqhDNdMvcEz yCOqWbtlH0dr+0FbPXMKRP+vrD5r0/rP3snDK2N8ERIkCRNdJg6LCBJJmo5hv+XPsl3I 4wusMK/suebpGh0L1YvUv0g2G07SbV/oOwC/g5E0D+F+WDYIs5Zzgdd3beCae9s7QtGo aUpUowhCrR+QzQKMjycjdMAko/05C9GQ+A6BrXYBeKjFryPX6yIKNLlLAXC8C+Ng4rOC FL5KJeu9bhu2QBNd2raWB6c6ZZpsEQjuNncerrvSuREH7uIkLZiCspCccXctfwIAUbFN ZU0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716791552; x=1717396352; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m9+Qeyy5IUJdA/c/FuiQ/tMeHrUFQprDNjaDrfgRo6w=; b=IQjHvtQYH8i1jLGz9Y+5apv0Rd8YpN9ilSj9GR1LLz+/Y5VqF+ntnNdwsptetEo0qX uw18YxGe+FAPhaPf7l/HysooyqBm+SrmRn1lVkvc2sMjrErJX5XVpRk51wQzDiIY3BCj WDHCpZ82eHY1MsgstjuX2M42XAOHyxp1SKlBknLrb0Pl84Cr2Z6GpQ7znKAmp+uoFmUK 7EY44zSyDhz1Q0T0VqSXWi9wBIgutmHD23kCiRUWEkX9yzg19cZd0ExIlBXN/899kxIU VpxH+aMf7wqgMU908yLMLfMXq5mXkd/0ZEIp4hPXZ9v/rvqrw02w4uZBQKfqnue84efx g38g== X-Gm-Message-State: AOJu0YwPTpdCtBXeMpbVr0HgvmYg7nx+OPAUtk767yoUkb4+FGLgTSud 6ByelXVTJRzJz2tdBWguCgdZMe6QSZOqYHGXONvFEVniQP4FiGxXL22YeCa849GGgygLHwzPxK+ bw9pBVexwd9waVAxw1EH/6Z6baAykgw== X-Google-Smtp-Source: AGHT+IGiwFz5zURzymURBsOBHtvQo8l87sEibci4qLuzixLbX4KzRPF8WbUafZGTFO+558w9CCrG3w8iVtqqU8xQ4mY= X-Received: by 2002:a05:6512:220b:b0:51e:e703:c878 with SMTP id 2adb3069b0e04-529646e3c0cmr6322044e87.14.1716791551574; Sun, 26 May 2024 23:32:31 -0700 (PDT) MIME-Version: 1.0 References: <20240527041303.1073788-1-quic_apinski@quicinc.com> In-Reply-To: <20240527041303.1073788-1-quic_apinski@quicinc.com> From: Richard Biener Date: Mon, 27 May 2024 08:32:20 +0200 Message-ID: Subject: Re: [PATCH] match: Use uniform_integer_cst_p in bitwise_inverted_equal_p [PR115238] To: Andrew Pinski Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, May 27, 2024 at 6:14=E2=80=AFAM Andrew Pinski wrote: > > I noticed while working on the `a ^ CST` patch, that bitwise_inverted_equ= al_p > would check INTEGER_CST directly and not handle vector csts that are unif= orm. > This moves over to using uniform_integer_cst_p instead of checking INTEGE= R_CST > directly. > > Bootstrapped and tested on x86_64-linux-gnu with no regressions. OK > PR tree-optimization/115238 > > gcc/ChangeLog: > > * generic-match-head.cc (bitwise_inverted_equal_p): Use > uniform_integer_cst_p instead of checking INTEGER_CST. > * gimple-match-head.cc (gimple_bitwise_inverted_equal_p): Likewis= e. > > gcc/testsuite/ChangeLog: > > * gcc.dg/tree-ssa/bitops-9.c: New test. > > Signed-off-by: Andrew Pinski > --- > gcc/generic-match-head.cc | 6 ++++-- > gcc/gimple-match-head.cc | 6 ++++-- > gcc/testsuite/gcc.dg/tree-ssa/bitops-9.c | 15 +++++++++++++++ > 3 files changed, 23 insertions(+), 4 deletions(-) > create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/bitops-9.c > > diff --git a/gcc/generic-match-head.cc b/gcc/generic-match-head.cc > index 3709fe5456d..641d8e9b2de 100644 > --- a/gcc/generic-match-head.cc > +++ b/gcc/generic-match-head.cc > @@ -146,8 +146,10 @@ bitwise_inverted_equal_p (tree expr1, tree expr2, bo= ol &wascmp) > return false; > if (!tree_nop_conversion_p (TREE_TYPE (expr1), TREE_TYPE (expr2))) > return false; > - if (TREE_CODE (expr1) =3D=3D INTEGER_CST && TREE_CODE (expr2) =3D=3D I= NTEGER_CST) > - return wi::to_wide (expr1) =3D=3D ~wi::to_wide (expr2); > + tree cst1 =3D uniform_integer_cst_p (expr1); > + tree cst2 =3D uniform_integer_cst_p (expr2); > + if (cst1 && cst2) > + return wi::to_wide (cst1) =3D=3D ~wi::to_wide (cst2); > if (operand_equal_p (expr1, expr2, 0)) > return false; > if (TREE_CODE (expr1) =3D=3D BIT_NOT_EXPR > diff --git a/gcc/gimple-match-head.cc b/gcc/gimple-match-head.cc > index d5908f4e9a6..e26fa0860ee 100644 > --- a/gcc/gimple-match-head.cc > +++ b/gcc/gimple-match-head.cc > @@ -295,8 +295,10 @@ gimple_bitwise_inverted_equal_p (tree expr1, tree ex= pr2, bool &wascmp, tree (*va > return false; > if (!tree_nop_conversion_p (TREE_TYPE (expr1), TREE_TYPE (expr2))) > return false; > - if (TREE_CODE (expr1) =3D=3D INTEGER_CST && TREE_CODE (expr2) =3D=3D I= NTEGER_CST) > - return wi::to_wide (expr1) =3D=3D ~wi::to_wide (expr2); > + tree cst1 =3D uniform_integer_cst_p (expr1); > + tree cst2 =3D uniform_integer_cst_p (expr2); > + if (cst1 && cst2) > + return wi::to_wide (cst1) =3D=3D ~wi::to_wide (cst2); > if (operand_equal_p (expr1, expr2, 0)) > return false; > > diff --git a/gcc/testsuite/gcc.dg/tree-ssa/bitops-9.c b/gcc/testsuite/gcc= .dg/tree-ssa/bitops-9.c > new file mode 100644 > index 00000000000..a18b6bf3214 > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/tree-ssa/bitops-9.c > @@ -0,0 +1,15 @@ > +/* { dg-do compile } */ > +/* { dg-options "-O2 -fdump-tree-optimized-raw" } */ > +/* PR tree-optimization/115238 */ > + > + > +#define vector8 __attribute__((vector_size(2*sizeof(int)))) > + > +void f(int a, vector8 int *b) > +{ > + a =3D 1; > + *b =3D a | ((~a) ^ *b); > +} > +/* { dg-final { scan-tree-dump-not "bit_xor_expr, " "optimized" = } } */ > +/* { dg-final { scan-tree-dump-times "bit_ior_expr, " 1 "optimized" = } } */ > +/* { dg-final { scan-tree-dump-times "bit_not_expr, " 1 "optimized" = } } */ > -- > 2.43.0 >