From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by sourceware.org (Postfix) with ESMTPS id F015F3858C2B for ; Fri, 10 Nov 2023 13:32:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F015F3858C2B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F015F3858C2B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::129 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699623166; cv=none; b=RBnz4mvkdr0KSM8aTvEr8NfYgqnNoFutsm6lL0i6k/LdgBcx9vtJJjuw3VKuG4XFtGbdrkyBD9tg6olupANryIpLJLFi64eZOTwr11uAfH/m+pIyHG8KsXZTJkCNss98v4iSLdghntbMbxLSW63AjuIqDTR9qjrJW4S+5RoDFCM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699623166; c=relaxed/simple; bh=3NLpSNRO3ovkkjGK2YzWmR+CsOkOhfYNdRmX4JwCEAQ=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=JBLWkmPhkBh/jw097DQkt2+0uONU0/o9Qz3a3VzLivpCeUrAhJa7sewtPnXKbUvJKRCUGU12NLlalmCAg9YgCIfde/BGyhhPO3PjSMOAQUQWhOK499siyMbbm192qwYEAGWOrPodmG/KEDZxdkFBCS8zAEtTT4Bi/L8VBpRqgqg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-50943ccbbaeso2869954e87.2 for ; Fri, 10 Nov 2023 05:32:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699623162; x=1700227962; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6oX5YqJe6JDCh89ziLHvAI+yKWskb3PqEPpkjUDplPU=; b=M4oB30zs+7am6a6yYOSTpX4olIdJzjVOQ5iJfzKE1zPKkFGHzAn3Dv71wajsRy8H8Y RpB8h0PilMy0SDdFCeuQ+9ap0HsUh58H9U3hRxr4O13YIqtERNJqLKkKxesa1tZZ+64p eE5rhE4Es+koTbtsK1rtOA0MYD5iqPyoUyYJ9YRmjZ1L0VT4sg2yCiPVORvUvkMegXJM 4vfyt8pMMY+LLiRIyztxhmjpaYC4z40XYZBES1bZNp2Qt62B9SS3aRqbHKYur7pL1QA2 fY7asN+D3lyFltkwl0woeB9zZYQmLj+wfxMYji+oCCPks54tpUigEAdcp+O2RNXnqUMw NNiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699623162; x=1700227962; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6oX5YqJe6JDCh89ziLHvAI+yKWskb3PqEPpkjUDplPU=; b=tNLkg5isi3Wg2Vi2GBABQ/b0SlJyPfTZt0bjlZVq4PikO4Kh8TM7rC0ZryPjVplckW dkGaWV3GiAb/ecLf5PVM9zkLSLcZNp3zY5KbVl2OcV6mw8lTNxb4xnLwnN68GSjC0kmN 6NP2oG8pWCvdjqFbNNEAMGDnD0j0jVWB47W+V39hj6RhJtoDttA9Sf4jCuPuL8druCBy nlT5mK6Wfk8fK3ewKL4t/TPzmwRldLsDQW29QfucajKHT0O+kRXkd5HxVwzL4qcAAiKN MBun8rZBRfoPDT1nnetlUE5/7qx454pK6+lq8RUhMYeCqJXOpp8MFUuPV/UDR446M+Hs XAlw== X-Gm-Message-State: AOJu0YxcO6tJyhWk7s+6Wba4t2g14gNu8XkhEXfud0W7DsHnSh52qmn+ b7BBKXHjioNkzDGdSQWypxBdB0aHsNb9T/xhatQ= X-Google-Smtp-Source: AGHT+IGGTqLTah8hPF3rV2B+Bu2HJG94JgL07oyT7iUb+BgIOrD++leP1sNn90Apep0oSocKuHga3mdxCdcpTHyT/eA= X-Received: by 2002:a19:5216:0:b0:509:4d95:e896 with SMTP id m22-20020a195216000000b005094d95e896mr3736934lfb.66.1699623162074; Fri, 10 Nov 2023 05:32:42 -0800 (PST) MIME-Version: 1.0 References: <85b4098e-a72f-d013-ff17-8097971f71ba@linux.ibm.com> <09FEFDAE-698B-4B06-A896-8088B9B31539@linaro.org> <4675c26c-f230-b6d6-27c5-bc9f74736e38@linux.ibm.com> <41a4d065-c4b6-4a67-adf0-e84e942616c7@gmail.com> <93ce3468-a1ee-e77c-cbeb-a8c67a303bf9@ispras.ru> In-Reply-To: <93ce3468-a1ee-e77c-cbeb-a8c67a303bf9@ispras.ru> From: Richard Biener Date: Fri, 10 Nov 2023 14:32:29 +0100 Message-ID: Subject: Re: PING^1 [PATCH v3] sched: Change no_real_insns_p to no_real_nondebug_insns_p [PR108273] To: Alexander Monakov Cc: Jeff Law , "Kewen.Lin" , Maxim Kuvyrkov , GCC Patches , Richard Sandiford , Jeff Law , Vladimir Makarov , zhroma@ispras.ru, Andrey Belevantsev , Segher Boessenkool , Peter Bergner , Michael Meissner , Alexandre Oliva Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Nov 10, 2023 at 12:25=E2=80=AFPM Alexander Monakov wrote: > > > On Thu, 9 Nov 2023, Jeff Law wrote: > > > > Yeah, I noticed that the scheduler takes care of DEBUG_INSNs as norma= l > > > operations. When I started to work on this issue, initially I wanted= to try > > > something similar to your idea #2, but when checking the APIs, I real= ized > > > why not just skip the basic block with NOTEs and LABELs, DEBUG_INSNs = as > > > well. IMHO there is no value to try to schedule this kind of BB (to = be > > > scheduled range), skipping it can save some resource allocation (like= block > > > dependencies) and make it more efficient (not enter function schedule= _block > > > etc.), from this perspective it seems an enhancement. Does it sound > > > reasonable to you? > > It sounds reasonable, but only if doing so doesn't add significant > > implementation complexity. ie, the gains from doing less work here are= likely > > to be very marginal, so I'm more interested in clean, easy to maintain = code. > > I'm afraid ignoring debug-only BBs goes contrary to overall var-tracking = design: > DEBUG_INSNs participate in dependency graph so that schedulers can remove= or > mutate them as needed when moving real insns across them. Note that debug-only BBs do not exist - the BB would be there even without = debug insns! So instead you have to handle BBs with just debug insns the same yo= u handle a completely empty BB. > Cc'ing Alexandre Oliva who can correct me on that if necessary. > > Alexander