From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by sourceware.org (Postfix) with ESMTPS id 321FF3858C5F for ; Thu, 18 May 2023 06:16:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 321FF3858C5F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-4f27b65bbf9so1894445e87.0 for ; Wed, 17 May 2023 23:16:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684390568; x=1686982568; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=O9wvxfZu4h4BtWhX0Xcpoq+W8w9PKUCEpJa0Ajin7MU=; b=WKQnF1zri2UDYKsCbFumrpb/WiHE00tWbDLap+X2jP0ugMSk28okrYmStkBfLo8mB4 Ni9d/oxQrDg/GY8oyjyxCs/gnKYBOZ2rILXw8PKjVSH8rXwHaRNxVedzxGDKKkKvCUId TAJtUbfExMyQTjs1zKYpPiE12VuhcJwnd7Awk0WQHiRRlcWGIS5+9iTT8oJpy43Q15lO 2TocFoEwrczbHBCtYKS+BFF0JTGZxYZA/uZBUWzt2m3ucVGAfJpQZlpRoNZWg9KzWmF9 zATpMt0yICjiVptbbyHUz5JvrK4s8ATX2Q1xYaZi1hGzfHld9gbv5usLnw6LNXo+5J4v nE/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684390568; x=1686982568; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O9wvxfZu4h4BtWhX0Xcpoq+W8w9PKUCEpJa0Ajin7MU=; b=CnrRYWtW9/ifmnjf+OJlGr7GDvgnFjBek3KigKdcRmpsYsPlov5JlYIQSwVVxkZNDN Boia06UJrUZJ14SF9RcX5l99GaIWq15hEGBtwrsu9A2w2NWRSRuuDpBg7zyBIGmbbXZG 7ZkX5QM+ISlu2RJIJJ+bb3CDjTFge+fE37124q6gE1yBrctzWD0Bzgf8Y6sBOhY7c5nQ jXqn4x2GpFVN7juGXJxguB3Zj33latfOrUWZMsl5HxgiUpuKNentH092jeXelEei03FJ ptjPoNZszrOCxIdkivFQ175Tntm7UqvijCrI7NHWFUyeiGrnAIgiaO6mHlnUPtVwOU4r NcJA== X-Gm-Message-State: AC+VfDw+IcrDQ5I+ZfhBQ5nRl1m7fm4Yjbpin6p4ZkNRPjJA9kRApLZI /J1b5RwG/TS7iXiNakPdKlcf0sl5ibxFiZZTZqmQL3F98NU= X-Google-Smtp-Source: ACHHUZ4S2Jo3gCQ9qomNjRZeAKZLaXwh48S5mRsB2cbFfBV4hMUaSF/7o1Jq5LEGtSiYYxMqNka3nsNud4+MUuH1Lrs= X-Received: by 2002:a19:ac0d:0:b0:4f3:8411:f146 with SMTP id g13-20020a19ac0d000000b004f38411f146mr914939lfc.68.1684390568337; Wed, 17 May 2023 23:16:08 -0700 (PDT) MIME-Version: 1.0 References: <20230517184352.32144-1-amonakov@ispras.ru> In-Reply-To: <20230517184352.32144-1-amonakov@ispras.ru> From: Richard Biener Date: Thu, 18 May 2023 08:15:56 +0200 Message-ID: Subject: Re: [committed] tree-ssa-math-opts: correct -ffp-contract= check To: Alexander Monakov Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, May 17, 2023 at 8:44=E2=80=AFPM Alexander Monakov via Gcc-patches wrote: > > Since tree-ssa-math-opts may freely contract across statement boundaries > we should enable it only for -ffp-contract=3Dfast instead of disabling it > for -ffp-contract=3Doff. > > No functional change, since -ffp-contract=3Don is not exposed yet. OK. > gcc/ChangeLog: > > * tree-ssa-math-opts.cc (convert_mult_to_fma): Enable only for > FP_CONTRACT_FAST (no functional change). > --- > > Preapproved in PR 106092, pushed to trunk. > > gcc/tree-ssa-math-opts.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/tree-ssa-math-opts.cc b/gcc/tree-ssa-math-opts.cc > index b58a2ac9e6..d71c51dc0e 100644 > --- a/gcc/tree-ssa-math-opts.cc > +++ b/gcc/tree-ssa-math-opts.cc > @@ -3320,7 +3320,7 @@ convert_mult_to_fma (gimple *mul_stmt, tree op1, tr= ee op2, > imm_use_iterator imm_iter; > > if (FLOAT_TYPE_P (type) > - && flag_fp_contract_mode =3D=3D FP_CONTRACT_OFF) > + && flag_fp_contract_mode !=3D FP_CONTRACT_FAST) > return false; > > /* We don't want to do bitfield reduction ops. */ > -- > 2.39.2 >