From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=uc+a=4A=gmail.com=richard.guenther@sourceware.org>
Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f])
	by sourceware.org (Postfix) with ESMTPS id 2AF5A3858D3C
	for <gcc-patches@gcc.gnu.org>; Fri,  2 Dec 2022 14:52:48 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2AF5A3858D3C
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-lf1-x12f.google.com with SMTP id p36so3382401lfa.12
        for <gcc-patches@gcc.gnu.org>; Fri, 02 Dec 2022 06:52:48 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=VFzyPljYTQiE7STa4Ab3JcttVfSLJxSsEXpJzvc3nY4=;
        b=ASkfjgM7RVXQkEiFf71arVdJQgx1RFYs7mZl4Nkljbkug8iYxN6Giolpq5//8XuUf1
         mVHBEJ+Jd72T1dXtQm2PotWsSr52M0iuY71Hb/WzIEIN/o2cBqiDfwhnWKbNStEvUA8b
         s7uIZK1y0cWIPOiCgEXsOMiMVjAdJ/SLCMHeW23CsBUpBoNbuNYrVPHIodUQ7JfnX2Oi
         DxFTli/vUhRGZJTzPdzwW4rDKze6nFbujZWM2DkwWg7uSqwhK5eBxlYs2EqcVAeh+rKG
         4ZyQtdDF3NXC7oz2HhQC/a2WMOROb2GxzB35KfQfLlv71A/mrOeYIKydpLHjVclF5vy0
         JzCQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=VFzyPljYTQiE7STa4Ab3JcttVfSLJxSsEXpJzvc3nY4=;
        b=OLkFjfrYvumJ5hYNXIPIgNo3dxUNbhmWBK65ddkEuNhbZuoDLTPj9TW9fJza3h/Hmq
         N20GDPPAAUlHvhL2Uer8EN+Iu/TTfRfsTK7/uCL3o++aM6QFL5jNQNbzE56BuiiYogVk
         uo5QHB+Rn7EsAtNQWqaXv7ZwnHPNw+sZT7jAbs2PCYPjRPAG/D9eE2ay+5Rgr7SKRjE5
         +/8lX9isxYidwbxHlqbjTZpAAxVduCsWY4y5PeU4MtYNxvHCYSlw5IKxczqfXjd01yw0
         Y3GpM2QztPc4it4SNWKpijwyZ5h/jKUdyhISXNhFF7xkBkEEeV8tdoS+DWTxynoRezLl
         wI0Q==
X-Gm-Message-State: ANoB5pn0cOA+DMYXDeDZEXy4dqVv2dYDSfEI53JJEFDb4Dw2fbxmZVf+
	trqyYkQAJJd/TfBxnE/U0duasoP9wLVj3mG1X0Y=
X-Google-Smtp-Source: AA0mqf47QYj16DAGxF4SqjB27QgQeewR1lO3Mswxk7zBUmrGh6X5iRiOO78N+WqogxFxXM2Fhtbj8g72oVlUDFsCbVQ=
X-Received: by 2002:a05:6512:3a96:b0:4b4:f5da:fb28 with SMTP id
 q22-20020a0565123a9600b004b4f5dafb28mr13465354lfu.169.1669992766507; Fri, 02
 Dec 2022 06:52:46 -0800 (PST)
MIME-Version: 1.0
References: <cbc8f41c-fe12-b7af-c906-e19f1ce1224e@redhat.com>
In-Reply-To: <cbc8f41c-fe12-b7af-c906-e19f1ce1224e@redhat.com>
From: Richard Biener <richard.guenther@gmail.com>
Date: Fri, 2 Dec 2022 15:52:33 +0100
Message-ID: <CAFiYyc1k5CLxd4Rnxz+Jp9VZ2opLYfrEObzHHL=YFrVig2oexg@mail.gmail.com>
Subject: Re: [PATCH] Fix a few incorrect accesses.
To: Andrew MacLeod <amacleod@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Fri, Dec 2, 2022 at 3:13 PM Andrew MacLeod via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> This consists of 3 changes which stronger type checking has indicated
> are non-compliant with the type field.
>
> I doubt they are super important because there has not been a trap
> triggered by them, and they have been in the source base since sometime
> before 2017.  However, we should probably fix them.
>
> I also notice that those are all uses of VOID_TYPE_P, which
> coincidentally does not check if its a type node being checked:
>
>     /* Nonzero if this type is the (possibly qualified) void type.  */
>     #define VOID_TYPE_P(NODE) (TREE_CODE (NODE) == VOID_TYPE)
>
> So I guess it wouldn't trap anyway, just silently never trigger.
>
> Bootstraps on x86_64-pc-linux-gnu with no regressions.  OK for trunk?

LGTM.

> Andrew