From: Richard Biener <richard.guenther@gmail.com>
To: Eric Botcazou <botcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Avoid creating useless debug temporaries
Date: Tue, 25 Apr 2023 17:10:50 +0200 [thread overview]
Message-ID: <CAFiYyc1k8fip63cGNsaj58NKpMCz2fQ_2SXk+5zaG8HCkB4TnA@mail.gmail.com> (raw)
In-Reply-To: <3493207.iIbC2pHGDl@fomalhaut>
On Tue, Apr 25, 2023 at 11:34 AM Eric Botcazou via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Hi,
>
> insert_debug_temp_for_var_def has some strange code whereby it creates debug
> temporaries for SINGLE_RHS (RHS for gimple_assign_single_p) but not for other
> RHS in the same situation.
It indeed looks odd (likewise the GIMPLE_PHI handling should be
covered by is_gimple_reg ()).
> Removing it saves 25% of compilation time at -g -O
> for a pathological testcase I have.
>
> Bootstrapped/regtested on x86-64/Linux, OK for the mainline?
OK.
probably also helps PR109612 and the other similar PR referenced therein.
Thanks,
Richard.
>
> 2023-04-25 Eric Botcazou <ebotcazou@adacore.com>
>
> * tree-ssa.cc (insert_debug_temp_for_var_def): Do not create
> superfluous debug temporaries for single GIMPLE assignments.
>
> --
> Eric Botcazou
next prev parent reply other threads:[~2023-04-25 15:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 9:33 Eric Botcazou
2023-04-25 15:10 ` Richard Biener [this message]
2023-04-25 15:20 ` Jakub Jelinek
2023-04-25 15:35 ` Eric Botcazou
2023-04-25 15:37 ` Jakub Jelinek
2023-04-26 9:31 ` Eric Botcazou
2023-04-26 9:48 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc1k8fip63cGNsaj58NKpMCz2fQ_2SXk+5zaG8HCkB4TnA@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=botcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).