From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by sourceware.org (Postfix) with ESMTPS id 378A63858C50 for ; Tue, 22 Nov 2022 08:24:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 378A63858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x134.google.com with SMTP id be13so22500733lfb.4 for ; Tue, 22 Nov 2022 00:24:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=tS6T4AaIqVjYslzWmxE/aDECcLQeAWJ/9hDp53quoFg=; b=CuhDNZTdnKuaoW5M2jCPpyVAEvqtEy6x5dzz3Mx7WTQm/o6vyXWz8tL28N+etQgVvZ Ukfm3/0OM/BkshvHq0NZPNjou6yUrTzZ23eTkgJO7Rq+ZW0GF+q20ja7KFyt6YuHqGPA UOUbv7zTY/34GGw3khxEtUTNBkc+Q32CgSm0FMPRVhGfhsj45rEu/uVyLc2sGb6UD3o2 6QRVn9U25ZSbRtaxzge4Xanka4WZO3du1mn1C/PtypXqWGMiaAyCvAPjZj9CjFelwxc0 QmYJr38oQKCDGM0WUPeciy0REoQXxN4h4nBl3ao1izDibviO8DCSnj+uQGhlh6GTOIPB Qxcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tS6T4AaIqVjYslzWmxE/aDECcLQeAWJ/9hDp53quoFg=; b=M/dMkPo3WIItWqlp6DQEycioIesaPH28pORMwjRpaq58SRODA2gMgqr/L5OqBd5qEC 3PotPrpltK88SDKpKlc+ZToZl0jjOLu5wESf9w1bw2+VgCrKySlQ5LkeQSKkVZNVjJKb WobWLOIjsk/xurFIO/SNsWtRYp4T8UFbWuhsSryP28EpROox3S37fmVEbSrNKA9vsjDY U3lIqcWXvZ+j6UzotlJ3CMDr93FsBAq2DSaALaagkEWeKMpP6JqGPW4lYetGQPIXbTWp xvXRH5ByESpHfIuw12+uyer1XyKqFZNsW272X242az2kBxwegw6E6MILPbNfD2xb/540 UAug== X-Gm-Message-State: ANoB5pkYGGcUKujWHId07ud41cvNO2gwxNMin2EdH4zNOZ2Le3YTiErg D6C6KOmDk5NaOiStoZsM0fPppCulMCPc52G8wAE= X-Google-Smtp-Source: AA0mqf60f2x4SnhqC/f8QDouglj9KxRtxj83BWJJGTu6h5+PPqbrBK0I+5hjJd94jSi4g1JMc6F5+Tuxw/pTcLa4aPc= X-Received: by 2002:a05:6512:1287:b0:494:aca0:e5e5 with SMTP id u7-20020a056512128700b00494aca0e5e5mr7238726lfs.497.1669105493519; Tue, 22 Nov 2022 00:24:53 -0800 (PST) MIME-Version: 1.0 References: <2eb36356-ffbf-6c8b-2824-08e204280d52@gmail.com> In-Reply-To: <2eb36356-ffbf-6c8b-2824-08e204280d52@gmail.com> From: Richard Biener Date: Tue, 22 Nov 2022 09:24:40 +0100 Message-ID: Subject: Re: [PATCH] Remove legacy VRP (maybe?) To: Jeff Law Cc: Aldy Hernandez , Jakub Jelinek , "MacLeod, Andrew" , gcc-patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Nov 21, 2022 at 5:49 PM Jeff Law wrote: > > > On 11/21/22 09:35, Aldy Hernandez via Gcc-patches wrote: > > I've been playing around with removing the legacy VRP code for the > > next release. It's a layered onion to get this right, but the first > > bit is pretty straightforward and may be useful for this release. > > Basically, it entails removing the old VRP pass itself, along with > > value_range_equiv which have no producers left. The current users of > > value_range_equiv don't put anything in the equivalence bitmaps, so > > they're basically behaving like plain value_range. > > > > I removed as much as possible without having to change any behavior, > > and this is what I came up with. Is this something that would be > > useful for this release? Would it help release managers have less > > unused cruft in the tree? > > > > Neither Andrew nor I have any strong feelings here. We don't foresee > > the legacy code changing at all in the offseason, so we can just > > accumulate these patches in local trees. > > I'd lean towards removal after gcc-13 releases. I think removing the ability to switch to the old implementation easens maintainance so I'd prefer to have this before the gcc-13 release. So please go ahead. Thanks, Richard. > > jeff >