From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by sourceware.org (Postfix) with ESMTPS id 69703385BAC3 for ; Mon, 4 Jul 2022 06:50:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 69703385BAC3 Received: by mail-qk1-x72c.google.com with SMTP id r138so6187745qke.13 for ; Sun, 03 Jul 2022 23:50:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ckvEmkQZ5u9f/PcLpFZFnFNgJvhcPnxd11Xj6v1xtLQ=; b=U/CMnmoMlAPxb5thBBy61GC4UrE03TAQappC5qzbAEDRnfszqFQYRJ2RPitU60IEXK 4RYfLNfYydE6VBrLMVXbuNU+wbmnI3DNngsNrBusUTzlgHoo6pDcM0xza45KSu0/GzHt m10cFpf/y96m+RQtBGwpEVoyRAa6ZEAJq0sY+Dg/JBjDE7QVwg5alPoHIAMk4FhQJ91W YmMj8RQZz/CZrBUCZVWvz09tFWVRiM7LMjjc1EUcutKVuE5jvhRW2y0DQfcluHwv7Dqd D5VupbwnzJhGiYH5NEv9IO++6CUvFv9xUHiwezypM2UPC8xy0SdRTauIt7MUGA8Q14i+ 0FVQ== X-Gm-Message-State: AJIora+FfRDYfSszr/mdmn8gHcNs55l55j174/HkIUBIAoUncsIoVQz2 ijuO1bTTngGRxqOAZrU7sKbPFH0QwQx24JnxX5/Wla6e X-Google-Smtp-Source: AGRyM1vTgnHM0Ah4jpgD2rk96o6uvbvx3ZnEeG2R4pz+eg6N79yv8EG9tsguXbHpADzLNqhCsgZ/+aNegFQFpkI4o2A= X-Received: by 2002:a05:620a:4103:b0:6b1:43c9:467b with SMTP id j3-20020a05620a410300b006b143c9467bmr18559091qko.4.1656917410822; Sun, 03 Jul 2022 23:50:10 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Mon, 4 Jul 2022 08:49:59 +0200 Message-ID: Subject: Re: [PATCH] aarch64: Fix pure/const function attributes for intrinsics To: Andrew Carlotti Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jul 2022 06:50:12 -0000 On Fri, Jul 1, 2022 at 5:59 PM Andrew Carlotti wrote: > > On Fri, Jul 01, 2022 at 08:42:15AM +0200, Richard Biener wrote: > > On Thu, Jun 30, 2022 at 6:04 PM Andrew Carlotti via Gcc-patches > > wrote: > > > diff --git a/gcc/config/aarch64/aarch64-builtins.cc b/gcc/config/aarch64/aarch64-builtins.cc > > > index e0a741ac663188713e21f457affa57217d074783..877f54aab787862794413259cd36ca0fb7bd49c5 100644 > > > --- a/gcc/config/aarch64/aarch64-builtins.cc > > > +++ b/gcc/config/aarch64/aarch64-builtins.cc > > > @@ -1085,9 +1085,9 @@ aarch64_get_attributes (unsigned int f, machine_mode mode) > > > if (!aarch64_modifies_global_state_p (f, mode)) > > > { > > > if (aarch64_reads_global_state_p (f, mode)) > > > - attrs = aarch64_add_attribute ("pure", attrs); > > > - else > > > attrs = aarch64_add_attribute ("const", attrs); > > > + else > > > + attrs = aarch64_add_attribute ("pure", attrs); > > > > that looks backwards. 'pure' allows read of global memory while > > 'const' does not. Is > > aarch64_reads_global_state_p really backwards? > > Oh - the thing that's backwards is my understanding of what "pure" and > "const" mean. Their meanings as GCC function attributes seem to be > approximately the opposite way round to their meanings in general usage. I bet GCCs reading is older ;) Richard.