public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <richard.guenther@gmail.com>
To: Ben Boeckel <ben.boeckel@kitware.com>
Cc: gcc-patches@gcc.gnu.org, Brad King <brad.king@kitware.com>,
	 Roland Illig <roland.illig@gmx.de>
Subject: Re: [PATCH 2/4] libcpp/init: remove unnecessary `struct` keyword
Date: Tue, 14 May 2024 16:22:54 +0200	[thread overview]
Message-ID: <CAFiYyc1p-NA1oGZ1qm6Qy0X2tPho0+e2m+K8oRLNrg=N4WpjrQ@mail.gmail.com> (raw)
In-Reply-To: <20240504150446.473575-3-ben.boeckel@kitware.com>

On Sat, May 4, 2024 at 5:06 PM Ben Boeckel <ben.boeckel@kitware.com> wrote:
>
> The initial P1689 patches were written in 2019 and ended up having code
> move around over time ended up introducing a `struct` keyword to the
> implementation of `cpp_finish`. Remove it to match the rest of the file
> and its declaration in the header.
>
> Fixes: 024f135a1e9 (p1689r5: initial support, 2023-09-01)
>
> Reported-by: Roland Illig <roland.illig@gmx.de>

OK.

Thanks,
Richard.

> libcpp/
>
>         * init.cc (cpp_finish): Remove unnecessary `struct` keyword.
>
> Signed-off-by: Ben Boeckel <ben.boeckel@kitware.com>
> ---
>  libcpp/init.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libcpp/init.cc b/libcpp/init.cc
> index 54fc9236d38..cbd22249b04 100644
> --- a/libcpp/init.cc
> +++ b/libcpp/init.cc
> @@ -862,7 +862,7 @@ read_original_directory (cpp_reader *pfile)
>     Maybe it should also reset state, such that you could call
>     cpp_start_read with a new filename to restart processing.  */
>  void
> -cpp_finish (struct cpp_reader *pfile, FILE *deps_stream, FILE *fdeps_stream)
> +cpp_finish (cpp_reader *pfile, FILE *deps_stream, FILE *fdeps_stream)
>  {
>    /* Warn about unused macros before popping the final buffer.  */
>    if (CPP_OPTION (pfile, warn_unused_macros))
> --
> 2.44.0
>

  reply	other threads:[~2024-05-14 14:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-04 15:04 [PATCH 0/4] P1689 followup fixes Ben Boeckel
2024-05-04 15:04 ` [PATCH 1/4] libcpp/mkdeps: fix indentation Ben Boeckel
2024-05-04 15:04 ` [PATCH 2/4] libcpp/init: remove unnecessary `struct` keyword Ben Boeckel
2024-05-14 14:22   ` Richard Biener [this message]
2024-05-04 15:04 ` [PATCH 3/4] gcc/c-family/c-opts: fix quoting for `-fdeps-format=` error message Ben Boeckel
2024-05-07 21:15   ` Joseph Myers
2024-05-08 11:26     ` Ben Boeckel
2024-05-04 15:04 ` [PATCH 4/4] gcc/c-family/c.opt: clarify `-fdeps-*` flag documentation Ben Boeckel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFiYyc1p-NA1oGZ1qm6Qy0X2tPho0+e2m+K8oRLNrg=N4WpjrQ@mail.gmail.com' \
    --to=richard.guenther@gmail.com \
    --cc=ben.boeckel@kitware.com \
    --cc=brad.king@kitware.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=roland.illig@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).