From: Richard Biener <richard.guenther@gmail.com>
To: Aldy Hernandez <aldyh@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [debug-early] rearrange some checks in gen_subprogram_die
Date: Wed, 01 Oct 2014 14:04:00 -0000 [thread overview]
Message-ID: <CAFiYyc1qFiU1CVjQoJMG3S2GKgwnDmkgy+4w-YxxetkxFNzn8w@mail.gmail.com> (raw)
In-Reply-To: <542AC6EC.8010408@redhat.com>
On Tue, Sep 30, 2014 at 5:06 PM, Aldy Hernandez <aldyh@redhat.com> wrote:
> On 09/30/14 03:23, Richard Biener wrote:
>>
>> On Mon, Sep 29, 2014 at 8:54 PM, Aldy Hernandez <aldyh@redhat.com> wrote:
>>>
>>> I'm rearranging some code in Michael's original patch to minimize the
>>> difference with mainline.
>>>
>>> It seems that the check for DECL_STRUCT_FUNCTION (decl)->gimple_df, was
>>> merely a check to see if we had already set the FDE bits for the decl in
>>> question.
>>
>>
>> Sounds more like a check whether the frontend is finished?
>
>
> Is that the canonical way for checking the FE is finished? Seems kinda odd.
> I'd prefer to check for ->fde, since this is the actual reason the rest of
> dwarf generation will not work in this case.
>
> Either way, I'm not terribly attached to this particular part of the patch.
> If you'd rather me use ->gimple_df, I can use it. It just doesn't seem very
> readable.
No, checking ->gimple_df would be odd indeed. The check seems to be coming from
Michas patch-set?
Richard.
> Aldy
next prev parent reply other threads:[~2014-10-01 14:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 18:54 Aldy Hernandez
2014-09-30 10:23 ` Richard Biener
2014-09-30 15:06 ` Aldy Hernandez
2014-10-01 14:04 ` Richard Biener [this message]
2014-10-01 15:24 ` Aldy Hernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc1qFiU1CVjQoJMG3S2GKgwnDmkgy+4w-YxxetkxFNzn8w@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).