From: Richard Biener <richard.guenther@gmail.com>
To: Andreas Schwab <schwab@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] lto-wrapper: Pass through -funwind-tables and -fasynchronous-unwind-tables
Date: Thu, 9 Feb 2023 09:20:41 +0100 [thread overview]
Message-ID: <CAFiYyc1rsvQ0eEpHOJzU8zDGqci7cVxuop-jOrZxn28cKQdPtg@mail.gmail.com> (raw)
In-Reply-To: <mvmttzyx1b3.fsf@suse.de>
On Mon, Feb 6, 2023 at 4:27 PM Andreas Schwab via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> The -funwind-tables and -fasynchronous-unwind-tables options are relevant
> for the output pass, so they need to be passed through by the LTO wrapper.
> Otherwise, dwarf2out_assembly_start may output a ".cfi_sections
> .debug_frame" directive when debug info was enabled even if every
> translation unit was compiled with -funwind-tables.
OK.
> gcc/
> * lto-wrapper.cc (merge_and_complain): Handle
> -funwind-tables and -fasynchronous-unwind-tables.
> (append_compiler_options): Likewise.
> ---
> gcc/lto-wrapper.cc | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/gcc/lto-wrapper.cc b/gcc/lto-wrapper.cc
> index 11c4d1b38a4..fe8c5f6e80d 100644
> --- a/gcc/lto-wrapper.cc
> +++ b/gcc/lto-wrapper.cc
> @@ -335,6 +335,8 @@ merge_and_complain (vec<cl_decoded_option> &decoded_options,
>
> case OPT_fopenmp:
> case OPT_fopenacc:
> + case OPT_fasynchronous_unwind_tables:
> + case OPT_funwind_tables:
> /* For selected options we can merge conservatively. */
> if (existing_opt == -1)
> decoded_options.safe_push (*foption);
> @@ -737,6 +739,8 @@ append_compiler_options (obstack *argv_obstack, vec<cl_decoded_option> opts)
> case OPT_fopenacc_dim_:
> case OPT_foffload_abi_:
> case OPT_fcf_protection_:
> + case OPT_fasynchronous_unwind_tables:
> + case OPT_funwind_tables:
> case OPT_g:
> case OPT_O:
> case OPT_Ofast:
> --
> 2.39.1
>
>
> --
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."
prev parent reply other threads:[~2023-02-09 8:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 15:26 Andreas Schwab
2023-02-09 8:20 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc1rsvQ0eEpHOJzU8zDGqci7cVxuop-jOrZxn28cKQdPtg@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).