From: Richard Biener <richard.guenther@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Paolo Bonzini <bonzini@gnu.org>,
GCC Patches <gcc-patches@gcc.gnu.org>,
marcandre.lureau@redhat.com, mliska@suse.cz
Subject: Re: [PATCH] Improve dead code elimination with -fsanitize=address (PR84307)
Date: Mon, 12 Feb 2018 08:57:00 -0000 [thread overview]
Message-ID: <CAFiYyc1rxdJNv2-K19f73vrfkgct5g-M3Tqin3R4hvAhjJmK_g@mail.gmail.com> (raw)
In-Reply-To: <51F0785D-7117-447E-9D49-BD76CA47FC45@gmail.com>
On Fri, Feb 9, 2018 at 9:10 PM, Richard Biener
<richard.guenther@gmail.com> wrote:
> On February 9, 2018 7:07:45 PM GMT+01:00, Jakub Jelinek <jakub@redhat.com> wrote:
>>On Fri, Feb 09, 2018 at 07:01:08PM +0100, Richard Biener wrote:
>>> >which indeed fixes the testcase and seems not to break asan.exp.
>>>
>>> Huh. Need to double check why that makes sense ;)
>>
>>I think it does, for both ASAN_CHECK and ASAN_MARK the pointer argument
>>is the second one, the first one is an integer argument with flags.
>>And ASAN_MARK, both poison and unpoison, works kind like a clobber on
>>the
>>referenced variable, before unpoison it is generally inaccessible and
>>after
>>poison too.
>
> Ah, indeed.
Which was an approval as well, in case you want to push this right now.
Richard.
> Richard.
>
>> Jakub
>
next prev parent reply other threads:[~2018-02-12 8:57 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 16:08 Paolo Bonzini
2018-02-09 16:40 ` Richard Biener
2018-02-09 17:23 ` Paolo Bonzini
2018-02-09 18:01 ` Richard Biener
2018-02-09 18:37 ` Jakub Jelinek
2018-02-09 20:10 ` Richard Biener
2018-02-12 8:57 ` Richard Biener [this message]
2018-02-12 12:02 ` Paolo Bonzini
2018-02-12 12:10 ` Jakub Jelinek
2018-02-13 9:33 ` Fallout: PR84340 Martin Liška
2018-02-13 11:16 ` Paolo Bonzini
2018-02-13 13:49 ` Jakub Jelinek
2018-02-13 14:49 ` Jakub Jelinek
2018-02-13 15:22 ` Paolo Bonzini
2018-02-13 16:48 ` Martin Liška
2018-02-16 9:54 ` Martin Liška
2018-02-16 10:49 ` Jakub Jelinek
2018-02-16 10:58 ` Martin Liška
2018-02-16 15:49 ` Jakub Jelinek
2018-02-12 23:41 ` [PATCH] Improve dead code elimination with -fsanitize=address (PR84307) Paolo Bonzini
2018-02-13 11:49 ` Jakub Jelinek
2018-02-13 12:55 ` Paolo Bonzini
2018-02-13 13:49 ` Jakub Jelinek
2018-02-13 14:29 ` Paolo Bonzini
2018-02-09 18:37 ` Jakub Jelinek
2018-02-13 18:49 ` Jakub Jelinek
2018-02-14 21:49 ` [PATCH] Fix up compound literal handling in C FE (PR sanitizer/84307) Jakub Jelinek
2018-02-14 22:03 ` Joseph Myers
2018-02-26 10:01 ` Martin Liška
2018-02-26 10:49 ` Jakub Jelinek
2018-02-26 10:05 ` Martin Liška
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc1rxdJNv2-K19f73vrfkgct5g-M3Tqin3R4hvAhjJmK_g@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=bonzini@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).