From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=KGSS=6T=gmail.com=richard.guenther@sourceware.org>
Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a])
	by sourceware.org (Postfix) with ESMTPS id AF56C3858C5E
	for <gcc-patches@gcc.gnu.org>; Thu, 23 Feb 2023 10:34:25 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AF56C3858C5E
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-pj1-x102a.google.com with SMTP id z20-20020a17090a8b9400b002372d7f823eso8301343pjn.4
        for <gcc-patches@gcc.gnu.org>; Thu, 23 Feb 2023 02:34:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=mToJIGPiVNMrpSOJ7MWaDX+CCMY5MzRkO+Amkl8zlJo=;
        b=NiIRnR7Vfljcbq909AV4J3AsUn6qoR7ooICMN6Wk/2Po0UwJyWXoomWcMPMvigh1Pm
         NSMdvuu6FqIkwCMMkbkyIIV9/n1yCYMf50j3ZKcW92xR3+YJUM8a1lRPKxOA5B27wyAp
         zXXXv/A45qsrDG6I2uSglsixVNDpMRguO/zCjoVlY7WKR1bq7Ci9Ivj+nh7C1LlSN+Jp
         qps/kT5Fyf3cNyVtKOwWCBZsnTqhiO/27tkSFeUgjB9WsCYe7HYU2OEVNVod5UeCMlj3
         VCt08jwLc9oWrMT3sEkff1MOZ6JC6tXae0xpURgG+q3w0gd4MZtuvR2dZFX3OOyKDodz
         cpxw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=mToJIGPiVNMrpSOJ7MWaDX+CCMY5MzRkO+Amkl8zlJo=;
        b=0UGg+HupitMdziX1ReTbvQprR7h9hSYTXQNeZCG1EHHAhdmRR96Rs52fp6hPZppSta
         duXOCBgSksjxNfKidaxW4qoeYsXYStgpUsAXt5TCbYI61koPjPJdeujjkAtiTMhZ5vaA
         M4YWQys/e0jd7D4FWAtMS2dQWW4OvZTEetR+VwUNRNIgJmmbTdP80xMXkfEl7oZciX4i
         9SPubROs+n9miRne9864hTgEv08kEcRMt7BvZgVK4I3yCESOFOnFo6lEYBISPQSmns+/
         k/rwnTi7bgKnyXCX5LnCskNG9IMw5DqsTiwHBPcRi0KOk/6X93palxboRtuEYHdylEbV
         6r9w==
X-Gm-Message-State: AO0yUKXI7eBwQs1A4g60/HZmvfSh5S24Js4wPws1c/TMDl/w2w1RIkY9
	blSOFm5iGFWmWD6GyXuS3BnwBF+c8YioLfeWXKY=
X-Google-Smtp-Source: AK7set9PE85fj9mN9us+mwkeWa2nUq1bIkgOqQ5I7ADBrdwn3q4BaRleUwfUAPjH3CVoZrw9Nnf8Ix9iqm4AvvgA6hs=
X-Received: by 2002:a17:90b:2689:b0:233:bef7:b096 with SMTP id
 pl9-20020a17090b268900b00233bef7b096mr3013782pjb.96.1677148464536; Thu, 23
 Feb 2023 02:34:24 -0800 (PST)
MIME-Version: 1.0
References: <Y/Zf9GkrxxWxG8Eo@tucnak> <D80EF1BA-EEB8-492A-AD61-1308AD55C8E2@gmail.com>
 <Y/cOFKwwDsz+DgAO@tucnak>
In-Reply-To: <Y/cOFKwwDsz+DgAO@tucnak>
From: Richard Biener <richard.guenther@gmail.com>
Date: Thu, 23 Feb 2023 11:33:57 +0100
Message-ID: <CAFiYyc1tYmx5NxeXMNwT1dKy5QjbbB=MfjdoXJkQm7sqy-CKEQ@mail.gmail.com>
Subject: Re: [PATCH] ipa-prop: Fix another case of missing BUILT_IN_UNREACHABLE_TRAP
 handling [PR106258]
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Thu, Feb 23, 2023 at 7:56 AM Jakub Jelinek <jakub@redhat.com> wrote:
>
> On Wed, Feb 22, 2023 at 07:46:46PM +0100, Richard Biener wrote:
> > Ok for stage1
>
> Thanks.  In that case, can we get at least following into GCC 13,
> another spot that handles in IPA just BUILT_IN_UNREACHABLE and
> not BUILT_IN_UNREACHABLE_TRAP?

Sure.

> Bootstrapped/regtested on x86_64-linux and i686-linux.
>
> 2023-02-23  Jakub Jelinek  <jakub@redhat.com>
>
>         PR middle-end/106258
>         * ipa-prop.cc (try_make_edge_direct_virtual_call): Handle
>         BUILT_IN_UNREACHABLE_TRAP like BUILT_IN_UNREACHABLE.
>
> --- gcc/ipa-prop.cc.jj  2023-02-22 20:50:27.422519757 +0100
> +++ gcc/ipa-prop.cc     2023-02-22 20:52:04.904112685 +0100
> @@ -3850,6 +3850,7 @@ try_make_edge_direct_virtual_call (struc
>             {
>               if (!t
>                   || fndecl_built_in_p (t, BUILT_IN_UNREACHABLE)
> +                 || fndecl_built_in_p (t, BUILT_IN_UNREACHABLE_TRAP)
>                   || !possible_polymorphic_call_target_p
>                        (ie, cgraph_node::get (t)))
>                 {
>
>
>         Jakub
>