* Re: [Patch, testsuite, arm] Skip the arch conflict to enable case neon-thumb2-move pass on more targets.
[not found] <4e69e3f5.0624e70a.66f2.3550SMTPIN_ADDED@mx.google.com>
@ 2011-09-09 11:00 ` Richard Guenther
2011-09-09 12:56 ` Richard Earnshaw
0 siblings, 1 reply; 8+ messages in thread
From: Richard Guenther @ 2011-09-09 11:00 UTC (permalink / raw)
To: Terry Guo; +Cc: gcc-patches
On Fri, Sep 9, 2011 at 12:00 PM, Terry Guo <terry.guo@arm.com> wrote:
> Hello,
>
> This patch enables the case pass on targets other than armv7-a by skipping
> the architecture conflict message. Is it OK to trunk?
I don't like these kind of patches. Why do the testcases have -march=armv7-a
enabled in the first place? If they really need it then they shouldn't be
run with another -march and thus instead there should be a
dg-requires-effective-target armv7-a. If they don't really need it
they shouldn't
add it.
Richard.
> BR,
> Terry
>
> 2011-09-09 Terry Guo <terry.guo@arm.com>
>
> * gcc.target/arm/neon-thumb2-move.c: Skip the
> architecture conflict to enable the case pass
> on targets other than armv7-a.
>
> diff --git a/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
> b/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
> index 430a4d5..9cf86dd 100644
> --- a/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
> +++ b/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
> @@ -3,6 +3,7 @@
> /* { dg-require-effective-target arm_thumb2_ok } */
> /* { dg-options "-O2 -mthumb -march=armv7-a" } */
> /* { dg-add-options arm_neon } */
> +/* { dg-prune-output "switch .* conflicts with" } */
>
> #include <arm_neon.h>
> #include <stddef.h>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Patch, testsuite, arm] Skip the arch conflict to enable case neon-thumb2-move pass on more targets.
2011-09-09 11:00 ` [Patch, testsuite, arm] Skip the arch conflict to enable case neon-thumb2-move pass on more targets Richard Guenther
@ 2011-09-09 12:56 ` Richard Earnshaw
2011-09-09 13:49 ` Richard Guenther
0 siblings, 1 reply; 8+ messages in thread
From: Richard Earnshaw @ 2011-09-09 12:56 UTC (permalink / raw)
To: Richard Guenther; +Cc: Terry Guo, gcc-patches
On 09/09/11 11:07, Richard Guenther wrote:
> On Fri, Sep 9, 2011 at 12:00 PM, Terry Guo <terry.guo@arm.com> wrote:
>> Hello,
>>
>> This patch enables the case pass on targets other than armv7-a by skipping
>> the architecture conflict message. Is it OK to trunk?
>
> I don't like these kind of patches. Why do the testcases have -march=armv7-a
> enabled in the first place? If they really need it then they shouldn't be
> run with another -march and thus instead there should be a
> dg-requires-effective-target armv7-a. If they don't really need it
> they shouldn't
> add it.
>
I'm not particularly keen on them either, but with the current structure
of the testsuite framework the only way to test some unusual option
combinations is to force them (we can't test every option set, or even
every CPU supported via multilib testing as it would take ~forever to
run through all the variants). So the only alternative is to force some
tests to run with specific options.
It might be easier if there were a specific part of the testsuite which
was designated to be non-executable, non-multilib. That part would then
be used without all the multilib paraphernalia that leads to these hacks
(and would only ever be run once as well, regardless of the number of
multilibs being tested). But until such time, this patch seems like the
only way forward.
R.
> Richard.
>
>> BR,
>> Terry
>>
>> 2011-09-09 Terry Guo <terry.guo@arm.com>
>>
>> * gcc.target/arm/neon-thumb2-move.c: Skip the
>> architecture conflict to enable the case pass
>> on targets other than armv7-a.
>>
>> diff --git a/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
>> b/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
>> index 430a4d5..9cf86dd 100644
>> --- a/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
>> +++ b/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
>> @@ -3,6 +3,7 @@
>> /* { dg-require-effective-target arm_thumb2_ok } */
>> /* { dg-options "-O2 -mthumb -march=armv7-a" } */
>> /* { dg-add-options arm_neon } */
>> +/* { dg-prune-output "switch .* conflicts with" } */
>>
>> #include <arm_neon.h>
>> #include <stddef.h>
>>
>>
>>
>>
>>
>>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Patch, testsuite, arm] Skip the arch conflict to enable case neon-thumb2-move pass on more targets.
2011-09-09 12:56 ` Richard Earnshaw
@ 2011-09-09 13:49 ` Richard Guenther
2011-09-09 13:59 ` Richard Earnshaw
0 siblings, 1 reply; 8+ messages in thread
From: Richard Guenther @ 2011-09-09 13:49 UTC (permalink / raw)
To: Richard Earnshaw; +Cc: Terry Guo, gcc-patches
On Fri, Sep 9, 2011 at 2:47 PM, Richard Earnshaw <rearnsha@arm.com> wrote:
> On 09/09/11 11:07, Richard Guenther wrote:
>> On Fri, Sep 9, 2011 at 12:00 PM, Terry Guo <terry.guo@arm.com> wrote:
>>> Hello,
>>>
>>> This patch enables the case pass on targets other than armv7-a by skipping
>>> the architecture conflict message. Is it OK to trunk?
>>
>> I don't like these kind of patches. Why do the testcases have -march=armv7-a
>> enabled in the first place? If they really need it then they shouldn't be
>> run with another -march and thus instead there should be a
>> dg-requires-effective-target armv7-a. If they don't really need it
>> they shouldn't
>> add it.
>>
>
> I'm not particularly keen on them either, but with the current structure
> of the testsuite framework the only way to test some unusual option
> combinations is to force them (we can't test every option set, or even
> every CPU supported via multilib testing as it would take ~forever to
> run through all the variants). So the only alternative is to force some
> tests to run with specific options.
>
> It might be easier if there were a specific part of the testsuite which
> was designated to be non-executable, non-multilib. That part would then
> be used without all the multilib paraphernalia that leads to these hacks
> (and would only ever be run once as well, regardless of the number of
> multilibs being tested). But until such time, this patch seems like the
> only way forward.
I suppose you want a torture that excercises different -march/-mtune
combinations then.
But can't you do the pruning somewhere in an .exp file then instead
of sprinkling it all over the tests itself?
Richard.
> R.
>
>> Richard.
>>
>>> BR,
>>> Terry
>>>
>>> 2011-09-09 Terry Guo <terry.guo@arm.com>
>>>
>>> * gcc.target/arm/neon-thumb2-move.c: Skip the
>>> architecture conflict to enable the case pass
>>> on targets other than armv7-a.
>>>
>>> diff --git a/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
>>> b/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
>>> index 430a4d5..9cf86dd 100644
>>> --- a/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
>>> +++ b/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
>>> @@ -3,6 +3,7 @@
>>> /* { dg-require-effective-target arm_thumb2_ok } */
>>> /* { dg-options "-O2 -mthumb -march=armv7-a" } */
>>> /* { dg-add-options arm_neon } */
>>> +/* { dg-prune-output "switch .* conflicts with" } */
>>>
>>> #include <arm_neon.h>
>>> #include <stddef.h>
>>>
>>>
>>>
>>>
>>>
>>>
>>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Patch, testsuite, arm] Skip the arch conflict to enable case neon-thumb2-move pass on more targets.
2011-09-09 13:49 ` Richard Guenther
@ 2011-09-09 13:59 ` Richard Earnshaw
2011-09-20 10:21 ` Terry Guo
[not found] ` <4e785e54.863fd80a.1ff3.ffff8ed5SMTPIN_ADDED@mx.google.com>
0 siblings, 2 replies; 8+ messages in thread
From: Richard Earnshaw @ 2011-09-09 13:59 UTC (permalink / raw)
To: Richard Guenther; +Cc: Terry Guo, gcc-patches
On 9 Sep 2011, at 14:03, "Richard Guenther" <richard.guenther@gmail.com> wrote:
> On Fri, Sep 9, 2011 at 2:47 PM, Richard Earnshaw <rearnsha@arm.com> wrote:
>> On 09/09/11 11:07, Richard Guenther wrote:
>>> On Fri, Sep 9, 2011 at 12:00 PM, Terry Guo <terry.guo@arm.com> wrote:
>>>> Hello,
>>>>
>>>> This patch enables the case pass on targets other than armv7-a by skipping
>>>> the architecture conflict message. Is it OK to trunk?
>>>
>>> I don't like these kind of patches. Why do the testcases have -march=armv7-a
>>> enabled in the first place? If they really need it then they shouldn't be
>>> run with another -march and thus instead there should be a
>>> dg-requires-effective-target armv7-a. If they don't really need it
>>> they shouldn't
>>> add it.
>>>
>>
>> I'm not particularly keen on them either, but with the current structure
>> of the testsuite framework the only way to test some unusual option
>> combinations is to force them (we can't test every option set, or even
>> every CPU supported via multilib testing as it would take ~forever to
>> run through all the variants). So the only alternative is to force some
>> tests to run with specific options.
>>
>> It might be easier if there were a specific part of the testsuite which
>> was designated to be non-executable, non-multilib. That part would then
>> be used without all the multilib paraphernalia that leads to these hacks
>> (and would only ever be run once as well, regardless of the number of
>> multilibs being tested). But until such time, this patch seems like the
>> only way forward.
>
> I suppose you want a torture that excercises different -march/-mtune
> combinations then.
>
> But can't you do the pruning somewhere in an .exp file then instead
> of sprinkling it all over the tests itself?
>
It seems not. At present the multilib options are all added automatically by the dejagnu infrastructure.
R.
> Richard.
>
>> R.
>>
>>> Richard.
>>>
>>>> BR,
>>>> Terry
>>>>
>>>> 2011-09-09 Terry Guo <terry.guo@arm.com>
>>>>
>>>> * gcc.target/arm/neon-thumb2-move.c: Skip the
>>>> architecture conflict to enable the case pass
>>>> on targets other than armv7-a.
>>>>
>>>> diff --git a/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
>>>> b/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
>>>> index 430a4d5..9cf86dd 100644
>>>> --- a/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
>>>> +++ b/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
>>>> @@ -3,6 +3,7 @@
>>>> /* { dg-require-effective-target arm_thumb2_ok } */
>>>> /* { dg-options "-O2 -mthumb -march=armv7-a" } */
>>>> /* { dg-add-options arm_neon } */
>>>> +/* { dg-prune-output "switch .* conflicts with" } */
>>>>
>>>> #include <arm_neon.h>
>>>> #include <stddef.h>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>
>>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [Patch, testsuite, arm] Skip the arch conflict to enable case neon-thumb2-move pass on more targets.
2011-09-09 13:59 ` Richard Earnshaw
@ 2011-09-20 10:21 ` Terry Guo
2011-09-23 9:41 ` Richard Earnshaw
[not found] ` <4e785e54.863fd80a.1ff3.ffff8ed5SMTPIN_ADDED@mx.google.com>
1 sibling, 1 reply; 8+ messages in thread
From: Terry Guo @ 2011-09-20 10:21 UTC (permalink / raw)
To: Richard Earnshaw, Richard Guenther; +Cc: gcc-patches
Hello,
> >
> > I suppose you want a torture that excercises different -march/-mtune
> > combinations then.
> >
> > But can't you do the pruning somewhere in an .exp file then instead
> > of sprinkling it all over the tests itself?
> >
>
> It seems not. At present the multilib options are all added
> automatically by the dejagnu infrastructure.
>
> R.
>
Thanks for both of you and I did tried to address Richard Guenther's
comments but I failed. I couldn't figure out a better way to solve such
cases for the reason like what Richard Earnshaw says. So I will wait for a
while. Can I assume no objection or no better proposal as OK?
BR,
Terry
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Patch, testsuite, arm] Skip the arch conflict to enable case neon-thumb2-move pass on more targets.
2011-09-20 10:21 ` Terry Guo
@ 2011-09-23 9:41 ` Richard Earnshaw
0 siblings, 0 replies; 8+ messages in thread
From: Richard Earnshaw @ 2011-09-23 9:41 UTC (permalink / raw)
To: Terry Guo; +Cc: Richard Guenther, gcc-patches
On 20/09/11 10:35, Terry Guo wrote:
> Hello,
>
>>>
>>> I suppose you want a torture that excercises different -march/-mtune
>>> combinations then.
>>>
>>> But can't you do the pruning somewhere in an .exp file then instead
>>> of sprinkling it all over the tests itself?
>>>
>>
>> It seems not. At present the multilib options are all added
>> automatically by the dejagnu infrastructure.
>>
>> R.
>>
>
> Thanks for both of you and I did tried to address Richard Guenther's
> comments but I failed. I couldn't figure out a better way to solve such
> cases for the reason like what Richard Earnshaw says. So I will wait for a
> while. Can I assume no objection or no better proposal as OK?
>
> BR,
> Terry
>
>
So not withstanding Richi's comment that there ought to be a better way
to do this, I don't think that should prevent this going in. It's using
the same method that many other tests use already.
So OK.
R.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Patch, testsuite, arm] Skip the arch conflict to enable case neon-thumb2-move pass on more targets.
[not found] ` <4e785e54.863fd80a.1ff3.ffff8ed5SMTPIN_ADDED@mx.google.com>
@ 2011-09-24 15:33 ` Richard Guenther
0 siblings, 0 replies; 8+ messages in thread
From: Richard Guenther @ 2011-09-24 15:33 UTC (permalink / raw)
To: Terry Guo; +Cc: Richard Earnshaw, gcc-patches
On Tue, Sep 20, 2011 at 11:35 AM, Terry Guo <terry.guo@arm.com> wrote:
> Hello,
>
>> >
>> > I suppose you want a torture that excercises different -march/-mtune
>> > combinations then.
>> >
>> > But can't you do the pruning somewhere in an .exp file then instead
>> > of sprinkling it all over the tests itself?
>> >
>>
>> It seems not. At present the multilib options are all added
>> automatically by the dejagnu infrastructure.
>>
>> R.
>>
>
> Thanks for both of you and I did tried to address Richard Guenther's
> comments but I failed. I couldn't figure out a better way to solve such
> cases for the reason like what Richard Earnshaw says. So I will wait for a
> while. Can I assume no objection or no better proposal as OK?
Look at how gcc-dg.exp implements dg-prune-output and makes use of it.
You should be able to append a global pruning for these issues in
arm.exp.
Richard.
> BR,
> Terry
>
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Patch, testsuite, arm] Skip the arch conflict to enable case neon-thumb2-move pass on more targets.
@ 2011-09-09 10:12 Terry Guo
0 siblings, 0 replies; 8+ messages in thread
From: Terry Guo @ 2011-09-09 10:12 UTC (permalink / raw)
To: gcc-patches
Hello,
This patch enables the case pass on targets other than armv7-a by skipping
the architecture conflict message. Is it OK to trunk?
BR,
Terry
2011-09-09 Terry Guo <terry.guo@arm.com>
* gcc.target/arm/neon-thumb2-move.c: Skip the
architecture conflict to enable the case pass
on targets other than armv7-a.
diff --git a/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
b/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
index 430a4d5..9cf86dd 100644
--- a/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
+++ b/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c
@@ -3,6 +3,7 @@
/* { dg-require-effective-target arm_thumb2_ok } */
/* { dg-options "-O2 -mthumb -march=armv7-a" } */
/* { dg-add-options arm_neon } */
+/* { dg-prune-output "switch .* conflicts with" } */
#include <arm_neon.h>
#include <stddef.h>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-09-24 11:13 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <4e69e3f5.0624e70a.66f2.3550SMTPIN_ADDED@mx.google.com>
2011-09-09 11:00 ` [Patch, testsuite, arm] Skip the arch conflict to enable case neon-thumb2-move pass on more targets Richard Guenther
2011-09-09 12:56 ` Richard Earnshaw
2011-09-09 13:49 ` Richard Guenther
2011-09-09 13:59 ` Richard Earnshaw
2011-09-20 10:21 ` Terry Guo
2011-09-23 9:41 ` Richard Earnshaw
[not found] ` <4e785e54.863fd80a.1ff3.ffff8ed5SMTPIN_ADDED@mx.google.com>
2011-09-24 15:33 ` Richard Guenther
2011-09-09 10:12 Terry Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).