From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) by sourceware.org (Postfix) with ESMTPS id 21C8C385741A for ; Tue, 24 May 2022 06:44:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 21C8C385741A Received: by mail-qt1-x832.google.com with SMTP id x7so10938157qta.6 for ; Mon, 23 May 2022 23:44:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=B7hMF/Ek1EmYeQzYRITPbQgOCRWafMwObDYvJ0nDxYc=; b=7EozlgkdUCpZ8Y8I9o8dsw22dDoxvT6wps3X9ZKs/6aEZF7h8lWN2VLi2vrYS88DR7 iQO8zpAcySvCJmrGBTWWEmlu8AwKmCWSH+BDuz9tSlxPTGU6A/WakwQlm73X4t9FUsD5 wfLQ6iuSdf5TClRiW8fxRDbMUKJ3ErtM5qxCZYpsori1JDxlQO1OkBwbJTuRjhQB9Wju iejR1FeRz1fPQ9Kb0bqH6oCVVlk81XQbgIDzvegXRRoNFflZcF6HZNQnDNMytcr8f8K9 fnwQJPd03KH9MzYPhvPZ8TuR+QQiaoftdzK8vHQitzPhhYx1HNSxRMwgzXJVFx8zhgrV xPLw== X-Gm-Message-State: AOAM531kukvUpgA1w786SLms9ye3RkTMUehCHJcEe4DYxzLDxjKAX1rv D8esHfEtYm4dTfS0l03dkoitx7WkWs6HIG41Us0= X-Google-Smtp-Source: ABdhPJzIGjFK/nQU0twj9minNc6d5Wr09/iYqXpL5ypSTex7fnESTDRgyYCV/8VVaDdKFG6FEYGf5zxCjgiORpHq6Ek= X-Received: by 2002:a05:622a:64e:b0:2f3:f4a2:f3cb with SMTP id a14-20020a05622a064e00b002f3f4a2f3cbmr19172515qtb.626.1653374676461; Mon, 23 May 2022 23:44:36 -0700 (PDT) MIME-Version: 1.0 References: <20220523192834.3785673-1-dmalcolm@redhat.com> <20220523192834.3785673-10-dmalcolm@redhat.com> In-Reply-To: <20220523192834.3785673-10-dmalcolm@redhat.com> From: Richard Biener Date: Tue, 24 May 2022 08:44:25 +0200 Message-ID: Subject: Re: [PATCH 09/10] tree-vect-slp-patterns.cc: add 'final' and 'override' to vect_pattern::build impls To: David Malcolm Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 May 2022 06:44:38 -0000 On Mon, May 23, 2022 at 9:36 PM David Malcolm via Gcc-patches wrote: > > gcc/ChangeLog: > * tree-vect-slp-patterns.cc: Add "final" and "override" to > vect_pattern::build impls as appropriate. OK. > Signed-off-by: David Malcolm > --- > gcc/tree-vect-slp-patterns.cc | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/gcc/tree-vect-slp-patterns.cc b/gcc/tree-vect-slp-patterns.cc > index a6b0d106d5f..e6a6db8beba 100644 > --- a/gcc/tree-vect-slp-patterns.cc > +++ b/gcc/tree-vect-slp-patterns.cc > @@ -492,7 +492,7 @@ class complex_pattern : public vect_pattern > } > > public: > - void build (vec_info *); > + void build (vec_info *) override; > > static internal_fn > matches (complex_operation_t op, slp_tree_to_load_perm_map_t *, slp_tree *, > @@ -595,7 +595,7 @@ class complex_add_pattern : public complex_pattern > } > > public: > - void build (vec_info *); > + void build (vec_info *) final override; > static internal_fn > matches (complex_operation_t op, slp_tree_to_load_perm_map_t *, > slp_compat_nodes_map_t *, slp_tree *, vec *); > @@ -977,7 +977,7 @@ class complex_mul_pattern : public complex_pattern > } > > public: > - void build (vec_info *); > + void build (vec_info *) final override; > static internal_fn > matches (complex_operation_t op, slp_tree_to_load_perm_map_t *, > slp_compat_nodes_map_t *, slp_tree *, vec *); > @@ -1204,7 +1204,7 @@ class complex_fms_pattern : public complex_pattern > } > > public: > - void build (vec_info *); > + void build (vec_info *) final override; > static internal_fn > matches (complex_operation_t op, slp_tree_to_load_perm_map_t *, > slp_compat_nodes_map_t *, slp_tree *, vec *); > @@ -1380,7 +1380,7 @@ class complex_operations_pattern : public complex_pattern > } > > public: > - void build (vec_info *); > + void build (vec_info *) final override; > static internal_fn > matches (complex_operation_t op, slp_tree_to_load_perm_map_t *, > slp_compat_nodes_map_t *, slp_tree *, vec *); > @@ -1446,7 +1446,7 @@ class addsub_pattern : public vect_pattern > addsub_pattern (slp_tree *node, internal_fn ifn) > : vect_pattern (node, NULL, ifn) {}; > > - void build (vec_info *); > + void build (vec_info *) final override; > > static vect_pattern* > recognize (slp_tree_to_load_perm_map_t *, slp_compat_nodes_map_t *, > -- > 2.26.3 >