From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id A3AC038582B0; Tue, 18 Jul 2023 11:41:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A3AC038582B0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2b6ff1a637bso82811091fa.3; Tue, 18 Jul 2023 04:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689680489; x=1692272489; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ohOFREDsEE/cTHqnTuhqTWnCK9JxqMz36r7ofCqs1DI=; b=JA5NjpVTpDRp50bzwt/ZupDp9yJhjNBLF7DK32z7bJ7+cUxYnJ0XkF1JZvVfc54i5f R2DmscR4zL9rn9nzqbCt39+gcsKx1/D+ce4PprfyoS2YeQDx+BeOOqfeRFPR45WKHzhS 63yf0YeqA5XOzkHrA5yHA0SHXK+fK5aaucemD8NqAsq782dEbX7zrfd8X1LtKYUDEnuh 50gA3n9TA/e2k790s+tncB0Ry10bfvTqiG6Me2HT0TGWSNDp3PnfFAR61p9lE6ubWXGR SIrhSUL5qzdA7uF3l2vYAinYpSFlf2Ml4PY/iVQizWSdlTdiCwok1QWEBNyh0N6YbDZU uJEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689680489; x=1692272489; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ohOFREDsEE/cTHqnTuhqTWnCK9JxqMz36r7ofCqs1DI=; b=eddBx+ci5XS8+xGdvKGXPiFnMAaYQSJ2joMqdAaCO//FLqV++Q1fhQYe15+IM3ERVU HHyX/lODrt61rrpNFT2jp/MtZI91NlKKVxbyrcqfDqGvI2saGjnVLxUOU5NUpG7uIuhQ n2xuqkkvfeG0tVMPumrGyXXNu/9cDwM4kbCXonkU6ciMhNz/ahkySiCqflmvvvGtXkcO iPbHGgqwBAtyEIfJ/Kr3ISIYoNOd1Ri3TToLs8LTZYEhdfn2U36ZX39o6qwI+L0tJDri YjROiEM9D/fBWtX41FveqDjOCxVZo7ZRbo36+abUQdig221rv3Jax3ngwV75sJXWP3O6 B69A== X-Gm-Message-State: ABy/qLbrgWqq37U7G86D9vghq4r85AJcL1zN6kgRP1nDw3X3co8WV3bA Vay09a36mEn5Z/GdahVeDunUP30qSK7tfoKIXA0= X-Google-Smtp-Source: APBJJlFmDaCN7qjB5QUwzJfiB1PAeDoK+eor0hXSEnphatZYDcxTwVAT2AnF71DnrqStEn2Mr7x9WGqRhX3Rxxj2ZLI= X-Received: by 2002:a2e:2c14:0:b0:2b6:efa0:7c36 with SMTP id s20-20020a2e2c14000000b002b6efa07c36mr10129787ljs.21.1689680488915; Tue, 18 Jul 2023 04:41:28 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Tue, 18 Jul 2023 13:41:17 +0200 Message-ID: Subject: Re: [PATCH v2] tree-optimization/110279- Check for nested FMA chains in reassoc To: Tamar Christina Cc: Philipp Tomsich , Jakub Jelinek , "gcc-patches@gcc.gnu.org" , Di Zhao OS , "MacLeod, Andrew" , Richard Sandiford Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jul 17, 2023 at 4:26=E2=80=AFPM Tamar Christina via Gcc-patches wrote: > > I think Andrew is listed as maintainer for tree-ssa, or maybe it's on one= of the Richard's lists? It's on my rather longish list of things to review ... > > -----Original Message----- > > From: Gcc-patches > bounces+tamar.christina=3Darm.com@gcc.gnu.org> On Behalf Of Philipp > > Tomsich > > Sent: Tuesday, July 11, 2023 7:51 AM > > To: Jakub Jelinek > > Cc: gcc-patches@gcc.gnu.org; Di Zhao OS > > > > Subject: Re: [PATCH v2] tree-optimization/110279- Check for nested FMA > > chains in reassoc > > > > Jakub, > > > > it looks like you did a lot of work on reassoc in the past =E2=80=94 co= uld you have a > > quick look and comment? > > > > Thanks, > > Philipp. > > > > > > On Tue, 11 Jul 2023 at 04:59, Di Zhao OS > > wrote: > > > > > > Attached is an updated version of the patch. > > > > > > Based on Philipp's review, some changes: > > > > > > 1. Defined new enum fma_state to describe the state of FMA candidates > > > for a list of operands. (Since the tests seems simple after the > > > change, I didn't add predicates on it.) 2. Changed return type of > > > convert_mult_to_fma_1 and convert_mult_to_fma > > > to tree, to remove the in/out parameter. > > > 3. Added description of return value values of rank_ops_for_fma. > > > > > > --- > > > gcc/ChangeLog: > > > > > > * tree-ssa-math-opts.cc (convert_mult_to_fma_1): Added new > > parameter > > > check_only_p. Changed return type to tree. > > > (struct fma_transformation_info): Moved to header. > > > (class fma_deferring_state): Moved to header. > > > (convert_mult_to_fma): Added new parameter check_only_p. Chan= ged > > > return type to tree. > > > * tree-ssa-math-opts.h (struct fma_transformation_info): Move= d from > > .cc. > > > (class fma_deferring_state): Moved from .cc. > > > (convert_mult_to_fma): Add function decl. > > > * tree-ssa-reassoc.cc (enum fma_state): Defined new enum to d= escribe > > > the state of FMA candidates for a list of operands. > > > (rewrite_expr_tree_parallel): Changed boolean parameter to en= um type. > > > (rank_ops_for_fma): Return enum fma_state. > > > (reassociate_bb): Avoid rewriting to parallel if nested FMAs = are found. > > > > > > Thanks, > > > Di Zhao > > > > > >