From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-408680-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 112774 invoked by alias); 30 Sep 2015 08:08:03 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 112764 invoked by uid 89); 30 Sep 2015 08:08:02 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-yk0-f176.google.com
Received: from mail-yk0-f176.google.com (HELO mail-yk0-f176.google.com) (209.85.160.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 30 Sep 2015 08:08:01 +0000
Received: by ykdz138 with SMTP id z138so31976578ykd.2        for <gcc-patches@gcc.gnu.org>; Wed, 30 Sep 2015 01:07:59 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.129.21.213 with SMTP id 204mr1852173ywv.38.1443600479599; Wed, 30 Sep 2015 01:07:59 -0700 (PDT)
Received: by 10.37.93.136 with HTTP; Wed, 30 Sep 2015 01:07:59 -0700 (PDT)
In-Reply-To: <560AD6A6.4050109@acm.org>
References: <560AD6A6.4050109@acm.org>
Date: Wed, 30 Sep 2015 08:55:00 -0000
Message-ID: <CAFiYyc1vH1nXqtb6C99+rXozyJ5tyV876cLr=NeuB8oC8=3V_g@mail.gmail.com>
Subject: Re: Fold acc_on_device
From: Richard Biener <richard.guenther@gmail.com>
To: Nathan Sidwell <nathan@acm.org>
Cc: Bernd Schmidt <bschmidt@redhat.com>, GCC Patches <gcc-patches@gcc.gnu.org>, 	Jakub Jelinek <jakub@redhat.com>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-09/txt/msg02305.txt.bz2

On Tue, Sep 29, 2015 at 8:21 PM, Nathan Sidwell <nathan@acm.org> wrote:
> This patch folds acc_on_device as a regular builtin, but postponed until we
> know which compiler we're in.  As suggested by Bernd, we use the existing
> builtin folding machinery.
>
> Trunk is still using  the older PTX runtime scheme (Thomas is working on
> that), so the only change there is in the  host-side libgomp piece.
>
> Ok for trunk?

Please don't add any new GENERIC based builtin folders.  Instead add to
gimple-fold.c:gimple_fold_builtin

Otherwise you're just generating more work for us who move foldings from
builtins.c to gimple-fold.c.

Thanks,
Richard.

> nathan