From: Richard Biener <richard.guenther@gmail.com>
To: Olivier Hainque <hainque@adacore.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] undef offsetof before defining it in stddef.h
Date: Thu, 6 Oct 2022 14:17:31 +0200 [thread overview]
Message-ID: <CAFiYyc1vXQhSS7z87z6uxpYCUhL6ETgnmoLQevMmjLk2YufZ-Q@mail.gmail.com> (raw)
In-Reply-To: <3AFBDBC2-8140-4068-A595-8B1ED5C3CE4A@adacore.com>
On Fri, Sep 30, 2022 at 6:35 PM Olivier Hainque via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Hello,
>
> The attached patch is a proposal to #undef offsetof before
> the #define we do in ginclude/stddef.h, which prevents redefinition
> warnings from dg tests passing -Wsystem-headers on systems which
> provide a definition in system headers, such as VxWorks.
>
> We have been using this for a while with gcc-11 based toolchains
> for a wide range of configurations (linux and windows hosts, native
> and cross, bare board or VxWorks for a range of CPUs).
>
> This also passes build + sanity test with gcc-12 for
> powerpc64-vxworks7r2, then full bootstrap + regression testing
> for mainline on x86_64-linux.
>
> Ok to commit?
OK.
> Thanks in advance!
>
> With Kind Regards,
>
> Olivier
>
> 2022-09-30 Olivier Hainque <hainque@adacore.com>
>
> gcc/
> * ginclude/stddef.h: #undef offsetof before #define.
>
>
>
>
next prev parent reply other threads:[~2022-10-06 12:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 16:35 Olivier Hainque
2022-10-06 12:17 ` Richard Biener [this message]
2022-10-06 16:49 ` Olivier Hainque
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc1vXQhSS7z87z6uxpYCUhL6ETgnmoLQevMmjLk2YufZ-Q@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hainque@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).