From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 01A47383FBAF for ; Thu, 6 Oct 2022 12:17:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 01A47383FBAF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x636.google.com with SMTP id nb11so4158553ejc.5 for ; Thu, 06 Oct 2022 05:17:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=VgoWmxVS4BExuHYgI0K8IqQtfztzsQkgMBW7B43Rudc=; b=LUdGjX3ajUQoH/7wWixtmE4kLnB0EkkrDgz+3TueO3rttz3ppAvbacLf2yeUdhUF6g YpU7SHHHBRJKWyeOpkDyjmeZSo2jirlsbw7YwfB+cW+DQTffeu83NJ8cSA6WFIjcevTh PnSQw+ETUrp0uZ/NcoxIrOkAfGDdbJMUsjairKZ01PG6Z+wgsJapwT9q+WRCAtLev8us 9tF7W76bX9EzavQXLmCGHDCBONf1+oCWKUuB8EWGYHRZZ4xM81OBQSkDNumsUAohFDlo oxAq8qysi9IGKmXMhMWZLteKfy5GkaKozfncwEYI/nEQExKAG0e3EccvVm9GgMkszsqJ H/JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=VgoWmxVS4BExuHYgI0K8IqQtfztzsQkgMBW7B43Rudc=; b=WD2169QZeTx5fw0grKXNPjN/Z7W5PO+u0mdiuZld6qipBY1prga2swGGfY0mL8Jtku ceGS97OlGWgM6d48AIs/FlmQ2q2N7llsMms2A/+8iGpvlFcbWj9VXOC//y7GmeX6dr8q OtHm6849Kz++qYEFFsK+lSOAbByG1AeAGLaRQkP8S+wcL2RaFeNLwdcMbnUv8czpIbFU X7mZpi/3HvT7lVNpR8bHy+Cf7vJZwRVmAvdqBWI3u3BPTFhU8qesHCovUF7geJigslFT h+zQRZ4QDgI58Ud6usMboPL3sPv+lWDEGQVEPO3F2neNCTLoL+7b1IEyOKwLUzsNICFJ isuQ== X-Gm-Message-State: ACrzQf0uh3HC1G/mpkgkONZb0r00ioN7+CzooHnTXj+uAszlJW9/lvsE XyLP53cMOwL8cp0ZYbg9iRzo5vBfXtejrDXMJyY= X-Google-Smtp-Source: AMsMyM7kUcaf84qvndNpa4LTZbo9Q3Wv4gxsA6ZBJG4IqcxKT+JcgMFrIDiCzm7My7KLQY6d6/HeYPX84iRT353a4CM= X-Received: by 2002:a17:907:9804:b0:78d:1846:953 with SMTP id ji4-20020a170907980400b0078d18460953mr3757145ejc.330.1665058663846; Thu, 06 Oct 2022 05:17:43 -0700 (PDT) MIME-Version: 1.0 References: <3AFBDBC2-8140-4068-A595-8B1ED5C3CE4A@adacore.com> In-Reply-To: <3AFBDBC2-8140-4068-A595-8B1ED5C3CE4A@adacore.com> From: Richard Biener Date: Thu, 6 Oct 2022 14:17:31 +0200 Message-ID: Subject: Re: [PATCH] undef offsetof before defining it in stddef.h To: Olivier Hainque Cc: gcc-patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Sep 30, 2022 at 6:35 PM Olivier Hainque via Gcc-patches wrote: > > Hello, > > The attached patch is a proposal to #undef offsetof before > the #define we do in ginclude/stddef.h, which prevents redefinition > warnings from dg tests passing -Wsystem-headers on systems which > provide a definition in system headers, such as VxWorks. > > We have been using this for a while with gcc-11 based toolchains > for a wide range of configurations (linux and windows hosts, native > and cross, bare board or VxWorks for a range of CPUs). > > This also passes build + sanity test with gcc-12 for > powerpc64-vxworks7r2, then full bootstrap + regression testing > for mainline on x86_64-linux. > > Ok to commit? OK. > Thanks in advance! > > With Kind Regards, > > Olivier > > 2022-09-30 Olivier Hainque > > gcc/ > * ginclude/stddef.h: #undef offsetof before #define. > > > >