public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] Remove a redundant statement in predict.c
@ 2014-08-07 23:59 Yi Yang
  2014-08-08  8:53 ` Richard Biener
  0 siblings, 1 reply; 2+ messages in thread
From: Yi Yang @ 2014-08-07 23:59 UTC (permalink / raw)
  To: GCC Patches

Remove a redundant assignment "*predictor = PRED_BUILTIN_EXPECT;",
since six lines later *predictor is assigned again.

--

2014-08-07  Yi Yang  <ahyangyi@google.com>

gcc:
    * predict.c (expr_expected_value_1): Remove the redundant assignment.

diff --git gcc/predict.c gcc/predict.c
index 835c618..869fc5d 100644
--- gcc/predict.c
+++ gcc/predict.c
@@ -1858,7 +1858,6 @@ expr_expected_value_1 (tree type, tree op0, enum
tree_code code,
      return val;
    if (predictor)
      {
-       *predictor = PRED_BUILTIN_EXPECT;
        tree val2 = gimple_call_arg (def, 2);
        gcc_assert (TREE_CODE (val2) == INTEGER_CST
    && tree_fits_uhwi_p (val2)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Remove a redundant statement in predict.c
  2014-08-07 23:59 [PATCH] Remove a redundant statement in predict.c Yi Yang
@ 2014-08-08  8:53 ` Richard Biener
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2014-08-08  8:53 UTC (permalink / raw)
  To: Yi Yang; +Cc: GCC Patches

On Fri, Aug 8, 2014 at 1:59 AM, Yi Yang <ahyangyi@google.com> wrote:
> Remove a redundant assignment "*predictor = PRED_BUILTIN_EXPECT;",
> since six lines later *predictor is assigned again.

Ok.

Thanks,
Richard.

> --
>
> 2014-08-07  Yi Yang  <ahyangyi@google.com>
>
> gcc:
>     * predict.c (expr_expected_value_1): Remove the redundant assignment.
>
> diff --git gcc/predict.c gcc/predict.c
> index 835c618..869fc5d 100644
> --- gcc/predict.c
> +++ gcc/predict.c
> @@ -1858,7 +1858,6 @@ expr_expected_value_1 (tree type, tree op0, enum
> tree_code code,
>       return val;
>     if (predictor)
>       {
> -       *predictor = PRED_BUILTIN_EXPECT;
>         tree val2 = gimple_call_arg (def, 2);
>         gcc_assert (TREE_CODE (val2) == INTEGER_CST
>     && tree_fits_uhwi_p (val2)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-08-08  8:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-07 23:59 [PATCH] Remove a redundant statement in predict.c Yi Yang
2014-08-08  8:53 ` Richard Biener

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).