From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by sourceware.org (Postfix) with ESMTPS id 8AF783858C74 for ; Thu, 13 Jul 2023 10:38:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8AF783858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4fb77f21c63so987376e87.2 for ; Thu, 13 Jul 2023 03:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689244678; x=1691836678; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YCAqX/XqLgbYkFEK7yBY87FZe7tj8e8fyJE4De90Wwo=; b=m1/FV5bLZqyL0ojqhZHHFKK9LHnmBsO/9/gpJ/UkNTouKKLZ9RIyYNEdMDFgKMjgIe czWc7z4/62SXl9bSni3pFfnCxRA8YbIQFujSc6ai2kfXnS/Lku9rAqJiu94o0VrKsi2s c/x5bADO9Mr9+QRoUCjev4T8IEPTrDP91A3wGqeZBmDPXt8uGO1fkeVq1dRlnugOxjjm WMCNJ0+plhi1UeROpAqqZoRN1xw+3vRryQEjUOrAwIHSndgcPrjkZhaQ5xHQINmYJ5fZ uvK8myNySwEZ7B7bR48XNwzLKegB4DrC9tVq9B2z412Pt0oKSUHnXq+x1fStSUzAsqZZ gr9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689244678; x=1691836678; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YCAqX/XqLgbYkFEK7yBY87FZe7tj8e8fyJE4De90Wwo=; b=gJs75bVixoTlMT/VsQ70/ngJ8YzluTFBZ2gjP6vM76fWGAWGFOVgL/vU3uHTx6ItKB 90S6DAH9NIhysNWTCoDTdFkS4der0Q4f1qrT4MYbzHKh6RhpQN+WNDz7au51ZFLKWWOJ bAlkHkOUJLB73Lin3oLtPDhH44U/dJwJqRWl7WAKpHEGMb/zfyCZwPBVMswh3whFofuJ y5Lswcur6tDFKgj3FbJ0W8lvXn3LF3pssHs/7LXQnOhYd+fPN5NjRTpBVp7G+ygbMhsb x+Hj/xQMqr65nCnpQx32sQD7Ewpd2F+QE7xWwEY45VgupNrVGmm2k2L3nLrMyCND/YSS iuTw== X-Gm-Message-State: ABy/qLYH4ACInNxBt5NdIzkLK7kU/vbRlkjx43XXf4ogfMalBx7pYET4 JCfx1xgLDX+z0oNqHSOnUYgpWsWxPwZXeem1X++Nhbmd X-Google-Smtp-Source: APBJJlHEPqkrXDJi8E3RMSF/PvMLtFYDTHChphbP5iU04W/oWNf6SVM3/+kJv3Y7YCA3kYf+7S0/zAZHugtBY32H4IE= X-Received: by 2002:a2e:81c8:0:b0:2b6:e361:4b3c with SMTP id s8-20020a2e81c8000000b002b6e3614b3cmr1058001ljg.14.1689244677865; Thu, 13 Jul 2023 03:37:57 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Thu, 13 Jul 2023 12:37:32 +0200 Message-ID: Subject: Re: [PATCH] vect: Handle demoting FLOAT and promoting FIX_TRUNC. To: Robin Dapp Cc: gcc-patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Jul 13, 2023 at 12:31=E2=80=AFPM Robin Dapp via Gcc-patches wrote: > > Hi, > > the recent changes that allowed multi-step conversions for > "non-packing/unpacking", i.e. modifier =3D=3D NONE targets included > promoting to-float and demoting to-int variants. This patch > adds demoting to-float and promoting to-int handling. Can you add testcases? Also the current restriction is because the variants you add are not always correct and I don't see any checks that the intermediate type doesn't lose significant bits? Richard. > Bootstrapped and regtested on x86 and aarch64. > > A question that seems related: Why do we require !flag_trapping_math > for the "NONE" multistep conversion but not for the "NARROW_DST" > case when both seem to handle float -> int and there are float > values that do not have an int representation? If a backend > can guarantee that the conversion traps, should it just implement > a multistep conversion in a matching expander? > > Regards > Robin > > > gcc/ChangeLog: > > * tree-vect-stmts.cc (vectorizable_conversion): Handle > more demotion/promotion for modifier =3D=3D NONE. > --- > gcc/tree-vect-stmts.cc | 40 +++++++++++++++++++++++++++++----------- > 1 file changed, 29 insertions(+), 11 deletions(-) > > diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc > index 10e71178ce7..78e0510be7e 100644 > --- a/gcc/tree-vect-stmts.cc > +++ b/gcc/tree-vect-stmts.cc > @@ -5324,28 +5324,46 @@ vectorizable_conversion (vec_info *vinfo, > break; > } > > - /* For conversions between float and smaller integer types try whe= ther we > - can use intermediate signed integer types to support the > + /* For conversions between float and larger integer types try whet= her > + we can use intermediate signed integer types to support the > conversion. */ > if ((code =3D=3D FLOAT_EXPR > - && GET_MODE_SIZE (lhs_mode) > GET_MODE_SIZE (rhs_mode)) > + && GET_MODE_SIZE (lhs_mode) !=3D GET_MODE_SIZE (rhs_mode)) > || (code =3D=3D FIX_TRUNC_EXPR > - && GET_MODE_SIZE (rhs_mode) > GET_MODE_SIZE (lhs_mode) > - && !flag_trapping_math)) > + && ((GET_MODE_SIZE (rhs_mode) > GET_MODE_SIZE (lhs_mode) > + && !flag_trapping_math) > + || GET_MODE_SIZE (rhs_mode) < GET_MODE_SIZE (lhs_mode))= )) > { > + bool demotion =3D GET_MODE_SIZE (rhs_mode) > GET_MODE_SIZE (lhs= _mode); > bool float_expr_p =3D code =3D=3D FLOAT_EXPR; > - scalar_mode imode =3D float_expr_p ? rhs_mode : lhs_mode; > - fltsz =3D GET_MODE_SIZE (float_expr_p ? lhs_mode : rhs_mode); > + unsigned short target_size; > + scalar_mode intermediate_mode; > + if (demotion) > + { > + intermediate_mode =3D lhs_mode; > + target_size =3D GET_MODE_SIZE (rhs_mode); > + } > + else > + { > + target_size =3D GET_MODE_SIZE (lhs_mode); > + tree itype > + =3D build_nonstandard_integer_type (GET_MODE_BITSIZE > + (rhs_mode), 0); > + intermediate_mode =3D SCALAR_TYPE_MODE (itype); > + } > code1 =3D float_expr_p ? code : NOP_EXPR; > codecvt1 =3D float_expr_p ? NOP_EXPR : code; > - FOR_EACH_2XWIDER_MODE (rhs_mode_iter, imode) > + opt_scalar_mode mode_iter; > + FOR_EACH_2XWIDER_MODE (mode_iter, intermediate_mode) > { > - imode =3D rhs_mode_iter.require (); > - if (GET_MODE_SIZE (imode) > fltsz) > + intermediate_mode =3D mode_iter.require (); > + > + if (GET_MODE_SIZE (intermediate_mode) > target_size) > break; > > cvt_type > - =3D build_nonstandard_integer_type (GET_MODE_BITSIZE (imo= de), > + =3D build_nonstandard_integer_type (GET_MODE_BITSIZE > + (intermediate_mode), > 0); > cvt_type =3D get_vectype_for_scalar_type (vinfo, cvt_type, > slp_node); > -- > 2.41.0 >