From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61767 invoked by alias); 12 Nov 2019 09:45:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 61749 invoked by uid 89); 12 Nov 2019 09:45:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*i:sk:6c6946b, H*f:sk:6c6946b X-HELO: mail-lj1-f194.google.com Received: from mail-lj1-f194.google.com (HELO mail-lj1-f194.google.com) (209.85.208.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Nov 2019 09:44:59 +0000 Received: by mail-lj1-f194.google.com with SMTP id n21so17016073ljg.12 for ; Tue, 12 Nov 2019 01:44:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=VkGaPKKadaxHtli+q7morRVDPSJTPAb+cflLxwfnRrE=; b=Y3un1EN1Uf0kEkVEtH0X/OI48Oil6VEkBwyT782p9Kvftb6Qr+rVTsczXb0jYXRYKn 32eF2bf0GCKAxoi4pZnJoRzlgRcGVPhUVDEhEAmP1XSkHBLL2eRIk/O4cFGjSgucI47c J7C3EZ1hyq5sGbeYQkNUKE0UK4eLBXIXJSp+l4If+RSRMuY51hPRmvDWKku9XCyHLPRH q1YrE3ZPURbIdDSFcslm/kDB89UelYIzTVxuVs60bLfqtBeRmVSJhCuv1BNUul2m/Vi5 AvvZ0MqkM64EuLpZqcenMge0dX5D3h1Fd2vC+gubwxVkgVbTwKddfQ0b77+3M29YHBA0 O9Ug== MIME-Version: 1.0 References: <90868706a74cb5641c5d15430200e50bbd3785e7.1573125297.git.mliska@suse.cz> <6c6946bb-905c-02c8-09a0-07f002beff6c@suse.cz> In-Reply-To: <6c6946bb-905c-02c8-09a0-07f002beff6c@suse.cz> From: Richard Biener Date: Tue, 12 Nov 2019 09:52:00 -0000 Message-ID: Subject: Re: [PATCH 3/7] Apply mechanical replacement (generated patch). To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2019-11/txt/msg00860.txt.bz2 On Tue, Nov 12, 2019 at 10:19 AM Martin Li=C5=A1ka wrote: > > On 11/11/19 3:36 PM, Richard Biener wrote: > > I think I've noticed at least one long line (please double-check): > > > > - if (tree_to_uhwi (t) < (unsigned HOST_WIDE_INT) > > INTEGER_SHARE_LIMIT) > > + if (tree_to_uhwi (t) < (unsigned HOST_WIDE_INT) > > param_integer_share_limit) > > You are right, they were quite some GNU coding style violations. > > I'm sending updated version of the patch where I fixed that. OK. Thanks, Richard. > Martin > > > > > as a followup I notice that the targets *_default_params () functions s= hould > > be merged into the default-options structs they have (did you check the > > defaults are still applied and user-overridable?) >