From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 71D223858D35 for ; Mon, 13 Sep 2021 06:10:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 71D223858D35 Received: by mail-ej1-x62c.google.com with SMTP id qq21so12564888ejb.10 for ; Sun, 12 Sep 2021 23:10:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NCy4XOVtRu/bQwcRXW8SfU3XoX3x9ikiQCkOgjUs4rQ=; b=PRyMsSNlpIa6K3gqz1WvwdJtqBC/mu0Izos01to66PobYMU2CeNoB3y3qGtS9JJnv4 A3XzsEn+7sQA8i8+iENpeo9ldvxPLsWKBEJVq58D+Ozz3DXkFq777dDFMv19uq9ollag OxL6Z9qZUjIhUAnFeWTS54iBNKs81CvUZgYJ5MlgZVWXxz7XA5gQKazkr3U/5snFOiXR eucU2/VVw4hIIsO+q14CcTCJG0X2kwAXCQnmA3ToSlXtgQRMZL2Jp30HhsDxc7rOX0fK uf5D3lCwy9AebeAYEUpTB7TEiPxjV5iVzqImJnWtvmGgZK3yS49Hw6jwl9ZF1odHHFFx 8uLg== X-Gm-Message-State: AOAM532G8ylTamszNBXr4X/ZRqKvmw4e6l++ftf7HYwq9cUnQST2x7KB hodpLgicBsaJibTrB8sYeLIvFz9MstVynz38GJ0= X-Google-Smtp-Source: ABdhPJwyqS3Jw8CNYPYM3Cij6/t1Ty7hurWSZp1dRFi/OaSJxx4dePF4l9GykaIzIUT6JYl3cMNB3HV1NY9b9ANWcBE= X-Received: by 2002:a17:906:ccca:: with SMTP id ot10mr10739719ejb.429.1631513449449; Sun, 12 Sep 2021 23:10:49 -0700 (PDT) MIME-Version: 1.0 References: <20210910125818.334531-1-hongtao.liu@intel.com> <20210910125818.334531-3-hongtao.liu@intel.com> In-Reply-To: <20210910125818.334531-3-hongtao.liu@intel.com> From: Richard Biener Date: Mon, 13 Sep 2021 08:10:38 +0200 Message-ID: Subject: Re: [PATCH 2/2] validate_subreg before call gen_lowpart to avoid ICE. To: liuhongt Cc: GCC Patches , Michael Meissner , Segher Boessenkool , Jim Wilson , Andreas Schwab , Andrew Waterman , asolokha@gmx.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Sep 2021 06:10:51 -0000 On Fri, Sep 10, 2021 at 2:58 PM liuhongt wrote: > > gcc/ChangeLog: > > * expmed.c (extract_bit_field_using_extv): validate_subreg > before call gen_lowpart. > --- > gcc/expmed.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/gcc/expmed.c b/gcc/expmed.c > index 3143f38e057..10d62d857a8 100644 > --- a/gcc/expmed.c > +++ b/gcc/expmed.c > @@ -1571,12 +1571,16 @@ extract_bit_field_using_extv (const extraction_insn *extv, rtx op0, > > if (GET_MODE (target) != ext_mode) > { > + machine_mode tmode = GET_MODE (target); > /* Don't use LHS paradoxical subreg if explicit truncation is needed > between the mode of the extraction (word_mode) and the target > mode. Instead, create a temporary and use convert_move to set > the target. */ > if (REG_P (target) > - && TRULY_NOOP_TRUNCATION_MODES_P (GET_MODE (target), ext_mode)) > + && TRULY_NOOP_TRUNCATION_MODES_P (tmode, ext_mode) > + && validate_subreg (ext_mode, tmode, > + target, > + subreg_lowpart_offset (ext_mode, tmode))) > { > target = gen_lowpart (ext_mode, target); That would be equivalent to use gen_lowpart_if_possible? > if (partial_subreg_p (GET_MODE (spec_target), ext_mode)) > -- > 2.27.0 >