From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id 12DF43858C62 for ; Tue, 8 Nov 2022 09:42:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 12DF43858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x534.google.com with SMTP id z18so21557821edb.9 for ; Tue, 08 Nov 2022 01:42:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qm4pGZg34t6H+njJ2jdlYkgKQ4mytWWRv8+Xq7pzXh4=; b=Mou2SUud1wYYkozJJmgmBuIx+DxXrc1nX3vQRpKV5dMoPhVK7op43whSLc17hYqXrE TpoMJLqH1NBjlUdvY6rcoG4Bs7emSmOhOhP8cUfzLxUI+T2eoFQriVVAkzj88b2FMTLV rui2V/iW8ZNx7SNZxTAbdH/OXk78gVXDX1RNu33hlbN+FDBQdvDAPNW1zic9fubaUAE+ nBbb3rN15amBZ6+aLoiKlOo6UlZB78sMCW4PO0DOPxgbw68HXzIF7r/j9Y2Q6YDc3+pU 4J7owhgyAembqf3HoFKu5UGRZRu1En31WVgT2x374Pzm3+yepceudHDn27QVX1K9YEjy L/FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qm4pGZg34t6H+njJ2jdlYkgKQ4mytWWRv8+Xq7pzXh4=; b=nhwykNXnkxE76AIG8Q+PWO1jhptAruuN6isINGYDFLaespIPqaUAcyviDOCIl8cDCz aXw9AJ210N0YTLlTOGqXvQ6YEvCDNEXG6ByzmzL9SZNW3Y/pzvqzkBpN94kTUa7juJU2 1euIJW7dWiGs1z3C/45jBIqyHQjIy8rb8B5Zl5f8zk7AWIzDamlnUMYRP94ZPvMnLJlP Mp3JuuAoKwjPdygUbCEd39JyBsc98awhvN4LNqQ95l09UI0XJovW4x0mVWHFyq1D598K XAOp9h1AMfDJMHkhRCHTB49D4Qt/3BTibpaup0W+g7my6QNS5X+VO+bnWv1L5+3IreFv hMTQ== X-Gm-Message-State: ACrzQf2ikMRA1QG/FWR7NBuJdlLzjTB9VOVOZQQszl8+b3Sk+eNSzibm N2a80nLjHsvXcvn2IvHrS9jM9JkxYPu7BCXXros= X-Google-Smtp-Source: AMsMyM5XGOas2duDNIV/pmJN23EepM1muMODTSUY9/gdBQ5XBEcgE6TVINWD4+sQD7TERM+AAXifc0L5TUvQWQv1lPc= X-Received: by 2002:a05:6402:3457:b0:463:2017:ae64 with SMTP id l23-20020a056402345700b004632017ae64mr51105633edc.218.1667900538705; Tue, 08 Nov 2022 01:42:18 -0800 (PST) MIME-Version: 1.0 References: <20221020165734.1113688-1-hjl.tools@gmail.com> In-Reply-To: From: Richard Biener Date: Tue, 8 Nov 2022 10:42:06 +0100 Message-ID: Subject: Re: [PATCH v2] Always use TYPE_MODE instead of DECL_MODE for vector field To: "H.J. Lu" Cc: Jakub Jelinek , GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Nov 7, 2022 at 9:07 PM H.J. Lu wrote: > > On Mon, Oct 24, 2022 at 11:28 PM Richard Biener > wrote: > > > > On Mon, Oct 24, 2022 at 10:02 PM H.J. Lu wrote: > > > > > > On Mon, Oct 24, 2022 at 12:12 AM Richard Biener > > > wrote: > > > > > > > > On Fri, Oct 21, 2022 at 6:18 PM H.J. Lu wrote: > > > > > > > > > > On Fri, Oct 21, 2022 at 2:33 AM Richard Biener > > > > > wrote: > > > > > > > > > > > > On Thu, Oct 20, 2022 at 6:58 PM H.J. Lu via Gcc-patches > > > > > > wrote: > > > > > > > > > > > > > > commit e034c5c895722e0092d2239cd8c2991db77d6d39 > > > > > > > Author: Jakub Jelinek > > > > > > > Date: Sat Dec 2 08:54:47 2017 +0100 > > > > > > > > > > > > > > PR target/78643 > > > > > > > PR target/80583 > > > > > > > * expr.c (get_inner_reference): If DECL_MODE of a non-bitfield > > > > > > > is BLKmode for vector field with vector raw mode, use TYPE_MODE > > > > > > > instead of DECL_MODE. > > > > > > > > > > > > > > fixed the case where DECL_MODE of a vector field is BLKmode and its > > > > > > > TYPE_MODE is a vector mode because of target attribute. Remove the > > > > > > > BLKmode check for the case where DECL_MODE of a vector field is a vector > > > > > > > mode and its TYPE_MODE is BLKmode because of target attribute. > > > > > > > > > > > > > > gcc/ > > > > > > > > > > > > > > PR target/107304 > > > > > > > * expr.c (get_inner_reference): Always use TYPE_MODE for vector > > > > > > > field with vector raw mode. > > > > > > > > > > > > > > gcc/testsuite/ > > > > > > > > > > > > > > PR target/107304 > > > > > > > * gcc.target/i386/pr107304.c: New test. > > > > > > > --- > > > > > > > gcc/expr.cc | 3 +- > > > > > > > gcc/testsuite/gcc.target/i386/pr107304.c | 39 ++++++++++++++++++++++++ > > > > > > > 2 files changed, 40 insertions(+), 2 deletions(-) > > > > > > > create mode 100644 gcc/testsuite/gcc.target/i386/pr107304.c > > > > > > > > > > > > > > diff --git a/gcc/expr.cc b/gcc/expr.cc > > > > > > > index efe387e6173..9145193c2c1 100644 > > > > > > > --- a/gcc/expr.cc > > > > > > > +++ b/gcc/expr.cc > > > > > > > @@ -7905,8 +7905,7 @@ get_inner_reference (tree exp, poly_int64_pod *pbitsize, > > > > > > > /* For vector fields re-check the target flags, as DECL_MODE > > > > > > > could have been set with different target flags than > > > > > > > the current function has. */ > > > > > > > - if (mode == BLKmode > > > > > > > - && VECTOR_TYPE_P (TREE_TYPE (field)) > > > > > > > + if (VECTOR_TYPE_P (TREE_TYPE (field)) > > > > > > > && VECTOR_MODE_P (TYPE_MODE_RAW (TREE_TYPE (field)))) > > > > > > > > > > > > Isn't the check on TYPE_MODE_RAW also wrong then? Btw, the mode could > > > > > > > > > > TYPE_MODE_RAW is always set to a vector mode for a vector type: > > > > > > > > > > /* Find an appropriate mode for the vector type. */ > > > > > if (TYPE_MODE (type) == VOIDmode) > > > > > SET_TYPE_MODE (type, > > > > > mode_for_vector (SCALAR_TYPE_MODE (innertype), > > > > > nunits).else_blk ()); > > > > > > > > But mode_for_vector can return a MODE_INT! > > > > > > You are right. > > > > > > > /* For integers, try mapping it to a same-sized scalar mode. */ > > > > if (GET_MODE_CLASS (innermode) == MODE_INT) > > > > { > > > > poly_uint64 nbits = nunits * GET_MODE_BITSIZE (innermode); > > > > if (int_mode_for_size (nbits, 0).exists (&mode) > > > > && have_regs_of_mode[mode]) > > > > return mode; > > > > > > > > > But TYPE_MODE returns BLKmode if the vector mode is unsupported. > > > > > > > > > > > also be an integer mode. > > > > > > > > > > For a vector field, mode is either BLK mode or the vector mode. Jakub, > > > > > can you comment on it? > > > > > > > > I think that for > > > > > > > > typedef int v2si __attribute__((vector_size(8))); > > > > > > > > struct X { int i; v2si j; }; > > > > > > > > v2si should get DImode with -mno-sse? > > > > > > > > > > Currently GCC generates > > > > > > (insn 31 32 33 (set (subreg:DI (reg:V2SI 105) 0) > > > (reg:DI 84 [ _3 ])) "y2.c":12:11 -1 > > > (nil)) > > > > > > With my patch, v2si gets DImode directly without SUBREG. > > > > > > Here is the v2 patch with the update commit message: > > > > > > Remove the BLKmode check for the case where DECL_MODE > > > of a vector field is a vector mode and its TYPE_MODE isn't a > > > vector mode because of target attribute. > > > > > > OK for master? > > > > OK. > > OK to backport to release branches? Yes > Thanks. > > -- > H.J.