From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65151 invoked by alias); 1 Aug 2018 12:49:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 64294 invoked by uid 89); 1 Aug 2018 12:49:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-lj1-f174.google.com Received: from mail-lj1-f174.google.com (HELO mail-lj1-f174.google.com) (209.85.208.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 01 Aug 2018 12:49:46 +0000 Received: by mail-lj1-f174.google.com with SMTP id u7-v6so16797873lji.3 for ; Wed, 01 Aug 2018 05:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=gIYjlxEidab6AXlgUOQGZ8NWX9B5YOyySr3RwFhYbGs=; b=O05g6qV5UHuu+zIr4CpFCahE+WOv2c7s31LoOr7FqJ5MQalYygEA7at4WMa+PtbXmX uI+1PxMftRYhX90rNPLXWHha/GxXGnzHAKQYSTH9DvJ0D5A4jVTjl0FWGcvEhWfTbJdG hYNr0MjF2HBT2uOZaK04kkw1gdzM5k2GRSnC9Uo+iOhkidYtVOWx1mFV2WsaUh6pRqHx u4ZUEhz+AsBQ9Sk0Bycv2Ic4w9LUeIdCdY1SxNfJQ1wq8k5DwN09zevoGIj37egIIlnw fKfW69/CvYl5XIWlxxox+ObKqKJKxgrIaKmc6o+3gpjKIU19CICPP6nMWRh+lF4BCXYf teSQ== MIME-Version: 1.0 References: <874lghez1a.fsf@arm.com> <87r2jldkdn.fsf@arm.com> In-Reply-To: <87r2jldkdn.fsf@arm.com> From: Richard Biener Date: Wed, 01 Aug 2018 12:49:00 -0000 Message-ID: Subject: Re: [03/11] Remove vect_transform_stmt grouped_store argument To: GCC Patches , richard.sandiford@arm.com Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00068.txt.bz2 On Mon, Jul 30, 2018 at 1:38 PM Richard Sandiford wrote: > > Nothing now uses the grouped_store value passed back by > vect_transform_stmt, so we might as well remove it. OK. > > 2018-07-30 Richard Sandiford > > gcc/ > * tree-vectorizer.h (vect_transform_stmt): Remove grouped_store > argument. > * tree-vect-stmts.c (vect_transform_stmt): Likewise. > * tree-vect-loop.c (vect_transform_loop_stmt): Update call accordingly. > (vect_transform_loop): Likewise. > * tree-vect-slp.c (vect_schedule_slp_instance): Likewise. > > Index: gcc/tree-vectorizer.h > =================================================================== > --- gcc/tree-vectorizer.h 2018-07-30 12:32:19.366596715 +0100 > +++ gcc/tree-vectorizer.h 2018-07-30 12:32:22.718567174 +0100 > @@ -1459,7 +1459,7 @@ extern tree vect_init_vector (stmt_vec_i > gimple_stmt_iterator *); > extern tree vect_get_vec_def_for_stmt_copy (vec_info *, tree); > extern bool vect_transform_stmt (stmt_vec_info, gimple_stmt_iterator *, > - bool *, slp_tree, slp_instance); > + slp_tree, slp_instance); > extern void vect_remove_stores (stmt_vec_info); > extern bool vect_analyze_stmt (stmt_vec_info, bool *, slp_tree, slp_instance, > stmt_vector_for_cost *); > Index: gcc/tree-vect-stmts.c > =================================================================== > --- gcc/tree-vect-stmts.c 2018-07-30 12:32:09.114687014 +0100 > +++ gcc/tree-vect-stmts.c 2018-07-30 12:32:22.718567174 +0100 > @@ -9662,8 +9662,7 @@ vect_analyze_stmt (stmt_vec_info stmt_in > > bool > vect_transform_stmt (stmt_vec_info stmt_info, gimple_stmt_iterator *gsi, > - bool *grouped_store, slp_tree slp_node, > - slp_instance slp_node_instance) > + slp_tree slp_node, slp_instance slp_node_instance) > { > vec_info *vinfo = stmt_info->vinfo; > bool is_store = false; > @@ -9727,7 +9726,6 @@ vect_transform_stmt (stmt_vec_info stmt_ > last store in the chain is reached. Store stmts before the last > one are skipped, and there vec_stmt_info shouldn't be freed > meanwhile. */ > - *grouped_store = true; > stmt_vec_info group_info = DR_GROUP_FIRST_ELEMENT (stmt_info); > if (DR_GROUP_STORE_COUNT (group_info) == DR_GROUP_SIZE (group_info)) > is_store = true; > Index: gcc/tree-vect-loop.c > =================================================================== > --- gcc/tree-vect-loop.c 2018-07-30 12:32:16.190624704 +0100 > +++ gcc/tree-vect-loop.c 2018-07-30 12:32:22.714567210 +0100 > @@ -8243,8 +8243,7 @@ vect_transform_loop_stmt (loop_vec_info > if (dump_enabled_p ()) > dump_printf_loc (MSG_NOTE, vect_location, "transform statement.\n"); > > - bool grouped_store = false; > - if (vect_transform_stmt (stmt_info, gsi, &grouped_store, NULL, NULL)) > + if (vect_transform_stmt (stmt_info, gsi, NULL, NULL)) > *seen_store = stmt_info; > } > > @@ -8425,7 +8424,7 @@ vect_transform_loop (loop_vec_info loop_ > { > if (dump_enabled_p ()) > dump_printf_loc (MSG_NOTE, vect_location, "transform phi.\n"); > - vect_transform_stmt (stmt_info, NULL, NULL, NULL, NULL); > + vect_transform_stmt (stmt_info, NULL, NULL, NULL); > } > } > > Index: gcc/tree-vect-slp.c > =================================================================== > --- gcc/tree-vect-slp.c 2018-07-30 12:32:19.366596715 +0100 > +++ gcc/tree-vect-slp.c 2018-07-30 12:32:22.714567210 +0100 > @@ -3853,7 +3853,6 @@ vect_transform_slp_perm_load (slp_tree n > vect_schedule_slp_instance (slp_tree node, slp_instance instance, > scalar_stmts_to_slp_tree_map_t *bst_map) > { > - bool grouped_store; > gimple_stmt_iterator si; > stmt_vec_info stmt_info; > unsigned int group_size; > @@ -3945,11 +3944,11 @@ vect_schedule_slp_instance (slp_tree nod > vec v1; > unsigned j; > tree tmask = NULL_TREE; > - vect_transform_stmt (stmt_info, &si, &grouped_store, node, instance); > + vect_transform_stmt (stmt_info, &si, node, instance); > v0 = SLP_TREE_VEC_STMTS (node).copy (); > SLP_TREE_VEC_STMTS (node).truncate (0); > gimple_assign_set_rhs_code (stmt, ocode); > - vect_transform_stmt (stmt_info, &si, &grouped_store, node, instance); > + vect_transform_stmt (stmt_info, &si, node, instance); > gimple_assign_set_rhs_code (stmt, code0); > v1 = SLP_TREE_VEC_STMTS (node).copy (); > SLP_TREE_VEC_STMTS (node).truncate (0); > @@ -3994,7 +3993,7 @@ vect_schedule_slp_instance (slp_tree nod > return; > } > } > - vect_transform_stmt (stmt_info, &si, &grouped_store, node, instance); > + vect_transform_stmt (stmt_info, &si, node, instance); > > /* Restore stmt def-types. */ > FOR_EACH_VEC_ELT (SLP_TREE_CHILDREN (node), i, child)