From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by sourceware.org (Postfix) with ESMTPS id 2853B3858D39 for ; Thu, 21 Oct 2021 09:57:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2853B3858D39 Received: by mail-ed1-x52d.google.com with SMTP id y30so1242730edi.0 for ; Thu, 21 Oct 2021 02:57:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Ui7LimeujDFx+d/UB2P4+vzkrWidDZ/tBzCUJhvnt9Y=; b=5HLkMn646cq1Komke45deh9TFMAoex+rxbtBfpkW1e9/vr+7oC7VIW22lIQ1q+5dDF pDv4Dz/02yq1BHajIUunOgsT6DW9hl/yWK34WEwTzuG0XC/eB1tHebLSu6dKA4QpXEB8 f+pR+6BWKPVXkMtaWumgD6FdOYw4xYe0jGJxe6whDQGl2VE5IZH9rvIrwdbIHYvjRcQK DHbnOsq+mhsQpkHU76ZnRZsJ60X5mgQzPvnRApfTqTSrHgE4Y6noyh6HZE15CAJ8JRS0 3v/DOjYsje7cyXDS2NClWLSsBtOarebQshDly8wvGc1khEquO+0n0FVfpKf3y9tzi6f6 XR+w== X-Gm-Message-State: AOAM5337QG0sLqJztpqLdRZ9XoLPSTeICy+9tNlDiCQOtqVPYXtAbPEi ofD4h5eSXEUB93qHXFCCPddlKV8SplNJFy8croc= X-Google-Smtp-Source: ABdhPJwFLzq4c5R/TMOrQ8qt4oDJFywGcFPmeYoSGngD/KOsu4Gu21CaJNgBb9cgnFx2k+P+IffTVzPt5/hoaRbfo+Y= X-Received: by 2002:a17:906:b311:: with SMTP id n17mr5886211ejz.571.1634810258533; Thu, 21 Oct 2021 02:57:38 -0700 (PDT) MIME-Version: 1.0 References: <202e07b3-e8d5-85e2-c0a5-8a40a61d7175@suse.cz> <0ea9882e-8d7c-f6d4-9262-50e2b3ae5e6c@suse.cz> <163c4fd6-5c81-0a4f-5d5a-c2a06c275fa5@suse.cz> <858d6ffd-11c2-474d-11c4-24e8af4ca291@suse.cz> <6a5d130e-2ffe-6dc5-723e-f6cc30cd8618@suse.cz> In-Reply-To: <6a5d130e-2ffe-6dc5-723e-f6cc30cd8618@suse.cz> From: Richard Biener Date: Thu, 21 Oct 2021 11:57:27 +0200 Message-ID: Subject: Re: [PATCH] options: Fix variable tracking option processing. To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2021 09:57:42 -0000 On Wed, Oct 20, 2021 at 10:51 AM Martin Li=C5=A1ka wrote: > > On 10/19/21 12:53, Richard Biener wrote: > > Meh ... :/ > > > > Well, move the target override hook call down (try to shuffle things > > so diagnostics happen after but > > "inits" happen before). > > Not so easy. There are direct usages of the hooks > (influences dwarf2out_as_loc_support and dwarf2out_as_locview_support) > > if (!OPTION_SET_P (dwarf2out_as_loc_support)) > dwarf2out_as_loc_support =3D dwarf2out_default_as_loc_support (); > if (!OPTION_SET_P (dwarf2out_as_locview_support)) > dwarf2out_as_locview_support =3D dwarf2out_default_as_locview_suppor= t (); > > if (!OPTION_SET_P (debug_variable_location_views)) > { > debug_variable_location_views > =3D (flag_var_tracking > && debug_info_level >=3D DINFO_LEVEL_NORMAL > && dwarf_debuginfo_p () > && !dwarf_strict > && dwarf2out_as_loc_support > && dwarf2out_as_locview_support); > } > > and then the warnings depend on debug_variable_location_views. > > I have another attempt which is about moving option detection of debug_no= nbind_markers_p > to finish_options. That works fine, except one needs to mark the option a= s PerFunction. > That's because it depends on 'optimize' and that would trigger: > 'global_options are modified in local context' verification error. That looks like a sensible change anyway - options that depend on options t= hat are per function have to be per function as well. It also depends on flag_selective_scheduling. But note the checks now happen before if (flag_syntax_only) { write_symbols =3D NO_DEBUG; profile_flag =3D 0; } if (flag_gtoggle) { if (debug_info_level =3D=3D DINFO_LEVEL_NONE) { debug_info_level =3D DINFO_LEVEL_NORMAL; if (write_symbols =3D=3D NO_DEBUG) write_symbols =3D PREFERRED_DEBUGGING_TYPE; } else debug_info_level =3D DINFO_LEVEL_NONE; } which previously affected debug_nonbind_markers_p. I think it makes sense to move the above to finish_options as well. I suppose -help doesn't correctly dum= p the -g enabled state for -gtoggle at the moment? Richard. > > What do you think about the patch? > Cheers, > Martin