From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by sourceware.org (Postfix) with ESMTPS id 0693F3858C66 for ; Wed, 26 Jul 2023 08:19:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0693F3858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2b701e41cd3so94084771fa.3 for ; Wed, 26 Jul 2023 01:19:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690359594; x=1690964394; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pjToez/9/8TG7DzsaiRSTAJgtPctYAQFYk1dL22MGfE=; b=K9VjQ420nrqweHRrIHsxPpt3vLySFOXntaCGeRlYRTmo8R3Qk2qCKlQJeK6g3xEH7f BWHEGGFRSkI5Pyl6UYJUpxHOFuUFgnTe667poBkbdhJ9lEdh7ysf5FYDQQgj5kI93jWk JdieyYqKLhjMWatGxMUeoGTvAp1D5Y9X0oa2MvYkVO9L+K2nm3xB/InW9AWs3kffdYHE lM03oUr0JmHOJwxNFobDjJPyDmNxh8VxFjiw+ncJiy4CiUMVkHRmxkDhe9nOjwApmIEJ x8p+kKauD2iQf+bfyZfZ+EOVT/I8DdAr673HLcvW07wcbZD2GjI4JcBbjOTot3Je6cNs 03qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690359594; x=1690964394; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pjToez/9/8TG7DzsaiRSTAJgtPctYAQFYk1dL22MGfE=; b=auC459Yatm7fiO1IbQ/SGmHIXx1zPNyk6NbbKn6WkNMxXO4iRH6bFz48WXiCSKZBIo eClRGgLQJcdIpvL02vei6OevBjcZsUlCX2VL34zTs4EzKHVOWb6+SedFcic15uzZ7a3U 0B+l18+S9fR3rWY34QEB12thOx2nIkp085WREEpar08nGHW3y7s7TFS59cgULReRDxC7 A5b5DlzVPjjbciPjk3D1OwbI5/2NkSr9guj1M1fEYHOXjQpyttpN3Ml0x04fjCGHqlC4 R5o5D+yE4TT7cMyHPc9Y3XwHBo0XGC5WHUAEm0LJYOPYqTPElurOb3GyrbaB4E+RfV67 yfkA== X-Gm-Message-State: ABy/qLZADAfo/gmcGLn1fkduIwxS606DTs6ibJocfDPn7hiJtTfNPvRF Aepzd5IFSP5EweuDWSceYtiDpVhl6YRQFZlmNqA= X-Google-Smtp-Source: APBJJlFsLOt5YZp1NlfAn53wNsCDyxkgKl4vlODHPTvNpfp+1oKw0ifXuGkVM4r7a8T4ZD/88dyi/ZI73K0HlSvFPKI= X-Received: by 2002:a2e:b61b:0:b0:2b7:117:e54 with SMTP id r27-20020a2eb61b000000b002b701170e54mr894796ljn.4.1690359593368; Wed, 26 Jul 2023 01:19:53 -0700 (PDT) MIME-Version: 1.0 References: <20230725190739.37779-1-aldyh@redhat.com> <20230725190739.37779-3-aldyh@redhat.com> In-Reply-To: <20230725190739.37779-3-aldyh@redhat.com> From: Richard Biener Date: Wed, 26 Jul 2023 10:19:07 +0200 Message-ID: Subject: Re: [PATCH] Initialize value in bit_value_unop. To: Aldy Hernandez Cc: GCC patches , Andrew MacLeod Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jul 25, 2023 at 9:08=E2=80=AFPM Aldy Hernandez via Gcc-patches wrote: > > bit_value_binop initializes VAL regardless of the final mask. It even > has a comment to that effect: > > /* Ensure that VAL is initialized (to any value). */ > > However, bit_value_unop, which in theory shares the same API, does not. > This causes range-ops to choke on uninitialized VALs for some inputs to > ABS. > > Instead of fixing the callers, it's cleaner to make bit_value_unop and > bit_value_binop consistent. > > OK for trunk? OK > gcc/ChangeLog: > > * tree-ssa-ccp.cc (bit_value_unop): Initialize val when appropria= te. > --- > gcc/tree-ssa-ccp.cc | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/gcc/tree-ssa-ccp.cc b/gcc/tree-ssa-ccp.cc > index 73fb7c11c64..15e65f16008 100644 > --- a/gcc/tree-ssa-ccp.cc > +++ b/gcc/tree-ssa-ccp.cc > @@ -1359,7 +1359,10 @@ bit_value_unop (enum tree_code code, signop type_s= gn, int type_precision, > case ABS_EXPR: > case ABSU_EXPR: > if (wi::sext (rmask, rtype_precision) =3D=3D -1) > - *mask =3D -1; > + { > + *mask =3D -1; > + *val =3D 0; > + } > else if (wi::neg_p (rmask)) > { > /* Result is either rval or -rval. */ > @@ -1385,6 +1388,7 @@ bit_value_unop (enum tree_code code, signop type_sg= n, int type_precision, > > default: > *mask =3D -1; > + *val =3D 0; > break; > } > } > -- > 2.41.0 >