From: Richard Biener <richard.guenther@gmail.com>
To: Andrew Pinski <apinski@marvell.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Use chain_next on eh_landing_pad_d for GTY (PR middle-end/110510)
Date: Mon, 3 Jul 2023 09:53:35 +0200 [thread overview]
Message-ID: <CAFiYyc2-ZahcG8VHOaFp61HyNBS8yqZ7oAGFctZ4Am7HrcwMXA@mail.gmail.com> (raw)
In-Reply-To: <20230701212840.330022-1-apinski@marvell.com>
On Sat, Jul 1, 2023 at 11:29 PM Andrew Pinski via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> The backtrace in the bug report suggest there is a running out of
> stack during GC collection, because of a long chain of eh_landing_pad_d.
> This might fix that by adding chain_next onto eh_landing_pad_d's GTY marker.
>
> OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions.
OK.
Richard.
> gcc/ChangeLog:
>
> PR middle-end/110510
> * except.h (struct eh_landing_pad_d): Add chain_next GTY.
> ---
> gcc/except.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/except.h b/gcc/except.h
> index 378a9e4cb77..173b0f026db 100644
> --- a/gcc/except.h
> +++ b/gcc/except.h
> @@ -66,7 +66,7 @@ enum eh_region_type
> /* A landing pad for a given exception region. Any transfer of control
> from the EH runtime to the function happens at a landing pad. */
>
> -struct GTY(()) eh_landing_pad_d
> +struct GTY((chain_next("%h.next_lp"))) eh_landing_pad_d
> {
> /* The linked list of all landing pads associated with the region. */
> struct eh_landing_pad_d *next_lp;
> --
> 2.31.1
>
prev parent reply other threads:[~2023-07-03 7:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-01 21:28 Andrew Pinski
2023-07-03 7:53 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc2-ZahcG8VHOaFp61HyNBS8yqZ7oAGFctZ4Am7HrcwMXA@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=apinski@marvell.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).