From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by sourceware.org (Postfix) with ESMTPS id B85A43858D28 for ; Mon, 3 Jul 2023 07:56:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B85A43858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-4fb8574a3a1so6354766e87.1 for ; Mon, 03 Jul 2023 00:56:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688371009; x=1690963009; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Whz/aQlCjbQhygVyHdqFPQxRhsJo1ojdmO5wlbjx0+I=; b=Ek90QMM2BIDynjnTb3bGkEGtDOBHf9pEW36bqDEGbfS3kN0uePyHc4eMdQPFrCf5y/ hy74NRZqNmVyK+8aVW80fD857Sds1M29fk63zUZe/Z5sk2FxDvdJ8tC0TzJB9D0FwIv1 +a1zUJrGaoOf5NfksekgVwRj944nbFzXjIL6gr46MohzeREqE8uvBbSAwOM8FL2421g4 whPvkTZ6BIU2eFCCvy6GHv1hSotuwcsBD0m0BwiLadTAowdF+JhyyvsKZzxOjCZucunk /Kilivs1LJa8kiWFSAKkfbvVkQX3ROifR/U1I9naOIximc91DbFWIoQgrVoe8ps3Kn9u naUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688371009; x=1690963009; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Whz/aQlCjbQhygVyHdqFPQxRhsJo1ojdmO5wlbjx0+I=; b=OXqoWbzco0/TX1E7WJTuuLI2UyhQxa2hgULPqg+5nAcZA6VitqC7kZaNUkw0B99Z61 6h+x47rrK1uPkhDUR1h3Pqr/dfckO4x1Nw7aqamzrdHDO9A3YA9OoM3FeY+e2Gax5U7d O3hzMGWzpdFjnZJ7+yfW03HcOEynwN+YnsJxU8c0zA218cM1kSPdJf7zSye4zRwfkd6i q+n70YKI1CF9PP+XTSb52pXcIH988ybkQ2XSBstJA2bJ1fLwUf5m9m+JC43CgRm8sm08 ZArNHZp18UU/n6sksP4mimW+G3w2NLipnmVN5ftIpba2CyEVb3JXTGMJXaHw3BAznDFZ Qleg== X-Gm-Message-State: ABy/qLYwbAx1AbtjRW0IyF5FhxxwYMKmAXdOwsI81o4UwB2oCUL2lChE MoWUPbXCMqIhxHqJNRDXPJInCH7Y8s28AxOiCeByjtsp X-Google-Smtp-Source: APBJJlEQs83e5IZh7+nQbgFqEyDjAJWTusOXxcT3tQp+6BRT8RsbP21UTdMqs6605gUl500h/U12ZrBjR9YSKVFUZp8= X-Received: by 2002:a2e:90da:0:b0:2b6:d576:a25b with SMTP id o26-20020a2e90da000000b002b6d576a25bmr5077683ljg.28.1688371009299; Mon, 03 Jul 2023 00:56:49 -0700 (PDT) MIME-Version: 1.0 References: <20230701212840.330022-1-apinski@marvell.com> In-Reply-To: <20230701212840.330022-1-apinski@marvell.com> From: Richard Biener Date: Mon, 3 Jul 2023 09:53:35 +0200 Message-ID: Subject: Re: [PATCH] Use chain_next on eh_landing_pad_d for GTY (PR middle-end/110510) To: Andrew Pinski Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Jul 1, 2023 at 11:29=E2=80=AFPM Andrew Pinski via Gcc-patches wrote: > > The backtrace in the bug report suggest there is a running out of > stack during GC collection, because of a long chain of eh_landing_pad_d. > This might fix that by adding chain_next onto eh_landing_pad_d's GTY mark= er. > > OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. OK. Richard. > gcc/ChangeLog: > > PR middle-end/110510 > * except.h (struct eh_landing_pad_d): Add chain_next GTY. > --- > gcc/except.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/except.h b/gcc/except.h > index 378a9e4cb77..173b0f026db 100644 > --- a/gcc/except.h > +++ b/gcc/except.h > @@ -66,7 +66,7 @@ enum eh_region_type > /* A landing pad for a given exception region. Any transfer of control > from the EH runtime to the function happens at a landing pad. */ > > -struct GTY(()) eh_landing_pad_d > +struct GTY((chain_next("%h.next_lp"))) eh_landing_pad_d > { > /* The linked list of all landing pads associated with the region. */ > struct eh_landing_pad_d *next_lp; > -- > 2.31.1 >