From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id 89A113858D33 for ; Mon, 28 Aug 2023 07:04:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 89A113858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2bceca8a41aso42196971fa.0 for ; Mon, 28 Aug 2023 00:04:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693206257; x=1693811057; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MTeoT3cfbu82aTyPgkK3KI9gGISj4WeQHEl+yQAYx40=; b=jsE5NCmjJ97FjuYCMxbJWSKodTL4vl+uI0JTNuY/RCvmFCub6TfRjXLcLlrzrHUmKj Wqe/NgDL6HIv42yUsa3tTI0DBRzyz5ny/HaNJQ9j3vLTNhnXSOJ5yzkzt2/wBvuUGG30 tOPm0v51QA+EqEezrEcYANJz1LxcHlwpbLvxPaZCjfNFsMkARqTivqqz/gHDwtQjYp5m Krdl71yk/H8SH4tJUC7aO3zNgHT1K4fTHim0I98pr9i00ijNtAwd7BSdYa0t+b71ypMS x7GJTsTL2GokoGw3yOOm3iVWyHTvkMIxJvUiQviLqRpwrA4+YKjUJjPugbPHT+k+6Ct6 4nsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693206257; x=1693811057; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MTeoT3cfbu82aTyPgkK3KI9gGISj4WeQHEl+yQAYx40=; b=hN/+uCdPgocOgIiCQkUGGtx7Nj0umpaDtPwIEOl5o4cW917+S+nWdNYkMXVDt4+MpD Iiljg+4WJUZVS0NlOpIfl0kLr4MNKmhiqgxKFEi5oFXOOuQNYazfk5Yqi8TrOTUwTZ9K kB8JGEG6BIbdX4CDkKyRwgH6EPbzjGcu5G0LmE9shaXjWYu6k7OxLstXKNB3l9JCrzgd ZldcHWVYe7nSi7OB5REbbfQzdXdaehoIuU9thT3O2uptn57HldjB5ZRnLt6L9J+ZBK41 co9OtmlwmwpzF4Lbk2PyTzn2fCfCLnyYn2tS2Cj8P1yICNdNx/oC753Ppw9lf5Bnmmtu PfWw== X-Gm-Message-State: AOJu0Yy7CaNArKJDm8vZ9fa8QlYchvkgHHTRy+CvjsB9Cm6Q6mulvmWH KcEfdP87fan/PsMfjU4bKqXGgpj6GpPN54jGIdM= X-Google-Smtp-Source: AGHT+IGJTPkH6TrSTKpxQtsONmaFX2WiELskH92Fpvo6UwB0ZJpXBaG1tbWDcn8/L3kOjEMbSg72cJgDKw4Z8qmBfzA= X-Received: by 2002:a2e:a16b:0:b0:2bc:c490:10cf with SMTP id u11-20020a2ea16b000000b002bcc49010cfmr15879247ljl.18.1693206256534; Mon, 28 Aug 2023 00:04:16 -0700 (PDT) MIME-Version: 1.0 References: <20230828035253.3745942-1-apinski@marvell.com> In-Reply-To: <20230828035253.3745942-1-apinski@marvell.com> From: Richard Biener Date: Mon, 28 Aug 2023 09:02:38 +0200 Message-ID: Subject: Re: [PATCH] MATCH: Remove redundant pattern for `(x | y) & ~x` To: Andrew Pinski Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Aug 28, 2023 at 5:54=E2=80=AFAM Andrew Pinski via Gcc-patches wrote: > > After r14-2885-gb9237226fdc938, this pattern becomes > redundant as we match it using bitwise_inverted_equal_p. > > There is already a testcase (gcc.dg/nand.c) for this pattern > and it still passes after the removal. > > OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. OK. > gcc/ChangeLog: > > PR tree-optimization/111146 > * match.pd (`(x | y) & ~x`, `(x & y) | ~x`): Remove > redundant pattern. > --- > gcc/match.pd | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/gcc/match.pd b/gcc/match.pd > index fa598d5ca2e..0076392c522 100644 > --- a/gcc/match.pd > +++ b/gcc/match.pd > @@ -1556,14 +1556,6 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) > (bit_ior:c (bit_xor:s @0 @1) (bit_not:s (bit_ior:s @0 @1))) > (bit_not (bit_and @0 @1))) > > -/* (x | y) & ~x -> y & ~x */ > -/* (x & y) | ~x -> y | ~x */ > -(for bitop (bit_and bit_ior) > - rbitop (bit_ior bit_and) > - (simplify > - (bitop:c (rbitop:c @0 @1) (bit_not@2 @0)) > - (bitop @1 @2))) > - > /* (x & y) ^ (x | y) -> x ^ y */ > (simplify > (bit_xor:c (bit_and @0 @1) (bit_ior @0 @1)) > -- > 2.31.1 >