public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <richard.guenther@gmail.com>
To: Brendan Shanks <bshanks@codeweavers.com>
Cc: gcc-patches@gcc.gnu.org, prathamesh.kulkarni@linaro.org,
	 patrick@rivosinc.com, jeffreyalaw@gmail.com
Subject: Re: [PATCH] testsuite: Fix bad-mapper-1.C test failures with posix_spawn
Date: Mon, 13 Nov 2023 07:53:34 +0100	[thread overview]
Message-ID: <CAFiYyc21HdJ=yZpAAHFxrzGwwPmYGotHsjyhU=azFWKx5XAxOw@mail.gmail.com> (raw)
In-Reply-To: <20231111231146.31932-1-bshanks@codeweavers.com>

On Sun, Nov 12, 2023 at 12:12 AM Brendan Shanks <bshanks@codeweavers.com> wrote:
>
> bad-mapper-1.C has been failing since the posix_spawn codepath was added
> to libiberty, adjust the check to accept the changed error message.
>
> Patch has been verified on x86_64 Linux.

OK

> gcc/testsuite:
>
>         * g++.dg/modules/bad-mapper-1.C: Also accept posix_spawn.
>
> Signed-off-by: Brendan Shanks <bshanks@codeweavers.com>
> ---
>  gcc/testsuite/g++.dg/modules/bad-mapper-1.C | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/g++.dg/modules/bad-mapper-1.C b/gcc/testsuite/g++.dg/modules/bad-mapper-1.C
> index 4b2312885d8..53e3e1d0c88 100644
> --- a/gcc/testsuite/g++.dg/modules/bad-mapper-1.C
> +++ b/gcc/testsuite/g++.dg/modules/bad-mapper-1.C
> @@ -1,6 +1,6 @@
>  //  { dg-additional-options "-fmodules-ts -fmodule-mapper=|this-will-not-work" }
>  import unique1.bob;
> -// { dg-error "-:failed (exec|CreateProcess).*mapper.* .*this-will-not-work" "" { target { ! { *-*-darwin[89]* *-*-darwin10* } } } 0 }
> +// { dg-error "-:failed (exec|CreateProcess|posix_spawn).*mapper.* .*this-will-not-work" "" { target { ! { *-*-darwin[89]* *-*-darwin10* } } } 0 }
>  // { dg-prune-output "fatal error:" }
>  // { dg-prune-output "failed to read" }
>  // { dg-prune-output "compilation terminated" }
> --
> 2.41.0
>

  reply	other threads:[~2023-11-13  6:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-11 23:11 Brendan Shanks
2023-11-13  6:53 ` Richard Biener [this message]
2023-11-13 18:48   ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFiYyc21HdJ=yZpAAHFxrzGwwPmYGotHsjyhU=azFWKx5XAxOw@mail.gmail.com' \
    --to=richard.guenther@gmail.com \
    --cc=bshanks@codeweavers.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jeffreyalaw@gmail.com \
    --cc=patrick@rivosinc.com \
    --cc=prathamesh.kulkarni@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).