* [PATCH] testsuite: Fix bad-mapper-1.C test failures with posix_spawn
@ 2023-11-11 23:11 Brendan Shanks
2023-11-13 6:53 ` Richard Biener
0 siblings, 1 reply; 3+ messages in thread
From: Brendan Shanks @ 2023-11-11 23:11 UTC (permalink / raw)
To: gcc-patches
Cc: prathamesh.kulkarni, richard.guenther, patrick, jeffreyalaw,
Brendan Shanks
bad-mapper-1.C has been failing since the posix_spawn codepath was added
to libiberty, adjust the check to accept the changed error message.
Patch has been verified on x86_64 Linux.
gcc/testsuite:
* g++.dg/modules/bad-mapper-1.C: Also accept posix_spawn.
Signed-off-by: Brendan Shanks <bshanks@codeweavers.com>
---
gcc/testsuite/g++.dg/modules/bad-mapper-1.C | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/testsuite/g++.dg/modules/bad-mapper-1.C b/gcc/testsuite/g++.dg/modules/bad-mapper-1.C
index 4b2312885d8..53e3e1d0c88 100644
--- a/gcc/testsuite/g++.dg/modules/bad-mapper-1.C
+++ b/gcc/testsuite/g++.dg/modules/bad-mapper-1.C
@@ -1,6 +1,6 @@
// { dg-additional-options "-fmodules-ts -fmodule-mapper=|this-will-not-work" }
import unique1.bob;
-// { dg-error "-:failed (exec|CreateProcess).*mapper.* .*this-will-not-work" "" { target { ! { *-*-darwin[89]* *-*-darwin10* } } } 0 }
+// { dg-error "-:failed (exec|CreateProcess|posix_spawn).*mapper.* .*this-will-not-work" "" { target { ! { *-*-darwin[89]* *-*-darwin10* } } } 0 }
// { dg-prune-output "fatal error:" }
// { dg-prune-output "failed to read" }
// { dg-prune-output "compilation terminated" }
--
2.41.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] testsuite: Fix bad-mapper-1.C test failures with posix_spawn
2023-11-11 23:11 [PATCH] testsuite: Fix bad-mapper-1.C test failures with posix_spawn Brendan Shanks
@ 2023-11-13 6:53 ` Richard Biener
2023-11-13 18:48 ` Jeff Law
0 siblings, 1 reply; 3+ messages in thread
From: Richard Biener @ 2023-11-13 6:53 UTC (permalink / raw)
To: Brendan Shanks; +Cc: gcc-patches, prathamesh.kulkarni, patrick, jeffreyalaw
On Sun, Nov 12, 2023 at 12:12 AM Brendan Shanks <bshanks@codeweavers.com> wrote:
>
> bad-mapper-1.C has been failing since the posix_spawn codepath was added
> to libiberty, adjust the check to accept the changed error message.
>
> Patch has been verified on x86_64 Linux.
OK
> gcc/testsuite:
>
> * g++.dg/modules/bad-mapper-1.C: Also accept posix_spawn.
>
> Signed-off-by: Brendan Shanks <bshanks@codeweavers.com>
> ---
> gcc/testsuite/g++.dg/modules/bad-mapper-1.C | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/g++.dg/modules/bad-mapper-1.C b/gcc/testsuite/g++.dg/modules/bad-mapper-1.C
> index 4b2312885d8..53e3e1d0c88 100644
> --- a/gcc/testsuite/g++.dg/modules/bad-mapper-1.C
> +++ b/gcc/testsuite/g++.dg/modules/bad-mapper-1.C
> @@ -1,6 +1,6 @@
> // { dg-additional-options "-fmodules-ts -fmodule-mapper=|this-will-not-work" }
> import unique1.bob;
> -// { dg-error "-:failed (exec|CreateProcess).*mapper.* .*this-will-not-work" "" { target { ! { *-*-darwin[89]* *-*-darwin10* } } } 0 }
> +// { dg-error "-:failed (exec|CreateProcess|posix_spawn).*mapper.* .*this-will-not-work" "" { target { ! { *-*-darwin[89]* *-*-darwin10* } } } 0 }
> // { dg-prune-output "fatal error:" }
> // { dg-prune-output "failed to read" }
> // { dg-prune-output "compilation terminated" }
> --
> 2.41.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] testsuite: Fix bad-mapper-1.C test failures with posix_spawn
2023-11-13 6:53 ` Richard Biener
@ 2023-11-13 18:48 ` Jeff Law
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Law @ 2023-11-13 18:48 UTC (permalink / raw)
To: Richard Biener, Brendan Shanks; +Cc: gcc-patches, prathamesh.kulkarni, patrick
On 11/12/23 23:53, Richard Biener wrote:
> On Sun, Nov 12, 2023 at 12:12 AM Brendan Shanks <bshanks@codeweavers.com> wrote:
>>
>> bad-mapper-1.C has been failing since the posix_spawn codepath was added
>> to libiberty, adjust the check to accept the changed error message.
>>
>> Patch has been verified on x86_64 Linux.
>
> OK
And pushed to the trunk. I'd also checked it on ppc64le :-)
jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-13 18:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-11 23:11 [PATCH] testsuite: Fix bad-mapper-1.C test failures with posix_spawn Brendan Shanks
2023-11-13 6:53 ` Richard Biener
2023-11-13 18:48 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).