From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by sourceware.org (Postfix) with ESMTPS id 0249F3858412 for ; Wed, 26 Apr 2023 09:44:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0249F3858412 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2a8eb8db083so67723931fa.3 for ; Wed, 26 Apr 2023 02:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682502290; x=1685094290; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IFJisxS2wE6Pg0CrHMynvuQx1kCdYba0CH/qglvafLY=; b=GPDnGGNAdXpRSFt7pAXNzeQEmZDTm545PnT/rz8JfkP5hys2tywgLwsICngc6JBUP3 4lFS+L734St4/UPEyG7DulvGUJ2odtEffu5FkPZS/wFyiiZ8i5SlcNeNNpgOdhgDncPX wxx1GzeN/9j9TqMX85whG3fF4H8JPPFObI71J4llVlSceoxPOlWRSe3lpff4g3+Ac2vW jbwMf7tdg6xN+brOxnFrPLJ3iULXP+ctxpWHT4CiuPyjqCLeR/lOgef6tEZRfyrjzTR5 NW/APDXU3OOm1MSiMVWLvRKXfv1oEXgZvDkk08XL2KKc3bML0WOhRRd/dxOJL4OuS3sn xntw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682502290; x=1685094290; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IFJisxS2wE6Pg0CrHMynvuQx1kCdYba0CH/qglvafLY=; b=d9FfvnrOp0SGkV21dvV1v6dza2r3pRDLraJKZxWUMvNfn4JmzGDqeODs2WFbPdTq6c DoH5BlnHJk4tZJW/Kv5thv4I20qZiLRsGsr1c38NBIUZ7pUqHvjMqwFriiJUz0S20yj9 XpJmn2vuPnImNQbsQp9JWNpokci3pCr8kxw73PlDMTpl0+GY9T1RippEXDB9DTTEiKvj U7cBUzIlT3P0PNbXwLf7Cw8E/6wd+itgtfiplXdX9QDHZjmkA3cCbciJyvmcX6auQAO7 THoGjrGFpyzcI2kUdd9OWWEiOlXqYhl560EgslXnfJsg56uBi5aPsWKdVOepgMCSQzJJ Vz9w== X-Gm-Message-State: AAQBX9eG/ViGG9hg4inyPbbyGudXhd6sBdgEsUjVjShbpuApvXt1/Vbu IimYEMgCj+jPP81J3iRKMcRXJxqXAz8Iwn1Ja12R0RlNOms= X-Google-Smtp-Source: AKy350atsrxD9YfjixPaimCqArCm4AN7tLhjRJSyLcBnB44IGl2/sDGlV4NnD8WUPQ8k1hjTRzln8dlbJBgCpBLA8SU= X-Received: by 2002:a2e:9c58:0:b0:2aa:4519:fa0 with SMTP id t24-20020a2e9c58000000b002aa45190fa0mr3600029ljj.34.1682502290441; Wed, 26 Apr 2023 02:44:50 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Wed, 26 Apr 2023 11:43:22 +0200 Message-ID: Subject: Re: [PATCH] avr: Set param_min_pagesize to 0 [PR105523] To: SenthilKumar.Selvaraj@microchip.com Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Apr 26, 2023 at 11:42=E2=80=AFAM Richard Biener wrote: > > On Wed, Apr 26, 2023 at 11:01=E2=80=AFAM SenthilKumar.Selvaraj--- via > Gcc-patches wrote: > > > > Hi, > > > > This patch fixes PR 105523 by setting param_min_pagesize to 0 for the > > avr target. For this target, zero and offsets from zero are perfectly > > valid addresses, and the default value of param_min_pagesize ends up > > triggering warnings on valid memory accesses. > > I think the proper configuration is to have > DEFAULT_ADDR_SPACE_ZERO_ADDRESS_VALID Err, TARGET_ADDR_SPACE_ZERO_ADDRESS_VALID > defined to something returning true instead. > > Richard. > > > Ok for trunk and backporting to 13 and 12 branches? > > > > Regards > > Senthil > > > > PR target/105523 > > > > gcc/ChangeLog: > > > > * config/avr/avr.cc (avr_option_override): Set > > param_min_pagesize to 0. > > > > gcc/testsuite/ChangeLog: > > > > * gcc.target/avr/pr105523.c: New test. > > > > diff --git a/gcc/config/avr/avr.cc b/gcc/config/avr/avr.cc > > index c193430cf07..3b862f4e4ac 100644 > > --- a/gcc/config/avr/avr.cc > > +++ b/gcc/config/avr/avr.cc > > @@ -56,6 +56,7 @@ > > #include "tree-pass.h" > > #include "print-rtl.h" > > #include "rtl-iter.h" > > +#include "opts.h" > > > > /* This file should be included last. */ > > #include "target-def.h" > > @@ -769,6 +770,9 @@ avr_option_override (void) > > avr_gasisr_prologues =3D 0; > > #endif > > > > + SET_OPTION_IF_UNSET (&global_options, &global_options_set, > > + param_min_pagesize, 0); > > + > > if (!avr_set_core_architecture()) > > return; > > > > diff --git a/gcc/testsuite/gcc.target/avr/pr105523.c b/gcc/testsuite/gc= c.target/avr/pr105523.c > > new file mode 100644 > > index 00000000000..fbbf7bf4422 > > --- /dev/null > > +++ b/gcc/testsuite/gcc.target/avr/pr105523.c > > @@ -0,0 +1,14 @@ > > +/* { dg-do compile } */ > > +/* { dg-options "-Os -Wall" } */ > > + > > +/* Verify no "array subscript 0 is outside array bounds of" is generat= ed > > + for accessing memory addresses in the 0-4096 range. */ > > + > > +typedef __UINT8_TYPE__ uint8_t; > > + > > +#define SREG (*(volatile uint8_t*) (0x3F + __AVR_SFR_OFFSET__ )) > > + > > +void bar (void) > > +{ > > + SREG =3D 0; > > +} > >