From: Richard Biener <richard.guenther@gmail.com>
To: David Malcolm <dmalcolm@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] testsuite: turn down verbosity of "process-message"
Date: Wed, 05 Dec 2018 09:57:00 -0000 [thread overview]
Message-ID: <CAFiYyc228_xCzQuoj6YCdocMUFAXnCNEX1qeaN116t0tuzr3ag@mail.gmail.com> (raw)
In-Reply-To: <1543962259-31963-1-git-send-email-dmalcolm@redhat.com>
On Tue, Dec 4, 2018 at 10:36 PM David Malcolm <dmalcolm@redhat.com> wrote:
>
> When debugging a failing test, I typically invoke DejaGnu at
> verbosity level 2 (via RUNTESTFLAGS="-v -v dg.exp=something"),
> so that DejaGnu prints the command line used to invoke the
> compiler; specifically these two sites:
> target.exp "Invoking the compiler as "
> remote.exp "Executing on $hostname"
> which are both verbosity level 2.
>
> Unfortunately I run into an O(n^2) issue with logging from
> process-message:
>
> verbose "process-message:\n${dg-messages}" 2
>
> where, as each message each processed, it emits the state
> of dg-messages, containing the new message and all messages so far,
> leading to exponentially-increasing output at level 2 as more test
> messages are added.
>
> This patch papers over the problem by moving the
> problematic message to verbosity level 3.
>
> Successfully regrtested on x86_64-pc-linux-gnu.
>
> OK for trunk?
OK
> gcc/testsuite/ChangeLog:
> * lib/gcc-dg.exp (process-message): Change verbosity level of
> "verbose" from 2 to 3.
> (dg-locus): Likewise.
> ---
> gcc/testsuite/lib/gcc-dg.exp | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/testsuite/lib/gcc-dg.exp b/gcc/testsuite/lib/gcc-dg.exp
> index 305dd3c..054d884 100644
> --- a/gcc/testsuite/lib/gcc-dg.exp
> +++ b/gcc/testsuite/lib/gcc-dg.exp
> @@ -1165,7 +1165,7 @@ proc process-message { msgproc msgprefix dgargs } {
> set newentry [lreplace $newentry 2 2 $expmsg]
>
> set dg-messages [lreplace ${dg-messages} end end $newentry]
> - verbose "process-message:\n${dg-messages}" 2
> + verbose "process-message:\n${dg-messages}" 3
> }
>
> # Look for messages that don't have standard prefixes.
> @@ -1199,7 +1199,7 @@ proc dg-locus { args } {
>
> set newentry [lreplace $newentry 2 2 $expmsg]
> set dg-messages [lreplace ${dg-messages} end end $newentry]
> - verbose "process-message:\n${dg-messages}" 2
> + verbose "process-message:\n${dg-messages}" 3
> }
>
> # Handle output from -fopt-info for MSG_OPTIMIZED_LOCATIONS:
> --
> 1.8.5.3
>
prev parent reply other threads:[~2018-12-05 9:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 21:36 David Malcolm
2018-12-05 9:57 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc228_xCzQuoj6YCdocMUFAXnCNEX1qeaN116t0tuzr3ag@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).