From: Richard Biener <richard.guenther@gmail.com>
To: "Maciej W. Rozycki" <macro@embecosm.com>
Cc: Rainer Orth <ro@cebitec.uni-bielefeld.de>,
Mike Stump <mikestump@comcast.net>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 2/3] testsuite: Require 128-bit vectors for bb-slp-pr95839.c
Date: Fri, 7 Jul 2023 08:33:27 +0200 [thread overview]
Message-ID: <CAFiYyc23ujqdOfJ=R5uQL1YycJvxgdiyMuYY=-+J2ppSu7JDvA@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.2307062153310.28892@tpp.orcam.me.uk>
On Thu, Jul 6, 2023 at 11:37 PM Maciej W. Rozycki <macro@embecosm.com> wrote:
>
> The bb-slp-pr95839.c test assumes quad-single float vector support, but
> some targets only support pairs of floats, causing this test to fail
> with such targets. Limit this test to targets that support at least
> 128-bit vectors then, and add a complementing test that can be run with
> targets that have support for 64-bit vectors only. There is no need to
> adjust bb-slp-pr95839-2.c as 128 bits are needed even for the smallest
> vector of doubles, so support is implied by the presence of vectors of
> doubles.
I wonder why you see the testcase FAIL, on x86-64 when doing
typedef float __attribute__((vector_size(32))) v4f32;
v4f32 f(v4f32 a, v4f32 b)
{
/* Check that we vectorize this CTOR without any loads. */
return (v4f32){a[0] + b[0], a[1] + b[1], a[2] + b[2], a[3] + b[3],
a[4] + b[4], a[5] + b[5], a[6] + b[6], a[7] + b[7]};
}
I see we vectorize the add and the "store". We fail to perform
extraction from the incoming vectors (unless you enable AVX),
that's a missed optimization.
So with paired floats I would expect sth similar? Maybe
x86 is saved by kind-of-presence (but disabled) of V8SFmode vectors.
That said, we should handle this better so can you file an
enhancement bugreport for this?
Thanks,
Richard.
> gcc/testsuite/
> * gcc.dg/vect/bb-slp-pr95839.c: Limit to `vect128' targets.
> * gcc.dg/vect/bb-slp-pr95839-v8.c: New test.
> ---
> gcc/testsuite/gcc.dg/vect/bb-slp-pr95839-v8.c | 14 ++++++++++++++
> gcc/testsuite/gcc.dg/vect/bb-slp-pr95839.c | 1 +
> 2 files changed, 15 insertions(+)
>
> gcc-test-bb-slp-pr95839-vect128.diff
> Index: gcc/gcc/testsuite/gcc.dg/vect/bb-slp-pr95839-v8.c
> ===================================================================
> --- /dev/null
> +++ gcc/gcc/testsuite/gcc.dg/vect/bb-slp-pr95839-v8.c
> @@ -0,0 +1,14 @@
> +/* { dg-do compile } */
> +/* { dg-require-effective-target vect_float } */
> +/* { dg-require-effective-target vect64 } */
> +/* { dg-additional-options "-w -Wno-psabi" } */
> +
> +typedef float __attribute__((vector_size(8))) v2f32;
> +
> +v2f32 f(v2f32 a, v2f32 b)
> +{
> + /* Check that we vectorize this CTOR without any loads. */
> + return (v2f32){a[0] + b[0], a[1] + b[1]};
> +}
> +
> +/* { dg-final { scan-tree-dump "optimized: basic block" "slp2" } } */
> Index: gcc/gcc/testsuite/gcc.dg/vect/bb-slp-pr95839.c
> ===================================================================
> --- gcc.orig/gcc/testsuite/gcc.dg/vect/bb-slp-pr95839.c
> +++ gcc/gcc/testsuite/gcc.dg/vect/bb-slp-pr95839.c
> @@ -1,5 +1,6 @@
> /* { dg-do compile } */
> /* { dg-require-effective-target vect_float } */
> +/* { dg-require-effective-target vect128 } */
> /* { dg-additional-options "-w -Wno-psabi" } */
>
> typedef float __attribute__((vector_size(16))) v4f32;
next prev parent reply other threads:[~2023-07-07 6:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 21:35 [PATCH 0/3] testsuite: Exclude vector tests for unsupported targets Maciej W. Rozycki
2023-07-06 21:35 ` [PATCH 1/3] testsuite: Add check for vectors of 128 bits being supported Maciej W. Rozycki
2023-07-07 6:24 ` Richard Biener
2023-07-11 15:00 ` Maciej W. Rozycki
2023-07-06 21:36 ` [PATCH 2/3] testsuite: Require 128-bit vectors for bb-slp-pr95839.c Maciej W. Rozycki
2023-07-07 6:33 ` Richard Biener [this message]
2023-07-11 15:01 ` Maciej W. Rozycki
2023-07-12 7:15 ` Richard Biener
2023-07-19 14:34 ` Maciej W. Rozycki
2023-07-20 7:15 ` Richard Biener
2023-07-20 9:16 ` Maciej W. Rozycki
2023-07-20 12:09 ` Richard Biener
2023-07-20 13:02 ` Maciej W. Rozycki
2023-07-06 21:36 ` [PATCH 3/3] testsuite: Require vectors of doubles for pr97428.c Maciej W. Rozycki
2023-07-07 6:33 ` Richard Biener
2023-07-11 15:01 ` Maciej W. Rozycki
2023-07-12 7:15 ` Richard Biener
2023-07-19 10:29 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc23ujqdOfJ=R5uQL1YycJvxgdiyMuYY=-+J2ppSu7JDvA@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=macro@embecosm.com \
--cc=mikestump@comcast.net \
--cc=ro@cebitec.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).