From: Richard Biener <richard.guenther@gmail.com>
To: Caroline Tice <cmtice@google.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix testcase to not use vtable verification with LTO
Date: Fri, 06 Sep 2019 10:27:00 -0000 [thread overview]
Message-ID: <CAFiYyc253pYpuqMF5MMaMaQ_ZFhyu7XOZckMyizrdbuoz1g2zA@mail.gmail.com> (raw)
In-Reply-To: <CABtf2+TghM2Z66QK58-gwpWFmO1mwn_Jg8Q3moeRpfP_iOAaVw@mail.gmail.com>
On Thu, Sep 5, 2019 at 6:13 PM Caroline Tice via gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Yesterday I submitted a patch that disallows using vtable verfication
> with LTO (they don't work
> properly together), but I missed fixing the flags for one testcase.
> This patch fixes that omission.
>
> Testing: Tescase passes with this change.
>
> Is this ok to commit?
OK.
Richard.
> -- Caroline
> cmtice@google.com
>
> ChangeLog entry (gcc/testsuite/ChangeLog):
>
> 2019-09-05 Caroline Tice <cmtice@google.com>
>
> PR testsuite/91670
> * g++.dg/ubsan/pr59415.C: Disable LTO, since test uses
> -fvtable-verify, and the two options are no longer allowed
> together.
>
> Index: gcc/testsuite/g++.dg/ubsan/pr59415.C
> ===================================================================
> --- gcc/testsuite/g++.dg/ubsan/pr59415.C (revision 275387)
> +++ gcc/testsuite/g++.dg/ubsan/pr59415.C (working copy)
> @@ -1,5 +1,5 @@
> /* { dg-do compile } */
> -/* { dg-options "-fsanitize=null -Wall -fvtable-verify=std" } */
> +/* { dg-options "-fsanitize=null -Wall -fvtable-verify=std -fno-lto" } */
>
> void
> foo (void)
prev parent reply other threads:[~2019-09-06 10:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 16:13 Caroline Tice via gcc-patches
2019-09-06 10:27 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc253pYpuqMF5MMaMaQ_ZFhyu7XOZckMyizrdbuoz1g2zA@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=cmtice@google.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).