* [PATCH] Fix testcase to not use vtable verification with LTO
@ 2019-09-05 16:13 Caroline Tice via gcc-patches
2019-09-06 10:27 ` Richard Biener
0 siblings, 1 reply; 2+ messages in thread
From: Caroline Tice via gcc-patches @ 2019-09-05 16:13 UTC (permalink / raw)
To: GCC Patches
Yesterday I submitted a patch that disallows using vtable verfication
with LTO (they don't work
properly together), but I missed fixing the flags for one testcase.
This patch fixes that omission.
Testing: Tescase passes with this change.
Is this ok to commit?
-- Caroline
cmtice@google.com
ChangeLog entry (gcc/testsuite/ChangeLog):
2019-09-05 Caroline Tice <cmtice@google.com>
PR testsuite/91670
* g++.dg/ubsan/pr59415.C: Disable LTO, since test uses
-fvtable-verify, and the two options are no longer allowed
together.
Index: gcc/testsuite/g++.dg/ubsan/pr59415.C
===================================================================
--- gcc/testsuite/g++.dg/ubsan/pr59415.C (revision 275387)
+++ gcc/testsuite/g++.dg/ubsan/pr59415.C (working copy)
@@ -1,5 +1,5 @@
/* { dg-do compile } */
-/* { dg-options "-fsanitize=null -Wall -fvtable-verify=std" } */
+/* { dg-options "-fsanitize=null -Wall -fvtable-verify=std -fno-lto" } */
void
foo (void)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix testcase to not use vtable verification with LTO
2019-09-05 16:13 [PATCH] Fix testcase to not use vtable verification with LTO Caroline Tice via gcc-patches
@ 2019-09-06 10:27 ` Richard Biener
0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2019-09-06 10:27 UTC (permalink / raw)
To: Caroline Tice; +Cc: GCC Patches
On Thu, Sep 5, 2019 at 6:13 PM Caroline Tice via gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Yesterday I submitted a patch that disallows using vtable verfication
> with LTO (they don't work
> properly together), but I missed fixing the flags for one testcase.
> This patch fixes that omission.
>
> Testing: Tescase passes with this change.
>
> Is this ok to commit?
OK.
Richard.
> -- Caroline
> cmtice@google.com
>
> ChangeLog entry (gcc/testsuite/ChangeLog):
>
> 2019-09-05 Caroline Tice <cmtice@google.com>
>
> PR testsuite/91670
> * g++.dg/ubsan/pr59415.C: Disable LTO, since test uses
> -fvtable-verify, and the two options are no longer allowed
> together.
>
> Index: gcc/testsuite/g++.dg/ubsan/pr59415.C
> ===================================================================
> --- gcc/testsuite/g++.dg/ubsan/pr59415.C (revision 275387)
> +++ gcc/testsuite/g++.dg/ubsan/pr59415.C (working copy)
> @@ -1,5 +1,5 @@
> /* { dg-do compile } */
> -/* { dg-options "-fsanitize=null -Wall -fvtable-verify=std" } */
> +/* { dg-options "-fsanitize=null -Wall -fvtable-verify=std -fno-lto" } */
>
> void
> foo (void)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-06 10:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-05 16:13 [PATCH] Fix testcase to not use vtable verification with LTO Caroline Tice via gcc-patches
2019-09-06 10:27 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).