From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119387 invoked by alias); 6 Sep 2019 10:27:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 119379 invoked by uid 89); 6 Sep 2019 10:27:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-lf1-f68.google.com Received: from mail-lf1-f68.google.com (HELO mail-lf1-f68.google.com) (209.85.167.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Sep 2019 10:27:28 +0000 Received: by mail-lf1-f68.google.com with SMTP id l11so4577241lfk.6 for ; Fri, 06 Sep 2019 03:27:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yDBexToP3opqkUcE8uMJI38UkqdNGtJhbnZ8L3LGNHE=; b=bY2QeBmZwT7Fs/xrzAfMdepHQBZfTRcfgqbAdcLlAezvvnj7khuK7/tl4xBgKHnr/V FKT70txcO0pIY8jYC2+8t8ZO9JZL7OcePbsPHkAIwaaQJjQzPUFfWn2heYU4/k15EXBc RKtkkXwhddmERyyGhVgoizN8K9Xgqyn9K2OEONvyAI80Obat3mv5/mjFYdR7lh7ZaGez eanTiP86gmeClaebjX51P91AcPv1Pnu8K1IMT/FHYkqHsX5xip6ckGFfCf6a0YW9+PDt kc6X3cnWHTRJSXWltAe9U85aRUXGo0XjFSimEBWM7RNx7g+eyj8qqhsZeQFpbD237wds YD8w== MIME-Version: 1.0 References: In-Reply-To: From: Richard Biener Date: Fri, 06 Sep 2019 10:27:00 -0000 Message-ID: Subject: Re: [PATCH] Fix testcase to not use vtable verification with LTO To: Caroline Tice Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00356.txt.bz2 On Thu, Sep 5, 2019 at 6:13 PM Caroline Tice via gcc-patches wrote: > > Yesterday I submitted a patch that disallows using vtable verfication > with LTO (they don't work > properly together), but I missed fixing the flags for one testcase. > This patch fixes that omission. > > Testing: Tescase passes with this change. > > Is this ok to commit? OK. Richard. > -- Caroline > cmtice@google.com > > ChangeLog entry (gcc/testsuite/ChangeLog): > > 2019-09-05 Caroline Tice > > PR testsuite/91670 > * g++.dg/ubsan/pr59415.C: Disable LTO, since test uses > -fvtable-verify, and the two options are no longer allowed > together. > > Index: gcc/testsuite/g++.dg/ubsan/pr59415.C > =================================================================== > --- gcc/testsuite/g++.dg/ubsan/pr59415.C (revision 275387) > +++ gcc/testsuite/g++.dg/ubsan/pr59415.C (working copy) > @@ -1,5 +1,5 @@ > /* { dg-do compile } */ > -/* { dg-options "-fsanitize=null -Wall -fvtable-verify=std" } */ > +/* { dg-options "-fsanitize=null -Wall -fvtable-verify=std -fno-lto" } */ > > void > foo (void)