public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [Patch] Fix lto-wrapper link flags
@ 2018-02-19 10:11 Christophe Lyon
  2018-02-26 10:59 ` Richard Biener
  0 siblings, 1 reply; 2+ messages in thread
From: Christophe Lyon @ 2018-02-19 10:11 UTC (permalink / raw)
  To: gcc Patches

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

Hi,

I think there's a typo in gcc/Makefile.in, where lto-wrapper is linked
using $(ALL_COMPILERFLAGS) while it should be $(ALL_LINKERFLAGS).

I noticed this while playing with linker flags, and not seeing them
when linking lto-wrapper.
It seems obvious, but maybe I'm missing something?

OK for trunk?

Thanks,

Christophe

[-- Attachment #2: lto-wrapper.chlog.txt --]
[-- Type: text/plain, Size: 127 bytes --]

gcc/ChangeLog:

2018-02-19  Christophe Lyon  <christophe.lyon@linaro.org>

	* Makefile.in (lto-wrapper): Use ALL_LINKERFLAGS.


[-- Attachment #3: lto-wrapper.patch.txt --]
[-- Type: text/plain, Size: 521 bytes --]

diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index 6c37e46..c91499d 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -2151,7 +2151,7 @@ CFLAGS-collect2.o += -DTARGET_MACHINE=\"$(target_noncanonical)\" \
 
 LTO_WRAPPER_OBJS = lto-wrapper.o collect-utils.o ggc-none.o
 lto-wrapper$(exeext): $(LTO_WRAPPER_OBJS) libcommon-target.a $(LIBDEPS)
-	+$(LINKER) $(ALL_COMPILERFLAGS) $(LDFLAGS) -o T$@ \
+	+$(LINKER) $(ALL_LINKERFLAGS) $(LDFLAGS) -o T$@ \
 	   $(LTO_WRAPPER_OBJS) libcommon-target.a $(LIBS)
 	mv -f T$@ $@
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Patch] Fix lto-wrapper link flags
  2018-02-19 10:11 [Patch] Fix lto-wrapper link flags Christophe Lyon
@ 2018-02-26 10:59 ` Richard Biener
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2018-02-26 10:59 UTC (permalink / raw)
  To: Christophe Lyon; +Cc: gcc Patches

On Mon, Feb 19, 2018 at 11:11 AM, Christophe Lyon
<christophe.lyon@linaro.org> wrote:
> Hi,
>
> I think there's a typo in gcc/Makefile.in, where lto-wrapper is linked
> using $(ALL_COMPILERFLAGS) while it should be $(ALL_LINKERFLAGS).
>
> I noticed this while playing with linker flags, and not seeing them
> when linking lto-wrapper.
> It seems obvious, but maybe I'm missing something?
>
> OK for trunk?

Ok.

Richard.

> Thanks,
>
> Christophe

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-02-26 10:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-19 10:11 [Patch] Fix lto-wrapper link flags Christophe Lyon
2018-02-26 10:59 ` Richard Biener

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).