From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id E55E23857B8E for ; Wed, 13 Sep 2023 06:50:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E55E23857B8E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-50079d148aeso11039042e87.3 for ; Tue, 12 Sep 2023 23:50:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694587804; x=1695192604; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+Q2IAbUe+euHY3TF+MGryNwRrYWVZfTtkcBCLqx6Hzk=; b=IhnN2liHDuwcHAx8NcLcI5Wtd/zxC49C78bGb20POYKIlniGVE6+EQ+Z9NCilaV484 T5C8BH6JJp9AHH5hVTSJY4SRrXN6vMHLpdybBX6b94ZV45aV/MN30rwSqmEbwBv0/O6z O5r1Mv2G49UP8BYEDNQnEpD5a5LD+r/Z+paiT0+npXhxMD8nfTEt+RpiHoVZCGU4++F0 wyOXb5oG6i9FBkGIJQH1FNZz4AF8nUaYDMURsQSr8LTY/tWy36i7oxzXrH2IESn1ZWZd wTKvSHchNMAB80NQaulM6DPO1t+gEQAQ/f1u0GSWC/VuXy+O2s/Ar9OQ1+YlD2w7FfX6 yyPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694587804; x=1695192604; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+Q2IAbUe+euHY3TF+MGryNwRrYWVZfTtkcBCLqx6Hzk=; b=Wo4jJvKoCGAMwTPkrhN8CqgI/Be8uZqn31CFslMV5Ly4WtqsXR+R7+ILGO5QpYOacD V95vH1305QN4fzAfQv22uxmLzh8xBQTj4Z9fDh4Usl2LqAzSVTTmdKp2iufcjn2GvDhl ruOuNWVUsyOlo8PVgV0sbOgviOQBBFsCXlBgXDP696vDyp71uNoNTFCia824DP8+o/9l aTW8QX4ka+TqfrLOSabi2PtDtS7rVAS4tJEsG+Lpr764xg6RQ++VJSV2pV861OLCZ4gu CZ8D5tmU1RnBuAu6m8YA5ldmHblOi59awO8FXXaFSFw+B93sGh7hA8xWc39s3t1cGtMV KT/A== X-Gm-Message-State: AOJu0Yz3/6zIYFOH/1jGWbVyMGL6m3ieI/h58NTUMIgzVV0QSg8voZL9 D+1d1GPIynRFeOXyc/G2rVyfyHVcEIojS/K9Cjh5CdGB X-Google-Smtp-Source: AGHT+IH+9J6mFz3RFPfqUMa0DzaSYPZL5BclRRS9p8Xis3MpyKvUAWumLj5Dq2I6Qzv1RTg0+Y4LWma+k9wG0/ZUbwE= X-Received: by 2002:ac2:4f13:0:b0:500:a41d:354c with SMTP id k19-20020ac24f13000000b00500a41d354cmr1337334lfr.28.1694587803967; Tue, 12 Sep 2023 23:50:03 -0700 (PDT) MIME-Version: 1.0 References: <20230717090250.4645-10-snoiry@kalrayinc.com> <20230912100713.1074-1-snoiry@kalrayinc.com> <20230912100713.1074-9-snoiry@kalrayinc.com> In-Reply-To: From: Richard Biener Date: Wed, 13 Sep 2023 08:48:01 +0200 Message-ID: Subject: Re: [PATCH v2 08/11] Native complex ops: Add explicit vector of complex To: Joseph Myers Cc: Sylvain Noiry , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Sep 12, 2023 at 7:26=E2=80=AFPM Joseph Myers wrote: > > On Tue, 12 Sep 2023, Sylvain Noiry via Gcc-patches wrote: > > > Summary: > > Allow the creation and usage of builtins vectors of complex > > in C, using __attribute__ ((vector_size ())) > > If you're adding a new language feature like this, you need to update > extend.texi to explain the valid uses of the attribute for complex types, > and (under "Vector Extensions") the valid uses of the resulting vectors. > You also need to add testcases to the testsuite for such vectors - both > execution tests covering valid uses of the vectors, and tests that invali= d > declarations or uses of such vectors (uses with any operator, or other > operand to such operator, that aren't valid) are properly rejected - go > through all cases of operators, with one or two complex vector operands, > of the same or different types, and with different choices for what type > the other operand might be when one has complex vector type, and make sur= e > they are all properly tested and do have the desired and documented > semantics. > > If the intended semantics are the same for C and C++, the tests should be > c-c++-common tests. Any cases where the intended semantics are different > will need separate tests for each language or appropriately conditional > test assertions in c-c++-common. And to add - in other related discussions we always rejected adding vector = types of composite types. I realize that if the hardware supports vector complex arithmetic instructions this might be the first true good reason to allow t= hese. Richard. > -- > Joseph S. Myers > joseph@codesourcery.com