From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id 64E2D3858402 for ; Wed, 13 Oct 2021 08:39:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 64E2D3858402 Received: by mail-ed1-x52c.google.com with SMTP id r18so6843772edv.12 for ; Wed, 13 Oct 2021 01:39:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=QIv2tikdSPlLAUifmwofmtAMOv1VDCTRFRB6frez0UU=; b=YQyyixR1L66LqFOFKXugdNrpCg2Q8V6CyF87DiLeVAI3XfTU1XZe/wDRJvlJ2vC09v TJMkAf91/Tj/TNFQtpw+Tf2KegjiNgLGFeu4bZqN3Xu5lspz6tvz7ldnZ1htlL7M8Tcc r+6D+joFUQqNq0pCKf6o1++btAAFroEov2Gn4CAVz9tUAfrRugj+X4GiPFRz8hYe/yat J6Uyrouvx1nJOPisn8zBFSLSjVd50uHlKdM0NnzL8xjbbtnnUwbQnwYRwMD3qU202g1i C1swplEm7G+AO03SV3qqIC3ZtUS6PvC9/9qQC7nwr4I+oW0hFWY/XcKbHT6IFOO88DmS n95Q== X-Gm-Message-State: AOAM533m2Yvx22IY22se6TOWrrN7pm+fxGJ/mKn9IjrOntkhnPdCH5sn KOL9hsnYSDVg9Fs4kxCWrOLZBvISu5th6qSz2/o= X-Google-Smtp-Source: ABdhPJzu5PJHF4eHLXlV7ME0B1Kp+Q9JEm9GYnHV6eDEXPFnvWMzZrHktqbrzqMulKoyr+BBvY5/VyYZlkHRliXw9mw= X-Received: by 2002:aa7:c78f:: with SMTP id n15mr7838639eds.338.1634114365491; Wed, 13 Oct 2021 01:39:25 -0700 (PDT) MIME-Version: 1.0 References: <12fd0c18-79e0-d20d-2973-92639071c050@suse.cz> In-Reply-To: From: Richard Biener Date: Wed, 13 Oct 2021 10:39:14 +0200 Message-ID: Subject: Re: [PATCH] Fix handling of flag_rename_registers. To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: "Joseph S. Myers" , GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Oct 2021 08:39:34 -0000 On Tue, Oct 12, 2021 at 5:11 PM Martin Li=C5=A1ka wrote: > > On 10/12/21 15:37, Richard Biener wrote: > > by adding EnabledBy(funroll-loops) to the respective options instead > > (and funroll-loops EnabledBy(funroll-all-loops)) > > All right, so the suggested approach works correctly. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? funroll-all-loops -Common Var(flag_unroll_all_loops) Optimization +Common Var(flag_unroll_all_loops) Optimization EnabledBy(funroll-all-loops= ) that should be on funroll-loops? Can you verify that the two-step -funroll-all-loops -> -funroll-loops -> -frename-registers works and that it is not somehow dependent on ordering? Otherwise we have = to use EnabledBy(funroll-loops,funroll-all-loops) on frename-registers. I guess the EnabledBy doesn't work if the target decides to set flag_unroll_loop in one= of its hooks rather than via its option table override? (as said, this is all a mess...) But grep should be your friend telling whether any target overrides any of the flags... I do hope we can eventually reduce the number of pre-/post-/lang/target/com= mon processing phases for options :/ Meh. Richard. > Thanks, > Martin