public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Biener <richard.guenther@gmail.com>
To: gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com
Subject: Re: RFA: Allow widening multiplication in tree-ssa/slsr-8.c
Date: Mon, 14 Jan 2013 14:44:00 -0000	[thread overview]
Message-ID: <CAFiYyc29CaLfmSf-Sn3smZS35hB3Spa+5J2OL7y9dF1p1kQDhA@mail.gmail.com> (raw)
In-Reply-To: <874nilzctx.fsf@talisman.default>

On Sun, Jan 13, 2013 at 9:50 AM, Richard Sandiford
<rdsandiford@googlemail.com> wrote:
> gcc.dg/tree-ssa/slsr-8.c does "(int) index * (size_t) element_size",
> which on LP64 targets can use a widening multiplication.  Of course,
> for simple element sizes like these, we end up using a shift instead,
> but that's a decision that's rightly made later.
>
> Tested on x86_64-linux-gnu, mips64-linux-gnu and mipsisa64-elf.
> OK to install?

Ok.

Thanks,
Richard.

> Richard
>
>
> gcc/testsuite/
>         * gcc.dg/tree-ssa/slsr-8.c: Allow widening multiplications.
>
> Index: gcc/testsuite/gcc.dg/tree-ssa/slsr-8.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/tree-ssa/slsr-8.c      2013-01-13 08:05:03.403375571 +0000
> +++ gcc/testsuite/gcc.dg/tree-ssa/slsr-8.c      2013-01-13 08:46:05.246550444 +0000
> @@ -18,6 +18,7 @@ f (int s, int *c)
>  }
>
>  /* There are 4 ' * ' instances in the decls (since "int * iftmp.0;" is
> -   added), 1 parm, 2 in the code.  */
> -/* { dg-final { scan-tree-dump-times " \\* " 7 "optimized" } } */
> +   added), 1 parm, 2 in the code.  The second one in the code can be
> +   a widening mult.  */
> +/* { dg-final { scan-tree-dump-times " w?\\* " 7 "optimized" } } */
>  /* { dg-final { cleanup-tree-dump "optimized" } } */

      reply	other threads:[~2013-01-14 14:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-13  8:50 Richard Sandiford
2013-01-14 14:44 ` Richard Biener [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFiYyc29CaLfmSf-Sn3smZS35hB3Spa+5J2OL7y9dF1p1kQDhA@mail.gmail.com \
    --to=richard.guenther@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rdsandiford@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).