From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 789 invoked by alias); 14 Jan 2013 14:44:03 -0000 Received: (qmail 738 invoked by uid 22791); 14 Jan 2013 14:44:01 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL,BAYES_05,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_NEUTRAL X-Spam-Check-By: sourceware.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Jan 2013 14:43:47 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TufSm-0007pW-3f for gcc-patches@gcc.gnu.org; Mon, 14 Jan 2013 03:32:17 -0500 Received: from mail-wi0-f179.google.com ([209.85.212.179]:50380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TueRJ-0000xM-1s for gcc-patches@gcc.gnu.org; Mon, 14 Jan 2013 02:26:37 -0500 Received: by mail-wi0-f179.google.com with SMTP id o1so1040389wic.0 for ; Sun, 13 Jan 2013 23:26:34 -0800 (PST) MIME-Version: 1.0 Received: by 10.194.142.162 with SMTP id rx2mr21396065wjb.17.1358148394864; Sun, 13 Jan 2013 23:26:34 -0800 (PST) Received: by 10.194.179.130 with HTTP; Sun, 13 Jan 2013 23:26:34 -0800 (PST) In-Reply-To: <874nilzctx.fsf@talisman.default> References: <874nilzctx.fsf@talisman.default> Date: Mon, 14 Jan 2013 14:44:00 -0000 Message-ID: Subject: Re: RFA: Allow widening multiplication in tree-ssa/slsr-8.c From: Richard Biener To: gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com Content-Type: text/plain; charset=ISO-8859-1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.212.179 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg00686.txt.bz2 On Sun, Jan 13, 2013 at 9:50 AM, Richard Sandiford wrote: > gcc.dg/tree-ssa/slsr-8.c does "(int) index * (size_t) element_size", > which on LP64 targets can use a widening multiplication. Of course, > for simple element sizes like these, we end up using a shift instead, > but that's a decision that's rightly made later. > > Tested on x86_64-linux-gnu, mips64-linux-gnu and mipsisa64-elf. > OK to install? Ok. Thanks, Richard. > Richard > > > gcc/testsuite/ > * gcc.dg/tree-ssa/slsr-8.c: Allow widening multiplications. > > Index: gcc/testsuite/gcc.dg/tree-ssa/slsr-8.c > =================================================================== > --- gcc/testsuite/gcc.dg/tree-ssa/slsr-8.c 2013-01-13 08:05:03.403375571 +0000 > +++ gcc/testsuite/gcc.dg/tree-ssa/slsr-8.c 2013-01-13 08:46:05.246550444 +0000 > @@ -18,6 +18,7 @@ f (int s, int *c) > } > > /* There are 4 ' * ' instances in the decls (since "int * iftmp.0;" is > - added), 1 parm, 2 in the code. */ > -/* { dg-final { scan-tree-dump-times " \\* " 7 "optimized" } } */ > + added), 1 parm, 2 in the code. The second one in the code can be > + a widening mult. */ > +/* { dg-final { scan-tree-dump-times " w?\\* " 7 "optimized" } } */ > /* { dg-final { cleanup-tree-dump "optimized" } } */