From: Richard Guenther <richard.guenther@gmail.com>
To: Richard Henderson <rth@redhat.com>
Cc: Aldy Hernandez <aldyh@redhat.com>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] 19/n: trans-mem: compiler tree/gimple stuff
Date: Sat, 05 Nov 2011 10:18:00 -0000 [thread overview]
Message-ID: <CAFiYyc2=AP=0A2BEBX3s6JUFO0M1Huj-haYKUe73JXmgeboWrg@mail.gmail.com> (raw)
In-Reply-To: <4EB4A54B.1010701@redhat.com>
On Sat, Nov 5, 2011 at 3:54 AM, Richard Henderson <rth@redhat.com> wrote:
> On 11/04/2011 07:36 PM, Richard Henderson wrote:
>> On 11/04/2011 03:36 AM, Richard Guenther wrote:
>>>>> + case GIMPLE_TRANSACTION:
>>>>> + return (weights->tm_cost
>>>>> + + estimate_num_insns_seq (gimple_transaction_body (stmt),
>>>>> + weights));
>>>>> +
>>> Huh, so we now have non-lowered gimple sub-sequence throughout all
>>> optimizations (inlining especially)? :(
>>
>> No. I'm not sure why we're still looking at gimple_transaction_body
>> here -- that should be NULL after lowering.
> ... of course, I'm not sure why we're looking at all those other
> nested statements there inside the inliner either. At least we're
> doing the same thing as everyone else here.
It might be because of nested function lowering which works on
gimple like it falls out of the gimplifier. So it might all be correct
after all ...
Sorry for the noise.
Richard.
>
> r~
>
next prev parent reply other threads:[~2011-11-05 8:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 19:40 Aldy Hernandez
2011-11-04 10:44 ` Richard Guenther
2011-11-05 0:25 ` Aldy Hernandez
2011-11-05 2:54 ` Richard Henderson
2011-11-05 9:11 ` Richard Guenther
2011-11-05 18:14 ` Aldy Hernandez
2011-11-05 23:03 ` Richard Guenther
2011-11-06 10:10 ` Aldy Hernandez
2011-11-06 10:51 ` Richard Guenther
2011-11-05 3:11 ` Richard Henderson
2011-11-05 3:23 ` Richard Henderson
2011-11-05 10:18 ` Richard Guenther [this message]
2011-11-05 21:26 ` Aldy Hernandez
2011-11-05 23:16 ` Richard Guenther
2011-11-07 19:06 ` Richard Henderson
2011-11-07 19:46 ` Aldy Hernandez
2011-11-07 22:38 ` Richard Guenther
2011-11-06 0:51 ` Aldy Hernandez
2011-11-06 10:17 ` Richard Guenther
2011-11-07 17:47 ` Richard Henderson
2011-11-04 15:40 ` Michael Matz
2011-11-05 8:47 ` Aldy Hernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc2=AP=0A2BEBX3s6JUFO0M1Huj-haYKUe73JXmgeboWrg@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).