From: Richard Biener <richard.guenther@gmail.com>
To: "Hurugalawadi, Naveen" <Naveen.Hurugalawadi@caviumnetworks.com>
Cc: "marc.glisse@inria.fr" <marc.glisse@inria.fr>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PR25529] Convert (unsigned t * 2)/2 into unsigned (t & 0x7FFFFFFF)
Date: Wed, 22 Jul 2015 12:10:00 -0000 [thread overview]
Message-ID: <CAFiYyc2=EyQvrDK+4PfUMQwHLY1EK0ZDg5WoY+ZXQ8k5oP_7NQ@mail.gmail.com> (raw)
In-Reply-To: <DM2PR0701MB1018959170F8B70E4C982C628E840@DM2PR0701MB1018.namprd07.prod.outlook.com>
On Tue, Jul 21, 2015 at 11:16 AM, Hurugalawadi, Naveen
<Naveen.Hurugalawadi@caviumnetworks.com> wrote:
> Hi,
>
>>> For signed types with TYPE_OVERFLOW_UNDEFINED
>>> you can simply cancel the operation (even for non-power-of-two multipliers).
>
> Thanks for the review and comments.
>
> Please find attached the modified patch as per your comments.
>
> Please review the same and let me know if any further modifications are required.
>
> Regression Tested on X86_64.
@@ -280,6 +280,20 @@ along with GCC; see the file COPYING3. If not see
&& integer_pow2p (@2) && tree_int_cst_sgn (@2) > 0)
(bit_and @0 (convert (minus @1 { build_int_cst (TREE_TYPE (@1), 1); }))))))
+/* Simplify (unsigned t * 2)/2 -> unsigned t & 0x7FFFFFFF. */
+(simplify
+ (exact_div (mult @0 INTEGER_CST@1) @1)
+ (if (TYPE_OVERFLOW_UNDEFINED (TREE_TYPE (@0)))
+ @0))
The comment applies to the pattern below and the pattern above lacks a comment
+(simplify
+ (trunc_div (mult @0 integer_pow2p@1) @1)
+ (if (TYPE_UNSIGNED (TREE_TYPE (@0)))
+ (with { tree n2 = build_int_cst (TREE_TYPE (@0),
+ wi::exact_log2 (@1)); }
+ (bit_and @0 (rshift (lshift { build_minus_one_cst (TREE_TYPE (@0)); }
+ { n2; }) { n2; })))))
please use
(with
{
int n2 = wi::exact_log2 (@1);
tree mask = wide_int_to_tree (type, wi::rshift (wi::lshift (-1, n2), n2));
}
(bit_and @0 { mask; }))))
in fact, the -1 << log2 >> log2 looks like it does wi::mask
(TYPE_PRECISION (type) - wi::exact_log2 (@1), false, TYPE_PRECISION
(type));
so using wi::mask is prefered here.
Thanks,
Richard.
> Thanks,
> Naveen
>
> gcc/testsuite/ChangeLog:
>
> 2015-07-21 Naveen H.S <Naveen.Hurugalawadi@caviumnetworks.com>
>
> PR middle-end/25529
> * gcc.dg/pr25529.c: New test.
>
> gcc/ChangeLog:
>
> 2015-07-21 Naveen H.S <Naveen.Hurugalawadi@caviumnetworks.com>
>
> PR middle-end/25529
> * match.pd (exact_div (mult @0 INTEGER_CST@1) @1) : New simplifier.
> (trunc_div (mult @0 integer_pow2p@1) @1) : New simplifier.
next prev parent reply other threads:[~2015-07-22 11:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 4:52 Hurugalawadi, Naveen
2015-07-07 6:06 ` Marc Glisse
2015-07-07 9:12 ` Richard Biener
2015-07-07 9:24 ` Marc Glisse
2015-07-07 9:35 ` Richard Biener
2015-07-21 9:16 ` Hurugalawadi, Naveen
2015-07-22 12:10 ` Richard Biener [this message]
2015-07-23 3:59 ` Hurugalawadi, Naveen
2015-07-23 13:36 ` Richard Biener
2015-08-07 8:44 ` Hurugalawadi, Naveen
2015-08-11 12:50 ` Richard Biener
2015-08-11 12:51 ` Richard Biener
2015-08-20 20:10 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiYyc2=EyQvrDK+4PfUMQwHLY1EK0ZDg5WoY+ZXQ8k5oP_7NQ@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=Naveen.Hurugalawadi@caviumnetworks.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=marc.glisse@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).