From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <richard.guenther@gmail.com>
Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d])
	by sourceware.org (Postfix) with ESMTPS id 60C4D385115C
	for <gcc-patches@gcc.gnu.org>; Thu, 13 Oct 2022 11:40:30 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 60C4D385115C
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-ej1-x62d.google.com with SMTP id fy4so3285483ejc.5
        for <gcc-patches@gcc.gnu.org>; Thu, 13 Oct 2022 04:40:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:from:to:cc:subject:date
         :message-id:reply-to;
        bh=t7QWyzqlue0t2YaA6fRe6DlIIHDW9/Wrbwkkp92SAbM=;
        b=VJzIrbRE4DYQ9Qecs+v9zxQ6+z4tu1me3XCOGJip30Zlih/RjFpg4pVLAKMGloDgAF
         zfRdsIEemhSp26iSxQivyijKHLS01Fqsive7LYx7+z6+wK8oUf+wNu6Wswgod+Xv8LgK
         2QHUp7T/XZhXR2F6s3Lf3X+ZXR+McQaodwLNrEIOl/jBEq1/G95QygFINGgPiWhcX6HD
         bLVbKNfy3WUqpexL1qb7jGDsGVkZ7CVDkL1SURRoI+28+42j32YeM6qEKAitgPUZcKZp
         3UrrfOITNhTEmeOMfxArdNq+fo37w2E8uL3aSUNhwORHmz06Gl/a0BteNSSzxyACC2tw
         OK3w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=t7QWyzqlue0t2YaA6fRe6DlIIHDW9/Wrbwkkp92SAbM=;
        b=TzAQgZrsa2tyudvf2wrqcQVTEUHRhkZFKJL59YRM3gTKnz/g7F5pgDY8UXPThJ5xV+
         M+ZQd1i6/OgtqtHQjkcI11Vv+ydCvg8WnkVFSr2ASOpaWs24QXloPrLKHnhGTKqD8ehT
         0R32x0/Nh3CEPQvBVvc/LsyVszYDLnmBOHj0oq+Qv1ejyZeRBgJIoP/1YJq/W9176sin
         HmbVL06YwQfGM/t9YRRLYJleUQEsW2zf+C9TI6GDjGxz0JUBG7J4eU6klKcaE0mycOWd
         3xQXrcxD2Xm6Zpnl2Mm8DWdlxv264qdFWy5pPZpd8T5aZV/4uevfm0Mc5NG1FHhoPT4Q
         ddTA==
X-Gm-Message-State: ACrzQf3ThvMZcdIYerGt9MNfqY/LLqBPkRqXt3pEvoVDY38ae72kZp8o
	R0H8XBtiSOyS1Gjw9yOevnsRiOAydHRzw5Lc5ho=
X-Google-Smtp-Source: AMsMyM7ATiiuXMTXUoBcCsXNasKdGeK3bABT6RwCOnnxHCifKJlyftWTcthMe4CQZ3TwQOzJb1MlhgD79tQhDFitv0Q=
X-Received: by 2002:a17:907:7635:b0:78d:74c2:a986 with SMTP id
 jy21-20020a170907763500b0078d74c2a986mr24948344ejc.442.1665661229092; Thu, 13
 Oct 2022 04:40:29 -0700 (PDT)
MIME-Version: 1.0
References: <20221011124303.99673-1-jorgen.kvalsvik@woven-planet.global> <20221011124303.99673-2-jorgen.kvalsvik@woven-planet.global>
In-Reply-To: <20221011124303.99673-2-jorgen.kvalsvik@woven-planet.global>
From: Richard Biener <richard.guenther@gmail.com>
Date: Thu, 13 Oct 2022 13:40:16 +0200
Message-ID: <CAFiYyc2=ai4dLcCp7J=maZ4YzDYR_ezFNYNVz88GjaKY2GUfNQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] gcov: test line count for label in then/else block
To: =?UTF-8?Q?J=C3=B8rgen_Kvalsvik?= <jorgen.kvalsvik@woven-planet.global>
Cc: gcc-patches@gcc.gnu.org, mliska@suse.cz
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Tue, Oct 11, 2022 at 2:43 PM J=C3=B8rgen Kvalsvik
<jorgen.kvalsvik@woven-planet.global> wrote:
>
> Add a test to catch regression in line counts for labels on top of
> then/else blocks. Only the 'goto <label>' should contribute to the line
> counter for the label, not the if.

OK.

> gcc/testsuite/ChangeLog:
>
>         * gcc.misc-tests/gcov-4.c:
> ---
>  gcc/testsuite/gcc.misc-tests/gcov-4.c | 26 +++++++++++++++++++++++++-
>  1 file changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.misc-tests/gcov-4.c b/gcc/testsuite/gcc.mi=
sc-tests/gcov-4.c
> index 498d299b66b..da7929ef7fc 100644
> --- a/gcc/testsuite/gcc.misc-tests/gcov-4.c
> +++ b/gcc/testsuite/gcc.misc-tests/gcov-4.c
> @@ -110,6 +110,29 @@ lab2:
>    return 8;                            /* count(1) */
>  }
>
> +int
> +test_goto3 (int i, int j)
> +{
> +    if (j) goto else_;         /* count(1) */
> +
> +top:
> +    if (i)                     /* count(1) */
> +      {
> +       i =3D do_something (i);
> +      }
> +    else
> +      {
> +else_:                         /* count(1) */
> +       j =3D do_something (j);   /* count(2) */
> +       if (j)                  /* count(2) */
> +         {
> +           j =3D 0;              /* count(1) */
> +           goto top;           /* count(1) */
> +         }
> +      }
> +    return 16;
> +}
> +
>  void
>  call_goto ()
>  {
> @@ -117,6 +140,7 @@ call_goto ()
>    goto_val +=3D test_goto1 (1);
>    goto_val +=3D test_goto2 (3);
>    goto_val +=3D test_goto2 (30);
> +  goto_val +=3D test_goto3 (0, 1);
>  }
>
>  /* Check nested if-then-else statements. */
> @@ -260,7 +284,7 @@ main()
>    call_unref ();
>    if ((for_val1 !=3D 12)
>        || (for_val2 !=3D 87)
> -      || (goto_val !=3D 15)
> +      || (goto_val !=3D 31)
>        || (ifelse_val1 !=3D 31)
>        || (ifelse_val2 !=3D 23)
>        || (ifelse_val3 !=3D 246)
> --
> 2.34.0
>