From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id B75C43896805 for ; Mon, 7 Jun 2021 17:46:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B75C43896805 Received: by mail-ej1-x635.google.com with SMTP id k25so22577760eja.9 for ; Mon, 07 Jun 2021 10:46:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PwCTknZR4eufJrIXXUUdyLNa2o+kxiYqbg/XDB7a8Yc=; b=DeLv5UsSgmCYtkYl+XgLqoRrNcHIJB9zh4HhHoT9fnBBLOD6F3K9P5UC3YHEKmTJmD IQA54H0oOXPrGCnE42nf1ulSYvCxr0xo3ibzn5aHPUt+aGB0LltWjpCpxJn9Z9k7IF3c XGBM7V6RVIApqZQijMcyzE9mxVIRnD3J1LYlhhYoJbTygNg7BrVqE+snwfvleBvDAQd6 Tl7Bm8skf4rUBM5sgwjxU449F04BsQnUrE6bQP2jrrSfyzFgosQstWvP6KXgr1SZppnL eoFpCRQGKybSe3btiLxBXSylK9ZNM3sC0JbgWlnJGiP6TpanaHP/afH5Hc2tJ1YcTGFz O+jw== X-Gm-Message-State: AOAM533N315LKJBDVprbseGLVEOA9pTEgaAI4mDLstN+RBF4O8h0IU/i 4iiR5G5qP/ZhApRnbFwGqVB5ag4t359x5GjU06s= X-Google-Smtp-Source: ABdhPJxxdN4HFxt9xQgdxRQsnbDsz/6NzLfSGQ5hHIQIBC30cJFz/DC7d/10gouSMbMTpXyiyOM92/8iXU0rk5M1SzA= X-Received: by 2002:a17:906:a458:: with SMTP id cb24mr19138761ejb.482.1623087965773; Mon, 07 Jun 2021 10:46:05 -0700 (PDT) MIME-Version: 1.0 References: <26d623c5117d22fbaea2ce1a445ba2d32df437ad.1619537141.git.wschmidt@linux.ibm.com> <20210520222454.GW10366@gate.crashing.org> <9a9dcf68-cdef-507a-a124-a9229e5c7c0b@linux.ibm.com> <2d0a308c-5e5b-d3a4-3d66-b16245d9c9a4@linux.ibm.com> In-Reply-To: From: Richard Biener Date: Mon, 7 Jun 2021 19:45:54 +0200 Message-ID: Subject: Re: [PATCH 02/57] Support scanning of build-time GC roots in gengtype To: Bill Schmidt Cc: Bill Schmidt via Gcc-patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2021 17:46:08 -0000 On Mon, Jun 7, 2021 at 5:38 PM Bill Schmidt wrote: > > On 6/7/21 8:36 AM, Richard Biener wrote: > > > > Some maybe obvious issue - what about DOS-style path hosts? > > You seem to build ../ strings to point to parent dirs... I'm not sure > > what we do elsewhere - I suppose we arrange for appropriate > > -I command line arguments? > > > Well, actually it's just using "./" to identify the build directory, > though I see what you mean about potential Linux bias. There is > precedent for this syntax identifying the build directory in config.gcc > for target macro files: > > # tm_file A list of target macro files, if different from > # "$cpu_type/$cpu_type.h". Usually it's constructed > # per target in a way like this: > # tm_file="${tm_file} dbxelf.h elfos.h > ${cpu_type.h}/elf.h" > # Note that the preferred order is: > # - specific target header > "${cpu_type}/${cpu_type.h}" > # - generic headers like dbxelf.h elfos.h, etc. > # - specializing target headers like > ${cpu_type.h}/elf.h > # This helps to keep OS specific stuff out of the CPU > # defining header ${cpu_type}/${cpu_type.h}. > # > # It is possible to include automatically-generated > # build-directory files by prefixing them with "./". > # All other files should relative to $srcdir/config. > > ...so I thought I would try to be consistent with this change. In patch > 0025 I use this as follows: > > --- a/gcc/config.gcc > +++ b/gcc/config.gcc > @@ -491,6 +491,7 @@ powerpc*-*-*) > extra_options="${extra_options} g.opt fused-madd.opt > rs6000/rs6000-tables.opt" > target_gtfiles="$target_gtfiles > \$(srcdir)/config/rs6000/rs6000-logue.c > \$(srcdir)/config/rs6000/rs6000-call.c" > target_gtfiles="$target_gtfiles > \$(srcdir)/config/rs6000/rs6000-pcrel-opt.c" > + target_gtfiles="$target_gtfiles ./rs6000-builtins.h" > ;; > pru-*-*) > cpu_type=pru > > I'm open to trying to do something different if you think that's > appropriate. Well, I'm not sure whether/how to resolve this. You could try building a cross to powerpc-linux from a x86_64-mingw host ... maybe there's one on the CF? Or some of your fellow RedHat people have access to mingw or the like envs to try whether it just works with your change ... Otherwise it looks OK. Richard. > Thanks for your help with this! > > Bill >