From: Richard Biener <richard.guenther@gmail.com>
To: Georg-Johann Lay <avr@gjlay.de>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Denis Chertykov <chertykov@gmail.com>,
Eric Weddington <eric.weddington@atmel.com>
Subject: Re: [Patch,avr]: Fix wrong warning PR59396
Date: Thu, 05 Dec 2013 15:09:00 -0000 [thread overview]
Message-ID: <CAFiYyc2A931UXRhJj4H15KNH_2jkweXqMYtCdftYs+srroLT1g@mail.gmail.com> (raw)
In-Reply-To: <52A0937F.8020105@gjlay.de>
On Thu, Dec 5, 2013 at 3:53 PM, Georg-Johann Lay <avr@gjlay.de> wrote:
> This is a fix of a wrong warning for a bas ISR name. The assumption was
> that if DECL_ASSEMBLER_NAME is set, it would always starts with a *.
>
> This is not the case for LTO compiler where the assembler name is the plain
> name of the function (except an assembler name is set).
That sounds odd to me. Does the bug reproduce with -fwhole-program?
Or if the interrupt handler is static?
Richard.
> Thus, do a more restrictive test if the first character of the function name
> has to be skipped.
>
> Ok to commit?
>
> Johann
>
>
> PR target/59396
> * config/avr/avr.c (avr_set_current_function): If the first char
> of the function name is skipped, make sure it is actually '*'.
next prev parent reply other threads:[~2013-12-05 15:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 14:55 Georg-Johann Lay
2013-12-05 15:09 ` Richard Biener [this message]
2013-12-05 15:39 ` Georg-Johann Lay
2013-12-06 9:33 ` Richard Biener
2013-12-09 9:19 ` Georg-Johann Lay
2013-12-17 13:05 ` Georg-Johann Lay
2013-12-18 11:37 ` Richard Biener
2014-01-15 14:17 ` Georg-Johann Lay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFiYyc2A931UXRhJj4H15KNH_2jkweXqMYtCdftYs+srroLT1g@mail.gmail.com \
--to=richard.guenther@gmail.com \
--cc=avr@gjlay.de \
--cc=chertykov@gmail.com \
--cc=eric.weddington@atmel.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).